stdarch icon indicating copy to clipboard operation
stdarch copied to clipboard

docs: do not inline x86 instrinsics into x86-64

Open notriddle opened this issue 1 year ago • 3 comments

This reduces the size of the core/arch HTML from about 187M to 132M.

notriddle avatar Oct 08 '24 19:10 notriddle

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) some time within the next two weeks.

rustbot avatar Oct 08 '24 19:10 rustbot

While this does reduce the size, it actually makes the documentation incorrect: std::arch::x86 can't be accessed from x86-64: you need to use std::arch::x86_64 instead.

Amanieu avatar Oct 31 '24 22:10 Amanieu

I can remove the incorrect cfg(any()) part, but is the change to an explicitly-visible glob import acceptable?

notriddle avatar Nov 01 '24 00:11 notriddle