stdarch icon indicating copy to clipboard operation
stdarch copied to clipboard

Replace some calls to `pointer::offset` with `add` and `sub`

Open WaffleLapkin opened this issue 2 years ago • 5 comments

See https://github.com/rust-lang/rust/pull/100746

WaffleLapkin avatar Aug 19 '22 10:08 WaffleLapkin

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

Please see the contribution instructions for more information.

rust-highfive avatar Aug 19 '22 10:08 rust-highfive

Seeing https://github.com/rust-lang/stdarch/runs/7917316301?check_suite_focus=true (doc only change) I think CI fails not because of my changes 🤔

WaffleLapkin avatar Aug 19 '22 11:08 WaffleLapkin

It looks fairly strange since nobody touched ppc64le in ages. I'll try to see if the problem is in qemu by running on real hardware ...

lu-zero avatar Aug 19 '22 11:08 lu-zero

CI should be fixed by #1326, can you rebase?

Amanieu avatar Aug 20 '22 20:08 Amanieu

Rebased 👍🏻

WaffleLapkin avatar Aug 21 '22 00:08 WaffleLapkin