rustup icon indicating copy to clipboard operation
rustup copied to clipboard

remove rls support

Open rbtcollins opened this issue 2 years ago • 3 comments

With rust-analyzer taking over, should we remove the rls specific tests, and/or the rls proxy?

rbtcollins avatar Apr 11 '23 20:04 rbtcollins

The rls proxy is something of an active nuisance.

In its default configuration in emacs 29, eglot knows that both rls and rust-analyzer exist, sees that both are available on PATH, and prompts the user rather than just choosing to run rust-analyzer.

mattheww avatar Oct 07 '23 13:10 mattheww

I'd blame that on eglot, it shouldn't be trying to run rls. Consider filing an issue there.

(That's not to say the RA proxy itself isn't annoying if you compile your own RA, but it's the best way we have to make rustup-managed RA work. But that's a completely different topic.)

lnicola avatar Oct 07 '23 13:10 lnicola

Eglot upstream removed the reference to rls from its default configuration some months ago, but of course it takes time for these things to filter through to users, and there may well be other clients out there in a similar position.

mattheww avatar Oct 07 '23 13:10 mattheww

I believe all work required in this repo has concluded in #3920. As such, I'm closing this issue as completed now. For further work, please refer to https://github.com/rust-lang/rust/pull/126856.

rami3l avatar Oct 06 '24 07:10 rami3l