rustlings icon indicating copy to clipboard operation
rustlings copied to clipboard

Cannot run in gitpod due to edition2021

Open koaning opened this issue 4 years ago • 11 comments
trafficstars

When I run this repo in gitpod I witness this error message.

cargo install --force --path .
error: failed to parse manifest at `/workspace/rustlings/Cargo.toml`

Caused by:
  feature `edition2021` is required

  The package requires the Cargo feature called `edition2021`, but that feature is not stabilized in this version of Cargo (1.55.0 (32da73ab1 2021-08-23)).
  Consider trying a newer version of Cargo (this may require the nightly release).

Some other command is needed?

koaning avatar Nov 07 '21 13:11 koaning

Oh, I figured it would just use the latest stable version of Rust automatically... not sure where that would need to be changed.

manyinsects avatar Nov 08 '21 14:11 manyinsects

They update from time to time, but this one has been skipped :shrug: https://github.com/gitpod-io/workspace-images/pull/554

jrvidal avatar Nov 08 '21 15:11 jrvidal

I'm no longer stuck (see #554) The final step in my work-around was to run

gitpod /workspace/rustling $ ./install.sh

and the output:

   Installed package `rustlings v4.6.0 (/workspace/rustlings/rustlings)` (executable `rustlings`)
Installing the 'cargo-clippy' executable...
info: downloading component 'clippy'
info: installing component 'clippy'
All done! Run 'rustlings' to get started.
gitpod /workspace/rustlings $ rustlings

       welcome to...                      
                 _   _ _                  
  _ __ _   _ ___| |_| (_)_ __   __ _ ___  
 | '__| | | / __| __| | | '_ \ / _` / __| 
 | |  | |_| \__ \ |_| | | | | | (_| \__ \ 
 |_|   \__,_|___/\__|_|_|_| |_|\__, |___/ 
                               |___/      

Thanks for installing Rustlings!

xpat avatar Nov 08 '21 18:11 xpat

@xpat That makes sense, since it pulls from a tag, and the latest release doesn't conform to the 2021 edition yet. I suppose we'll just wait with pushing a new release until Gitpod decides they want to upgrade their Rust toolchain 🤷

manyinsects avatar Nov 09 '21 09:11 manyinsects

Hey folks, Geoff here from Gitpod. We were going to wait for v1.57 which is planned for 02/12 due to reports of drastically increased/endless compile times (due to the switch to a new llvm version). In response to CVE-2021-42574 we are upgrading the default image to v1.56.1. As a reminder one can bring their own Dockerfile to Gitpod and run nearly anything on the platform including operating systems.

ghuntley avatar Nov 10 '21 02:11 ghuntley

@ghuntley Thanks for the clarification! I think waiting should be fine, unless someone wants to take time to write a Dockerfile.

manyinsects avatar Nov 10 '21 08:11 manyinsects

v1.56.1 is now available on Gitpod in the default workspace image.

gitpod /workspace/new $ rustc --version
rustc 1.56.1 (59eed8a2a 2021-11-01)

ghuntley avatar Nov 10 '21 09:11 ghuntley

I might add replit has the same issue. Also, If I try checking out an old tag and installing, inotify dependency fails building.

junderw avatar Dec 05 '21 16:12 junderw

@ghuntley I just tried running through the gitpod link on the README and I was greeted with a gitpod that was using 1.55

junderw avatar Dec 06 '21 03:12 junderw

@ghuntley I just tried running through the gitpod link on the README and I was greeted with a gitpod that was using 1.55

I can confirm the same.

Tony-X avatar Dec 06 '21 06:12 Tony-X

Same issue on replit by the way, edition 2021 cannot be found. Rustup is also not accessable.

jaques-sam avatar Feb 08 '22 10:02 jaques-sam