rustfmt icon indicating copy to clipboard operation
rustfmt copied to clipboard

In macro definitions new name can start from $ without spaces before it.

Open rscprof opened this issue 1 year ago • 3 comments

5905

rscprof avatar Jan 17 '24 18:01 rscprof

@rscprof I also want to say thanks for another PR 🙏🏼! I see you've opened several recently. Out of curiosity, are these issues that you're trying to fix because you've run into these yourself or are you just trying to pick up tickets that interest you?

We have quite the backlog of PRs, and some of the issues you've opened PRs for are low priority, so just a fair warning that it might be a while before Caleb or I has a chance to review the work you've done.

ytmimi avatar Jan 17 '24 18:01 ytmimi

@rscprof I also want to say thanks for another PR 🙏🏼! I see you've opened several recently. Out of curiosity, are these issues that you're trying to fix because you've run into these yourself or are you just trying to pick up tickets that interest you?

We have quite the backlog of PRs, and some of the issues you've opened PRs for are low priority, so just a fair warning that it might be a while before Caleb or I has a chance to review the work you've done.

I'm just practicing rust and do something good for another people while I can. Now I just get issues with label "bug" if this issue don't have related pull-request or assignees.

rscprof avatar Jan 17 '24 19:01 rscprof

rustfmt doesn't really support formatting macros that use repetition. I'm wondering if it's possible to leverage MacroArgKind and return None before we even call replace_names.

I have seen it. I just add minimal thing that repair case in issue.

rscprof avatar Jan 17 '24 19:01 rscprof