rustc-perf icon indicating copy to clipboard operation
rustc-perf copied to clipboard

rust-timer bot re-executes command if the comment is edited

Open pietroalbini opened this issue 7 years ago • 5 comments

If you post a comment with a command and edit it, the command is executed two times. It would be best to check the action when the GitHub webhook is received.

pietroalbini avatar Aug 31 '18 22:08 pietroalbini

This is semi-intentional (and harmless), since it means you can reduce noise by editing a past comment.

Mark-Simulacrum avatar Aug 31 '18 22:08 Mark-Simulacrum

Oh, ok.

pietroalbini avatar Sep 01 '18 07:09 pietroalbini

AFAIK none of our other bots behave like this -- would it maybe make sense to make this bot consistent with bors and rustbot, and not react to edits?

This unexpected behavior just led to the bot spamming this a few times into my PR because I edited a comment: "This pull request is already queued and waiting for a try build to finish."

RalfJung avatar Nov 21 '25 09:11 RalfJung

We have added some new bot messages to make some situations explicit errors rather than silent failures. In light of that, I indeed think it makes sense to re-evaluate and disable reacting to edits.

Kobzol avatar Nov 21 '25 09:11 Kobzol

Hm, I'm pretty sure rustbot/triagebot does react to edits, it just diffs the parsed commands so it won't rerun unless you edit that particular command. But the bot here is simple enough that it's probably easier to just disable...

Mark-Simulacrum avatar Nov 22 '25 14:11 Mark-Simulacrum