rustc-perf icon indicating copy to clipboard operation
rustc-perf copied to clipboard

on status page timeline, beta benchmark record looks broken

Open klensy opened this issue 3 months ago • 5 comments

Weird values in columns, duration, sha, kind: Image

klensy avatar Sep 11 '25 10:09 klensy

Kind and duration looks reasonable, I'll check why the SHA is cut.

Kobzol avatar Sep 11 '25 10:09 Kobzol

It isn't cut, its wrong, it references to https://github.com/rust-lang/rust/commit/beta-2025-09-11

klensy avatar Sep 11 '25 10:09 klensy

Should reference to PR https://github.com/rust-lang/rust/pull/146350?

klensy avatar Sep 11 '25 10:09 klensy

Beta and stable releases have no associated PR, and the SHA link doesn't really make sense for them (I guess we could make it not be a link in that case).

Kobzol avatar Sep 11 '25 10:09 Kobzol

Ah, and the SHA is cut because we just cut the git commit SHAs.

Kobzol avatar Sep 11 '25 10:09 Kobzol