rustc-perf icon indicating copy to clipboard operation
rustc-perf copied to clipboard

use stable extract_if: since 1.87

Open klensy opened this issue 6 months ago • 3 comments

https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.extract_if

klensy avatar Jul 06 '25 20:07 klensy

Oh, sometimes toolchain is https://github.com/rust-lang/rustc-perf/blob/1dcd547738b64d84a2def859163ed8df14bcb01f/.github/workflows/ci.yml#L40

but in other cases it https://github.com/rust-lang/rustc-perf/blob/1dcd547738b64d84a2def859163ed8df14bcb01f/.github/workflows/ci.yml#L379

I can hold this pr until 1.85 -> 1.87 bump.

klensy avatar Jul 06 '25 20:07 klensy

Yeah, our MSRV is still 1.85.0. I think I'd like to hold off at least for one more stable release before we bump it.

Kobzol avatar Jul 06 '25 20:07 Kobzol

Hi, if you rebase this, I can approve & merge, as we have bumped MSRV in https://github.com/rust-lang/rustc-perf/pull/2273.

Kobzol avatar Oct 07 '25 20:10 Kobzol