rustc-perf icon indicating copy to clipboard operation
rustc-perf copied to clipboard

unable to select some comparison metrics: Failed to deserialize request

Open klensy opened this issue 3 years ago • 3 comments

Unable to select few comparison metrics, for example, context-switches with error:

Failed to deserialize request: Error("unknown variant `context-switches`, expected one of `instructions:u`, `cycles:u`, `faults`, `max-rss`, `task-clock`, `wall-time`, `cpu-clock`", line: 1, column: 126)
  • Open some compare link, for example https://perf.rust-lang.org/compare.html?start=f80e454450c891c075617d23532c6eb317f4471d&end=6ac8adad1f7d733b5b97d1df4e7f96e73a46db42&stat=instructions:u
  • Click Do another comparison and select other comparison metric, context-switches, for example.
  • Click submit, error will appear, but expected instead to show page with that metric.

This worked recently, so broken in last few commits, i guess.

klensy avatar May 25 '22 11:05 klensy

maybe #1322 ?

klensy avatar May 25 '22 11:05 klensy

Yeah this was most probably caused by my PR, I haven't seen this metric before. I'll fix it today.

Kobzol avatar May 25 '22 11:05 Kobzol

Not only this one, some others too, so, please check other ones.

klensy avatar May 25 '22 11:05 klensy

Closing for now, let me know if there are any other metrics missing.

Kobzol avatar Jun 04 '23 07:06 Kobzol