rustc-perf icon indicating copy to clipboard operation
rustc-perf copied to clipboard

If bootstrap timing partially or completely missing, indication on compare page is easy to miss

Open klensy opened this issue 3 years ago • 3 comments

See the links on https://github.com/rust-lang/rust/issues/96188

klensy avatar Apr 19 '22 01:04 klensy

The compare page shows that when a benchmark stops building: e.g. in this case the summary bot mentioned the rustc benchmark stopped building and it's showing that at the top of the compare page for that run.

In the other cases, if a given run doesn't itself break a benchmark, then they are listed in the status page.

Maybe we should automatically open rust-lang/rust issues when that happens, much like toolstate status changes.

lqd avatar Apr 19 '22 10:04 lqd

So I guess the issue here is not that the there's no indication (there is - see below), but that the indication isn't very clear.

image

rylev avatar Apr 25 '22 07:04 rylev

No, about empty bootstrap timings table: for first link https://perf.rust-lang.org/compare.html?start=8305398d7ae6128811ec2b3223939bcd067530c2&end=311e2683e1bad87715b1558f7900e294d24ce491

chrome_2022-04-25_10-52-07

Or partially empty one for second one (missing second column), without clear indication, that something wrong happened in data.

But that newly broken not too good too.

klensy avatar Apr 25 '22 07:04 klensy

image This is how it currently looks like. I think that it's much clearer that there is a problem with bootstrap now. @klensy if you agree, feel free to close this issue.

Kobzol avatar Jul 01 '23 19:07 Kobzol

Ok.

klensy avatar Jul 01 '23 19:07 klensy