rustc-dev-guide icon indicating copy to clipboard operation
rustc-dev-guide copied to clipboard

Bug: Book build fails on Windows

Open QingyaoLin opened this issue 11 months ago • 4 comments

When I cloned the project, I tried running mdbook build --open and it show:

> gh repo clone rust-lang/rustc-dev-guide
...
> cd rustc-dev-guide
> mdbook build --open
2025-01-10 23:07:31 [INFO] (mdbook::book): Book building has started
2025-01-10 23:07:32 [INFO] (mdbook::book): Running the html backend
2025-01-10 23:07:34 [INFO] (mdbook::book): Running the linkcheck backend
2025-01-10 23:07:34 [INFO] (mdbook::renderer): Invoking the "linkcheck" renderer
2025-01-10 23:07:34 [ERROR] (mdbook::utils): Error: Rendering failed
2025-01-10 23:07:34 [ERROR] (mdbook::utils):    Caused By: Unable to start the backend
2025-01-10 23:07:34 [ERROR] (mdbook::utils):    Caused By: %1 Not a valid Win32 application. (os error 193)

Book build failure!

QingyaoLin avatar Jan 10 '25 15:01 QingyaoLin

Have you installed all the add-ons (check here what's needed)? If so, I guess this line causes the issue (we use a shell script):

https://github.com/rust-lang/rustc-dev-guide/blob/aca4d07e0800aeebf6f74c59867d0f0de7ce486f/book.toml#L29

If you want a copy, you can get it on the web (visit https://rustc-dev-guide.rust-lang.org/ and click the printer mark on top).

Also note that this repo is for developing rustc-dev-guide and it mainly happens on Unix-like OSes. I'm happy to see a PR to work well on Windows, though!

JohnTitor avatar Jan 11 '25 05:01 JohnTitor

Have you installed all the add-ons (check here what's needed)?

I have installed all the add-ons.

Also note that this repo is for developing rustc-dev-guide and it mainly happens on Unix-like OSes.

This is kind of bad. When people who don't have a Unix-like system want to contribute, they won't be able to see the actual build results.

As I said in QingyaoLin:update-rustc-dev-guide-book, I don't know what happened in the middle and why the link was not detected as invalid.

QingyaoLin avatar Jan 11 '25 07:01 QingyaoLin

Well, I haven't said that we don't welcome contributors outside of Unix 😓 Feel free to send a patch to fix that issue :)

JohnTitor avatar Jan 11 '25 07:01 JohnTitor

I am not familiar with github CI and need other contributors to try to solve this problem. I will try my best to solve it.

QingyaoLin avatar Jan 11 '25 07:01 QingyaoLin