rust-lang
Elaborate on dataflow outputs for region constraints
I see Zed snuck in some Markdown normalisation too while it was at it. Sorry about that, let me know if that's inexcusable and I will revert those changes.
I will revert those changes
Please do yes, if it's not too hard. It will make review easier.
I'll take a closer look when I have more time, but I noted a couple of things:
- "With
-Z dump-mir-graphviz=yes, you will also get Graphviz files for the outlives constraints" is that the case? Did you maybe mean-Zdump-mir=nll? - I don't think these visualizations are from MIR dataflow, so the new paragraph may need to be moved to somewhere more related to borrowck
Please do yes, if it's not too hard. It will make review easier.
Done!
"With
-Z dump-mir-graphviz=yes, you will also get Graphviz files for the outlives constraints" is that the case? Did you maybe mean-Zdump-mir=nll?
Huh! Apparently, -Z dump-mir=fn is enough to get those. I assumed it wouldn't drop graphviz files without the Graphviz option, but apparently it does! dump-mir=nll also works and now I'm worried it will dump different graphs.
I don't think these visualizations are from MIR dataflow, so the new paragraph may need to be moved to somewhere more related to borrowck
That's probably true; this should be in the borrowck chapter, maybe? Do you have a suggestion off the top of your head or should I go digging?
Not from the top of my head but I will look for one -- but yeah I agree this should be in the borrowck chapter most likely.