rust-lang
Fix item-info color
Part of #98341 (the final fix is #93896).
Since the links are already underlined, no need to change their color too. Instead it now uses the text color directly.
Here are some screenshots of the result:
Online demo available here.
cc @jplatte @jsha r? @notriddle
:pushpin: Commit 262a48d86c22e36d76892c5a4dce53f8ca00cc73 has been approved by notriddle
It is now in the queue for this repository.
@bors r-
This is the wrong solution for https://github.com/rust-lang/rust/issues/98341. The link color means something: you can click here. We should avoid creating exceptions if at all possible. The background for item-infos does not mean anything special. We can choose it to be whatever we want.
The problem here is that the link color in dark theme is chosen to contrast against the dark background, so it's light. But the background for the item-info is also light - too light, in fact. See https://github.com/rust-lang/rust/pull/93896. In that PR we never landed on the exact color, but that's the direction I think we should go. The text in the item info should be the same color as the body text, and the background should be just different enough from the body background to highlight it, without making it too bright.
I completely forgot about it and I also prefer your approach. Closing this one then!
@jsha I just realized that this fix is still valid, even though incomplete. It makes the <a> elements' color inherit their parent one. The one you set in https://github.com/rust-lang/rust/pull/93896. I'm reopening this PR and removing the "fixes" part in the first comment as it is incomplete but still an improvement and will be needed for your PR as well.
It makes the elements' color inherit their parent one.
That's usually not what we want. For instance: a paragraph of text might have color: black. If there's a link in that paragraph we want it to have a distinct color, not black. So it shouldn't inherit it's parent's color.
Ok. I'll wait for your PR to be done and then I'll update the links' color for item info elements.
Blocked on https://github.com/rust-lang/rust/pull/93896 for the time being.
:umbrella: The latest upstream changes (presumably #100048) made this pull request unmergeable. Please resolve the merge conflicts.
Hello @GuillaumeGomez! There's a merge conflict for this PR, has there been any updates? :)
