rust icon indicating copy to clipboard operation
rust copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

Remove EntryKind from metadata.

Open cjgillot opened this issue 2 years ago • 38 comments

This PR continues the refactor of metadata emission to be more systematic, iterating on definitions and filtering based on each definition's DefKind. This allows to remove the large EntryKind enum, replaced by linear tables in metadata.

cjgillot avatar Jul 05 '22 20:07 cjgillot

@bors try @rust-timer queue

cjgillot avatar Jul 05 '22 20:07 cjgillot

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

rust-timer avatar Jul 05 '22 20:07 rust-timer

:hourglass: Trying commit aa7c0b72385fda97913f98749ecba4d05b3e6465 with merge a4011cb6eef91e3830bdf2f739c3b5140ce6720a...

bors avatar Jul 05 '22 20:07 bors

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-log-analyzer avatar Jul 05 '22 20:07 rust-log-analyzer

:broken_heart: Test failed - checks-actions

bors avatar Jul 05 '22 20:07 bors

@bors try @rust-timer queue

cjgillot avatar Jul 05 '22 20:07 cjgillot

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

rust-timer avatar Jul 05 '22 20:07 rust-timer

:hourglass: Trying commit aa7c0b72385fda97913f98749ecba4d05b3e6465 with merge d39a35a69b824686f9f79ec1e99fa347a28d685f...

bors avatar Jul 05 '22 20:07 bors

:sunny: Try build successful - checks-actions Build commit: d39a35a69b824686f9f79ec1e99fa347a28d685f (d39a35a69b824686f9f79ec1e99fa347a28d685f)

bors avatar Jul 05 '22 22:07 bors

Queued d39a35a69b824686f9f79ec1e99fa347a28d685f with parent 41ad4d9b2dbb895666337d162eda52619a6056db, future comparison URL.

rust-timer avatar Jul 05 '22 22:07 rust-timer

Finished benchmarking commit (d39a35a69b824686f9f79ec1e99fa347a28d685f): comparison url.

Instruction count

  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: mixed results
mean[^1] max count[^2]
Regressions 😿
(primary)		 0.6% 2.6% 55
Regressions 😿
(secondary)		 2.0% 8.4% 38
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -1.3% -2.2% 9
All 😿🎉 (primary) 0.6% 2.6% 55

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
mean[^1] max count[^2]
Regressions 😿
(primary)		 2.3% 4.9% 85
Regressions 😿
(secondary)		 4.4% 8.1% 84
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.6% -3.2% 12
All 😿🎉 (primary) 2.3% 4.9% 85

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: mixed results
mean[^1] max count[^2]
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 3.0% 5.8% 16
Improvements 🎉
(primary)		 -3.4% -3.4% 1
Improvements 🎉
(secondary)		 -3.9% -6.1% 10
All 😿🎉 (primary) -3.4% -3.4% 1

[^1]: the arithmetic mean of the percent change [^2]: number of relevant changes

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never @rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

rust-timer avatar Jul 06 '22 03:07 rust-timer

@bors try @rust-timer queue

cjgillot avatar Jul 06 '22 09:07 cjgillot

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

rust-timer avatar Jul 06 '22 09:07 rust-timer

:hourglass: Trying commit adb0576b6c900e8dc7f2272bc0ff50afdde590b9 with merge 46ef832c457b61f5d20f548ba382df88edb88f58...

bors avatar Jul 06 '22 09:07 bors

Last perf run suggests that both the crate metadata and the dep graph got bigger.

bjorn3 avatar Jul 06 '22 10:07 bjorn3

:sunny: Try build successful - checks-actions Build commit: 46ef832c457b61f5d20f548ba382df88edb88f58 (46ef832c457b61f5d20f548ba382df88edb88f58)

bors avatar Jul 06 '22 11:07 bors

Queued 46ef832c457b61f5d20f548ba382df88edb88f58 with parent 5b8cf49c51833ee5d27ae2e8e179337dbb9f14d7, future comparison URL.

rust-timer avatar Jul 06 '22 11:07 rust-timer

Finished benchmarking commit (46ef832c457b61f5d20f548ba382df88edb88f58): comparison url.

Instruction count

  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
mean[^1] max count[^2]
Regressions 😿
(primary)		 0.5% 0.7% 11
Regressions 😿
(secondary)		 0.7% 0.9% 6
Improvements 🎉
(primary)		 -0.5% -0.5% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 0.5% 0.7% 12

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
mean[^1] max count[^2]
Regressions 😿
(primary)		 2.5% 4.6% 101
Regressions 😿
(secondary)		 4.9% 11.1% 87
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.3% -2.5% 4
All 😿🎉 (primary) 2.5% 4.6% 101

Cycles

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 😿 relevant regressions found
mean[^1] max count[^2]
Regressions 😿
(primary)		 2.8% 2.8% 1
Regressions 😿
(secondary)		 3.2% 3.4% 3
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 2.8% 2.8% 1

[^1]: the arithmetic mean of the percent change [^2]: number of relevant changes

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never @rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

rust-timer avatar Jul 06 '22 12:07 rust-timer

@bors try @rust-timer queue

cjgillot avatar Aug 03 '22 18:08 cjgillot

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

rust-timer avatar Aug 03 '22 18:08 rust-timer

:hourglass: Trying commit 4024ef63ecb392eacfae4155b9ca8c615b240ed5 with merge 6f0cd9989c1f418c306743e2428e2d3b3782e048...

bors avatar Aug 03 '22 18:08 bors

:sunny: Try build successful - checks-actions Build commit: 6f0cd9989c1f418c306743e2428e2d3b3782e048 (6f0cd9989c1f418c306743e2428e2d3b3782e048)

bors avatar Aug 03 '22 19:08 bors

Queued 6f0cd9989c1f418c306743e2428e2d3b3782e048 with parent 04f72f95384d97f4c4e7a59e60cb85ec581ebe06, future comparison URL.

rust-timer avatar Aug 03 '22 19:08 rust-timer

Finished benchmarking commit (6f0cd9989c1f418c306743e2428e2d3b3782e048): comparison url.

Instruction count

  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: mixed results
mean[^1] max count[^2]
Regressions 😿
(primary)		 0.6% 0.8% 13
Regressions 😿
(secondary)		 0.7% 1.2% 10
Improvements 🎉
(primary)		 -0.3% -0.4% 2
Improvements 🎉
(secondary)		 -1.5% -1.5% 2
All 😿🎉 (primary) 0.5% 0.8% 15

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: mixed results
mean[^1] max count[^2]
Regressions 😿
(primary)		 2.4% 6.1% 13
Regressions 😿
(secondary)		 3.1% 4.7% 60
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -3.2% -5.2% 7
All 😿🎉 (primary) 2.4% 6.1% 13

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean[^1] max count[^2]
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 3.4% 4.2% 4
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -3.4% -3.4% 1
All 😿🎉 (primary) N/A N/A 0

[^1]: the arithmetic mean of the percent change [^2]: number of relevant changes

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never @rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

rust-timer avatar Aug 04 '22 00:08 rust-timer

@bors try @rust-timer queue

cjgillot avatar Aug 04 '22 20:08 cjgillot

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

rust-timer avatar Aug 04 '22 20:08 rust-timer

:hourglass: Trying commit 9e8640812dc10aefb3ab9ceb7b936cd21169daa9 with merge 20d9bc42398864025dabe7aa41ae18289ed55ba0...

bors avatar Aug 04 '22 20:08 bors

:sunny: Try build successful - checks-actions Build commit: 20d9bc42398864025dabe7aa41ae18289ed55ba0 (20d9bc42398864025dabe7aa41ae18289ed55ba0)

bors avatar Aug 04 '22 22:08 bors

Queued 20d9bc42398864025dabe7aa41ae18289ed55ba0 with parent 3830ecaa8db798d2727cbdfa4ddf314ff938f268, future comparison URL.

rust-timer avatar Aug 04 '22 22:08 rust-timer

Finished benchmarking commit (20d9bc42398864025dabe7aa41ae18289ed55ba0): comparison url.

Instruction count

  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: mixed results
mean[^1] max count[^2]
Regressions 😿
(primary)		 0.5% 0.7% 17
Regressions 😿
(secondary)		 0.5% 1.0% 24
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -1.5% -1.5% 2
All 😿🎉 (primary) 0.5% 0.7% 17

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: mixed results
mean[^1] max count[^2]
Regressions 😿
(primary)		 1.9% 3.5% 38
Regressions 😿
(secondary)		 3.5% 7.5% 71
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.6% -4.7% 8
All 😿🎉 (primary) 1.9% 3.5% 38

Cycles

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 😿 relevant regressions found
mean[^1] max count[^2]
Regressions 😿
(primary)		 2.1% 2.1% 1
Regressions 😿
(secondary)		 3.3% 3.4% 2
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 2.1% 2.1% 1

[^1]: the arithmetic mean of the percent change [^2]: number of relevant changes

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never @rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

rust-timer avatar Aug 04 '22 23:08 rust-timer

@bors try @rust-timer queue

cjgillot avatar Aug 05 '22 18:08 cjgillot

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

rust-timer avatar Aug 05 '22 18:08 rust-timer

:hourglass: Trying commit f9aab23ec41f22e79b689226dcfc1d91279f3eee with merge 00534588a46c414546272b809ce2b9fbb60be9a0...

bors avatar Aug 05 '22 18:08 bors

:sunny: Try build successful - checks-actions Build commit: 00534588a46c414546272b809ce2b9fbb60be9a0 (00534588a46c414546272b809ce2b9fbb60be9a0)

bors avatar Aug 05 '22 19:08 bors

Queued 00534588a46c414546272b809ce2b9fbb60be9a0 with parent d77da9da84fc89908ad01578c33c2dca8f597ffe, future comparison URL.

rust-timer avatar Aug 05 '22 19:08 rust-timer

Finished benchmarking commit (00534588a46c414546272b809ce2b9fbb60be9a0): comparison url.

Instruction count

  • Primary benchmarks: mixed results
  • Secondary benchmarks: mixed results
mean[^1] max count[^2]
Regressions 😿
(primary)		 0.3% 0.6% 9
Regressions 😿
(secondary)		 0.7% 1.2% 21
Improvements 🎉
(primary)		 -0.5% -0.8% 4
Improvements 🎉
(secondary)		 -1.1% -1.5% 3
All 😿🎉 (primary) 0.1% -0.8% 13

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
mean[^1] max count[^2]
Regressions 😿
(primary)		 2.0% 3.5% 41
Regressions 😿
(secondary)		 3.7% 7.7% 82
Improvements 🎉
(primary)		 -2.2% -2.2% 1
Improvements 🎉
(secondary)		 -2.5% -3.5% 2
All 😿🎉 (primary) 1.9% 3.5% 42

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean[^1] max count[^2]
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 4.2% 5.9% 2
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -3.0% -3.0% 1
All 😿🎉 (primary) N/A N/A 0

[^1]: the arithmetic mean of the percent change [^2]: number of relevant changes

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never @rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

rust-timer avatar Aug 05 '22 20:08 rust-timer

r? compiler

cjgillot avatar Aug 06 '22 07:08 cjgillot

The max-rss hit looks noticeable, is that expected ?

lqd avatar Aug 06 '22 08:08 lqd