rust icon indicating copy to clipboard operation
rust copied to clipboard

`x build src/tools/miri` doesn't install miri as part of the built toolchain

Open Kixiron opened this issue 3 years ago • 5 comments
trafficstars

Running x build src/tools/miri doesn't include miri as part of the built rust toolchain, meaning that cargo +custom-toolchain miri doesn't work

cc @jyn514

Kixiron avatar Jun 05 '22 15:06 Kixiron

@rustbot label +A-rustbuild

Kixiron avatar Jun 05 '22 15:06 Kixiron

It seems like the same thing happens to rustfmt: x b rustfmt doesn't include rustfmt as part of the built rust toolchain, meaning that rustfmt +custom-toolchain doesn't work.

WaffleLapkin avatar Jun 30 '22 13:06 WaffleLapkin

The same thing applies to cargo and clippy.

daxpedda avatar Jul 23 '22 12:07 daxpedda

We need to call add_to_sysroot in all of these steps. I think that currently adds all libraries as well which isn't correct - someone should look into how this is done for rustdoc and do the same for the other tools. Take a look around src/bootstrap/compile.rs.

I agree it's a bug that we don't copy these today.

jyn514 avatar Jul 23 '22 12:07 jyn514

@rustbot claim

WaffleLapkin avatar Sep 18 '22 18:09 WaffleLapkin

this seems related to #81431

Emilgardis avatar Oct 02 '22 21:10 Emilgardis

@rustbot claim

onur-ozkan avatar Apr 11 '23 22:04 onur-ozkan