rust icon indicating copy to clipboard operation
rust copied to clipboard

Implement blessing for tidy alphabetical check

Open WaffleLapkin opened this issue 2 weeks ago • 11 comments

r? @jdonszelmann

WaffleLapkin avatar Dec 01 '25 17:12 WaffleLapkin

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged. Otherwise, you can ignore this comment.

rustbot avatar Dec 01 '25 17:12 rustbot

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot avatar Dec 02 '25 10:12 rustbot

@bors r+ rollup

jdonszelmann avatar Dec 03 '25 14:12 jdonszelmann

:pushpin: Commit 8b6431d27f255ccdbc1e79c3af3f5c80c487df6e has been approved by jdonszelmann

It is now in the queue for this repository.

bors avatar Dec 03 '25 14:12 bors

Failed in rollup: https://github.com/rust-lang/rust/pull/149603#issuecomment-3610150255

@bors r-

Zalathar avatar Dec 04 '25 05:12 Zalathar

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot avatar Dec 07 '25 12:12 rustbot

@bors try jobs=aarch64-msvc-1

WaffleLapkin avatar Dec 07 '25 13:12 WaffleLapkin

:hourglass: Trying commit 3bbd6ea19a57edcd45ad1558754c1b59aabd836e with merge 78a436972e828092154dac042faaab2b30bf2327…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/20004634863

rust-bors[bot] avatar Dec 07 '25 13:12 rust-bors[bot]

:sunny: Try build successful (CI) Build commit: 78a436972e828092154dac042faaab2b30bf2327 (78a436972e828092154dac042faaab2b30bf2327, parent: 1c5a0cfc13559b863b47b64b51429360fe55ef73)

rust-bors[bot] avatar Dec 07 '25 15:12 rust-bors[bot]

@bors r=jdonszelmann

WaffleLapkin avatar Dec 07 '25 15:12 WaffleLapkin

:pushpin: Commit 3bbd6ea19a57edcd45ad1558754c1b59aabd836e has been approved by jdonszelmann

It is now in the queue for this repository.

bors avatar Dec 07 '25 15:12 bors

:hourglass: Testing commit 3bbd6ea19a57edcd45ad1558754c1b59aabd836e with merge ba2142a19c1acabe770433418fa395b8a0ef47a4...

bors avatar Dec 07 '25 20:12 bors

:sunny: Test successful - checks-actions Approved by: jdonszelmann Pushing ba2142a19c1acabe770433418fa395b8a0ef47a4 to main...

bors avatar Dec 07 '25 23:12 bors

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing fa1f706fbd0fd1c02763ecb28915bf23c860cb32 (parent) -> ba2142a19c1acabe770433418fa395b8a0ef47a4 (this PR)

Test differences

Show 5 test diffs

Stage 0

  • alphabetical::tests::bless_funny_numbers: [missing] -> pass (J0)
  • alphabetical::tests::bless_multiline: [missing] -> pass (J0)
  • alphabetical::tests::bless_smoke: [missing] -> pass (J0)
  • alphabetical::tests::multiline: [missing] -> pass (J0)

Additionally, 1 doctest diff were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ba2142a19c1acabe770433418fa395b8a0ef47a4 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 7065.9s -> 10665.6s (+50.9%)
  2. i686-gnu-1: 7058.4s -> 8374.6s (+18.6%)
  3. x86_64-rust-for-linux: 2540.5s -> 3004.1s (+18.2%)
  4. dist-aarch64-apple: 7552.3s -> 6324.6s (-16.3%)
  5. pr-check-1: 1689.0s -> 1942.8s (+15.0%)
  6. test-various: 6042.8s -> 6926.3s (+14.6%)
  7. x86_64-gnu-llvm-21-1: 3173.2s -> 3597.7s (+13.4%)
  8. x86_64-mingw-1: 9664.9s -> 10793.5s (+11.7%)
  9. pr-check-2: 2290.2s -> 2551.9s (+11.4%)
  10. x86_64-gnu-llvm-20: 2424.5s -> 2696.3s (+11.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance that executed the job, system noise, invalidated caches, etc. The table above is provided mostly for t-infra members, for simpler debugging of potential CI slow-downs.

github-actions[bot] avatar Dec 07 '25 23:12 github-actions[bot]

Finished benchmarking commit (ba2142a19c1acabe770433418fa395b8a0ef47a4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 7.6%, secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
7.6% [7.6%, 7.6%] 1
Regressions ❌
(secondary)
2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 7.6% [7.6%, 7.6%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.293s -> 470.113s (0.39%) Artifact size: 389.00 MiB -> 388.98 MiB (-0.00%)

rust-timer avatar Dec 08 '25 00:12 rust-timer