Stabilize `debug_closure_helpers`

[coolreader18]

Resolves rust-lang/rust#117729. The tracking issue still needs an FCP, but I'm hoping that creating a stabilization PR will prompt one.

r? libs-api

[bors]

:umbrella: The latest upstream changes (presumably #146636) made this pull request unmergeable. Please resolve the merge conflicts.

[coolreader18]

Once the FCP is complete, I think it might make sense to merge #145915 first and then merge this on top of that.

[jmillikin]

The stabilization PR for fmt::from_fn has merged, so this one is now ready to rebase.

gentle ping @the8472 for review

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[bors]

:umbrella: The latest upstream changes (presumably #148544) made this pull request unmergeable. Please resolve the merge conflicts.

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[WARNING] `tests/rustdoc-gui/search-result-display.goml` line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

======== tests/rustdoc-gui/source-code-wrapping.goml ========

[ERROR] `tests/rustdoc-gui/source-code-wrapping.goml` line 30: Error: Navigating frame was detached: for command `go-to: "file://" + |DOC_PATH| + "/test_docs/trait_bounds/index.html"`
`tests/rustdoc-gui/source-code-wrapping.goml` source-code-wrapping output:
Protocol error: Connection closed. Most likely the page has been closed.
stack: Error: Protocol error: Connection closed. Most likely the page has been closed.
    at assert (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/puppeteer-core/lib/cjs/puppeteer/util/assert.js:18:15)
    at CdpPage.close (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/Page.js:814:36)
    at async runAllCommands (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/browser-ui-test/src/index.js:433:13)
    at async innerRunTestCode (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/browser-ui-test/src/index.js:696:21)
    at async innerRunTests (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/browser-ui-test/src/index.js:633:17)
    at async runTests (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/browser-ui-test/src/index.js:824:27)


======== tests/rustdoc-gui/source-code-wrapping.goml ========

[ERROR] `tests/rustdoc-gui/source-code-wrapping.goml` line 30: Error: Navigating frame was detached: for command `go-to: "file://" + |DOC_PATH| + "/test_docs/trait_bounds/index.html"`
`tests/rustdoc-gui/source-code-wrapping.goml` source-code-wrapping output:
Protocol error: Connection closed. Most likely the page has been closed.
stack: Error: Protocol error: Connection closed. Most likely the page has been closed.
    at assert (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/puppeteer-core/lib/cjs/puppeteer/util/assert.js:18:15)
    at CdpPage.close (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/Page.js:814:36)
    at async runAllCommands (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/browser-ui-test/src/index.js:433:13)
    at async innerRunTestCode (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/browser-ui-test/src/index.js:696:21)
    at async innerRunTests (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/browser-ui-test/src/index.js:633:17)
    at async runTests (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/browser-ui-test/src/index.js:824:27)



<= doc-ui tests done: 142 succeeded, 1 failed, 0 filtered out

[jmillikin]

@bors retry

[bors]

@jmillikin: :key: Insufficient privileges: not in try users

[jmillikin]

@the8472 gentle ping?

[jmillikin]

r? libs-api

[bors]

:umbrella: The latest upstream changes (presumably #149704) made this pull request unmergeable. Please resolve the merge conflicts.

[tgross35]

r? tgross35

Fyi you can r? libs rather than libs-api for stabilization PRs, libs does more reviews. libs-api just needs to do the FCP.

The diff here LGTM, but I'd just like to make sure we have room to improve on what Hanna mentioned.

[tgross35]

Also this needs a rebase, of course

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[bors]

:umbrella: The latest upstream changes (presumably #149941) made this pull request unmergeable. Please resolve the merge conflicts.

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.