rust icon indicating copy to clipboard operation
rust copied to clipboard

tests: Do not run afoul of asm.validity.non-exhaustive in input-stats

Open workingjubilee opened this issue 7 months ago • 3 comments

This addresses one of the three test failures in https://github.com/rust-lang/rust/issues/142280

I was motivated to cover it myself because technically this is also compile-time UB if we compile a program that has asm! with x86-64-specific instructions on another platform. That'll only mean something if this is ever switched to build-pass, or if checking emits object code, but conveniently "nop" is valid assembly on all platforms anyone has implemented Rust codegen for. Even the weird ones LLVM doesn't support, like PA-RISC or Common Intermediate Language.

...except GPUs. Not sure about those.

r? @nnethercote

workingjubilee avatar Jun 10 '25 07:06 workingjubilee

nnethercote is not on the review rotation at the moment. They may take a while to respond.

rustbot avatar Jun 10 '25 07:06 rustbot

@bors r+ rollup

nnethercote avatar Jun 10 '25 07:06 nnethercote

:pushpin: Commit 3a5187aa3b9a15caf3ceeff1299dd88f6d959442 has been approved by nnethercote

It is now in the queue for this repository.

bors avatar Jun 10 '25 07:06 bors

@bors r-

something's up.

workingjubilee avatar Jun 11 '25 04:06 workingjubilee

Changes to the size of AST and/or HIR nodes.

cc @nnethercote

rustbot avatar Jun 11 '25 04:06 rustbot

...I don't understand why the test didn't fail in PR CI when I pushed it the first time?

workingjubilee avatar Jun 11 '25 04:06 workingjubilee

:umbrella: The latest upstream changes (presumably #142442) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Jun 13 '25 15:06 bors

:umbrella: The latest upstream changes (presumably #142962) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Jun 24 '25 19:06 bors

@bors r=nnethercote

workingjubilee avatar Jun 25 '25 20:06 workingjubilee

:pushpin: Commit 233882128bda3d1912d339afeca985637f94485c has been approved by nnethercote

It is now in the queue for this repository.

bors avatar Jun 25 '25 20:06 bors