rust icon indicating copy to clipboard operation
rust copied to clipboard

Add central execution context to bootstrap

Open Shourya742 opened this issue 7 months ago • 14 comments

This PR continues the effort toward command centralization as outlined in https://github.com/rust-lang/rust/issues/126819. It introduces a centralized execution context through which all commands will be executed. Previously, centralization was limited to build methods; this PR extends it to the config module and updates the remaining methods accordingly.

Best reviewed commit by commit.

r? @Kobzol

Shourya742 avatar Jun 02 '25 13:06 Shourya742

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR changes how GCC is built. Consider updating src/bootstrap/download-ci-gcc-stamp.

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

rustbot avatar Jun 02 '25 13:06 rustbot

Btw you probably know this, but looking for usages of as_command_mut is a good source of figuring out what other old-school command invocations we'd ideally like to remove.

Kobzol avatar Jun 02 '25 13:06 Kobzol

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling build_helper v0.1.0 (/checkout/src/build_helper)
    Finished `dev` profile [unoptimized] target(s) in 17.85s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:31
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 2/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 3/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 4/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 5/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
The command has failed after 5 attempts.
  local time: Tue Jun  3 17:40:43 UTC 2025
  network time: Tue, 03 Jun 2025 17:40:43 GMT

rust-log-analyzer avatar Jun 03 '25 17:06 rust-log-analyzer

The job mingw-check-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling termcolor v1.4.1
    Finished `dev` profile [unoptimized] target(s) in 26.72s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:37
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 2/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 3/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 4/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 5/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
The command has failed after 5 attempts.
  local time: Tue Jun  3 17:49:51 UTC 2025
  network time: Tue, 03 Jun 2025 17:49:51 GMT

rust-log-analyzer avatar Jun 03 '25 17:06 rust-log-analyzer

The job mingw-check-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.

thread 'main' panicked at src/bootstrap/src/core/metadata.rs:92:39:
serde_json::from_str(&metadata_output) failed with EOF while parsing a value at line 1 column 0
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Panic was initiated from src/bootstrap/src/core/metadata.rs:92:39
Build completed unsuccessfully in 0:00:37
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 2/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.

thread 'main' panicked at src/bootstrap/src/core/metadata.rs:92:39:
serde_json::from_str(&metadata_output) failed with EOF while parsing a value at line 1 column 0
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Panic was initiated from src/bootstrap/src/core/metadata.rs:92:39
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 3/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.

thread 'main' panicked at src/bootstrap/src/core/metadata.rs:92:39:
serde_json::from_str(&metadata_output) failed with EOF while parsing a value at line 1 column 0
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Panic was initiated from src/bootstrap/src/core/metadata.rs:92:39
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 4/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.

thread 'main' panicked at src/bootstrap/src/core/metadata.rs:92:39:
serde_json::from_str(&metadata_output) failed with EOF while parsing a value at line 1 column 0
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Panic was initiated from src/bootstrap/src/core/metadata.rs:92:39
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 5/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.

thread 'main' panicked at src/bootstrap/src/core/metadata.rs:92:39:
serde_json::from_str(&metadata_output) failed with EOF while parsing a value at line 1 column 0
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Panic was initiated from src/bootstrap/src/core/metadata.rs:92:39
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
The command has failed after 5 attempts.

rust-log-analyzer avatar Jun 03 '25 18:06 rust-log-analyzer

The job mingw-check-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling termcolor v1.4.1
    Finished `dev` profile [unoptimized] target(s) in 26.13s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:37
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 2/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 3/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 4/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 5/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
The command has failed after 5 attempts.
  local time: Tue Jun  3 19:01:36 UTC 2025
  network time: Tue, 03 Jun 2025 19:01:36 GMT

rust-log-analyzer avatar Jun 03 '25 19:06 rust-log-analyzer

The job mingw-check-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling termcolor v1.4.1
    Finished `dev` profile [unoptimized] target(s) in 26.37s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:37
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 2/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 3/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 4/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 5/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
The command has failed after 5 attempts.
  local time: Wed Jun  4 04:32:11 UTC 2025
  network time: Wed, 04 Jun 2025 04:32:11 GMT

rust-log-analyzer avatar Jun 04 '25 04:06 rust-log-analyzer

The job mingw-check-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling home v0.5.9
    Finished `dev` profile [unoptimized] target(s) in 26.22s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
running: RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) (created at src/bootstrap/src/core/metadata.rs:80:25, executed at src/bootstrap/src/core/metadata.rs:91:50)


Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) did not execute successfully.
It was not possible to execute the command: Os { code: 2, kind: NotFound, message: "No such file or directory" }

Build completed unsuccessfully in 0:00:37
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 2/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
running: RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) (created at src/bootstrap/src/core/metadata.rs:80:25, executed at src/bootstrap/src/core/metadata.rs:91:50)


Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) did not execute successfully.
It was not possible to execute the command: Os { code: 2, kind: NotFound, message: "No such file or directory" }

Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 3/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
running: RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) (created at src/bootstrap/src/core/metadata.rs:80:25, executed at src/bootstrap/src/core/metadata.rs:91:50)


Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) did not execute successfully.
It was not possible to execute the command: Os { code: 2, kind: NotFound, message: "No such file or directory" }

Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 4/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
running: RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) (created at src/bootstrap/src/core/metadata.rs:80:25, executed at src/bootstrap/src/core/metadata.rs:91:50)


Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) did not execute successfully.
It was not possible to execute the command: Os { code: 2, kind: NotFound, message: "No such file or directory" }

Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 5/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
running: RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) (created at src/bootstrap/src/core/metadata.rs:80:25, executed at src/bootstrap/src/core/metadata.rs:91:50)


Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) did not execute successfully.
It was not possible to execute the command: Os { code: 2, kind: NotFound, message: "No such file or directory" }

Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
The command has failed after 5 attempts.
  local time: Wed Jun  4 04:59:01 UTC 2025

rust-log-analyzer avatar Jun 04 '25 05:06 rust-log-analyzer

The job mingw-check-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling home v0.5.9
    Finished `dev` profile [unoptimized] target(s) in 25.88s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:37
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 2/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 3/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 4/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 5/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
The command has failed after 5 attempts.
  local time: Wed Jun  4 06:11:33 UTC 2025
  network time: Wed, 04 Jun 2025 06:11:34 GMT

rust-log-analyzer avatar Jun 04 '25 06:06 rust-log-analyzer

The job mingw-check-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling termcolor v1.4.1
    Finished `dev` profile [unoptimized] target(s) in 26.13s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:37
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 2/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 3/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 4/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
Command failed. Attempt 5/5:
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
Command RUSTC_BOOTSTRAP="1" "bin/cargo" "metadata" "--format-version" "1" "--no-deps" "--manifest-path" "/checkout/Cargo.toml" (failure_mode=Exit) has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:99: prepare] Error 1
The command has failed after 5 attempts.
  local time: Wed Jun  4 07:22:35 UTC 2025
  network time: Wed, 04 Jun 2025 07:22:35 GMT

rust-log-analyzer avatar Jun 04 '25 07:06 rust-log-analyzer

Looks like the command invocation from the error is swallowing errors. Not sure what/where fails.

Kobzol avatar Jun 04 '25 11:06 Kobzol

:umbrella: The latest upstream changes (presumably #142070) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Jun 05 '25 17:06 bors

Thank you! I agree, let's land like this and we can make further refactorings in follow-up PRs.

@bors r+

Kobzol avatar Jun 10 '25 05:06 Kobzol

:pushpin: Commit 51fbd145f95cb193bde3c675a9236e2777973d07 has been approved by Kobzol

It is now in the queue for this repository.

bors avatar Jun 10 '25 05:06 bors