rust icon indicating copy to clipboard operation
rust copied to clipboard

rustc_const_eval: Expose APIs for signalling foreign accesses to memory

Open nia-e opened this issue 7 months ago • 4 comments

This PR will allow Miri to internally update its state based on information about foreign accesses performed on its memory during FFI. Necessary as part of rust-lang/miri#4326 to make use of the extra information we gain; currently pending review of the design (see design document in the linked PR), so marked as draft for now.

r? @RalfJung

nia-e avatar May 22 '25 12:05 nia-e

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#16 3.185 Building wheels for collected packages: reuse
#16 3.186   Building wheel for reuse (pyproject.toml): started
#16 3.400   Building wheel for reuse (pyproject.toml): finished with status 'done'
#16 3.401   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132719 sha256=d2a2565e7037ad3883fb9337653f2e25bbb588534fbef3697286cbc26d1bf634
#16 3.401   Stored in directory: /tmp/pip-ephem-wheel-cache-kumck1xd/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#16 3.404 Successfully built reuse
#16 3.404 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#16 3.804 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#16 3.804 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#16 DONE 3.9s
---
987 |     pub fn prepare_for_native_call(
    |            ^^^^^^^^^^^^^^^^^^^^^^^
help: provide the argument
    |
474 |         this.prepare_for_native_call(exposed, /* bool */)
    |                                             ++++++++++++

For more information about this error, try `rustc --explain E0061`.
[RUSTC-TIMING] miri test:false 3.587
error: could not compile `miri` (lib) due to 1 previous error

rust-log-analyzer avatar May 22 '25 12:05 rust-log-analyzer

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

rustbot avatar May 31 '25 07:05 rustbot

@rustbot author

RalfJung avatar Jun 09 '25 18:06 RalfJung

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot avatar Jun 09 '25 18:06 rustbot

:umbrella: The latest upstream changes (presumably #143350) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Jul 03 '25 08:07 bors

After making get_alloc_raw public, this is unnecessary. Closing in favour of a smaller PR ^^

nia-e avatar Jul 08 '25 08:07 nia-e