rust icon indicating copy to clipboard operation
rust copied to clipboard

compiletest: Store test collection context/state in two structs

Open Zalathar opened this issue 1 year ago • 3 comments

This is another incremental cleanup that untangles some of the parameter passing during test collection, making it easier to see which pieces of context information are read-only, and making it easier to find where each field is used.

Zalathar avatar Oct 18 '24 05:10 Zalathar

r? @wesleywiser

rustbot has assigned @wesleywiser. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Oct 18 '24 05:10 rustbot

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot avatar Oct 18 '24 05:10 rustbot

r? jieyouxu

jieyouxu avatar Oct 18 '24 05:10 jieyouxu

@bors r+ rollup

jieyouxu avatar Oct 18 '24 08:10 jieyouxu

:pushpin: Commit cc5fd6af29a2c2a969ff02a2a8fff6a976c22c1d has been approved by jieyouxu

It is now in the queue for this repository.

bors avatar Oct 18 '24 08:10 bors

@bors r-

jieyouxu avatar Oct 18 '24 10:10 jieyouxu

@Zalathar let's stick with HashSet for the time being. This seems strange to be using a HashSet anyway, I would've expected some analysis based on a prefix tree perhaps

jieyouxu avatar Oct 18 '24 10:10 jieyouxu

BTreeSet change removed; back to the original HashSet.

Zalathar avatar Oct 18 '24 11:10 Zalathar

Thanks. @bors r+ rollup

jieyouxu avatar Oct 18 '24 11:10 jieyouxu

:pushpin: Commit 554097678a990255d580078e9d7f6b1d81d78752 has been approved by jieyouxu

It is now in the queue for this repository.

bors avatar Oct 18 '24 11:10 bors