rust
rust copied to clipboard
rust-lang
Update TRPL to add new Chapter 17: Async and Await
- Update the submodule for the book to pull in the new chapter on async and await, as well as a number of other fixes. This will happen organically/automatically in a week, too, but this lets me group this change with the next one:
- Update the compiler messages which reference the existing chapters 17–20, which are now chapters 18-21. There are only two, both previously referencing chapter 18.
r? @cjgillot
rustbot has assigned @cjgillot. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
--- stdout
running 8 tests
test ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 234) ... ignored
test ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 356) ... FAILED
test ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 152) ... FAILED
test ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 399) ... FAILED
test ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 309) ... FAILED
test ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 83) ... FAILED
test ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 186) ... FAILED
test ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 455) ... ok
failures:
---- ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 356) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-01-futures-and-syntax.md:356:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 152) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-01-futures-and-syntax.md:153:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 399) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-01-futures-and-syntax.md:400:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 309) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-01-futures-and-syntax.md:310:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 83) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-01-futures-and-syntax.md:84:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 186) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-01-futures-and-syntax.md:186:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
failures:
ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 152)
ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 186)
ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 309)
ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 356)
ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 399)
ch17-01-futures-and-syntax.md - _::Futures_and_the_Async_Syntax::Our_First_Async_Program (line 83)
test result: FAILED. 1 passed; 6 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.08s
--- stderr
--- stderr
[2024-10-17T23:42:59Z ERROR mdbook::book] rustdoc returned an error:
--- stdout
running 8 tests
test ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Message_Passing (line 297) ... ignored
test ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Message_Passing (line 384) ... ignored
test ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Message_Passing (line 244) ... FAILED
test ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Message_Passing (line 460) ... FAILED
test ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Message_Passing (line 512) ... FAILED
test ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Counting (line 91) ... FAILED
test ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Counting (line 160) ... FAILED
test ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Counting (line 24) ... FAILED
failures:
---- ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Message_Passing (line 244) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-02-concurrency-with-async.md:245:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Message_Passing (line 460) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-02-concurrency-with-async.md:461:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Message_Passing (line 512) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-02-concurrency-with-async.md:513:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Counting (line 91) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-02-concurrency-with-async.md:92:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Counting (line 160) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-02-concurrency-with-async.md:161:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Counting (line 24) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-02-concurrency-with-async.md:25:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
failures:
ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Counting (line 160)
ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Counting (line 24)
ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Counting (line 91)
ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Message_Passing (line 244)
ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Message_Passing (line 460)
ch17-02-concurrency-with-async.md - _::Concurrency_With_Async::Message_Passing (line 512)
test result: FAILED. 0 passed; 6 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.05s
--- stderr
--- stderr
[2024-10-17T23:42:59Z ERROR mdbook::book] rustdoc returned an error:
--- stdout
running 16 tests
test ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures (line 197) ... ignored
test ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures (line 259) ... ignored
test ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures (line 78) ... ignored
test ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Building_Our_Own_Async_Abstractions (line 1028) ... ignored
test ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Building_Our_Own_Async_Abstractions (line 986) ... ignored
test ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Racing_futures (line 612) ... FAILED
test ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures (line 565) ... FAILED
test ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Yielding (line 702) ... FAILED
test ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Yielding (line 855) ... FAILED
test ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures (line 497) ... FAILED
test ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Yielding (line 677) ... FAILED
test ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Building_Our_Own_Async_Abstractions (line 1078) ... FAILED
test ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures (line 13) ... FAILED
test ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures (line 403) ... FAILED
test ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Yielding (line 776) ... FAILED
test ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Yielding (line 915) ... FAILED
failures:
---- ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Racing_futures (line 612) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-03-more-futures.md:613:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures (line 565) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-03-more-futures.md:566:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Yielding (line 702) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-03-more-futures.md:703:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Yielding (line 855) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-03-more-futures.md:856:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures (line 497) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-03-more-futures.md:498:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Yielding (line 677) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-03-more-futures.md:678:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Building_Our_Own_Async_Abstractions (line 1078) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-03-more-futures.md:1079:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures (line 13) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-03-more-futures.md:14:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures (line 403) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-03-more-futures.md:404:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Yielding (line 776) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-03-more-futures.md:777:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Yielding (line 915) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-03-more-futures.md:916:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
failures:
ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures (line 13)
ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures (line 403)
ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures (line 497)
ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures (line 565)
ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Building_Our_Own_Async_Abstractions (line 1078)
ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Racing_futures (line 612)
ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Yielding (line 677)
ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Yielding (line 702)
ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Yielding (line 776)
ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Yielding (line 855)
ch17-03-more-futures.md - _::Working_With_Any_Number_of_Futures::Yielding (line 915)
test result: FAILED. 0 passed; 11 failed; 5 ignored; 0 measured; 0 filtered out; finished in 0.06s
--- stderr
--- stderr
[2024-10-17T23:42:59Z ERROR mdbook::book] rustdoc returned an error:
--- stdout
running 11 tests
test ch17-04-streams.md - _::Streams (line 28) ... ignored
test ch17-04-streams.md - _::Streams::Merging_Streams (line 485) ... ignored
test ch17-04-streams.md - _::Streams::Merging_Streams (line 565) ... ignored
test ch17-04-streams.md - _::Streams::Composing_Streams (line 187) ... FAILED
test ch17-04-streams.md - _::Streams::Merging_Streams (line 416) ... FAILED
test ch17-04-streams.md - _::Streams::Composing_Streams (line 296) ... FAILED
test ch17-04-streams.md - _::Streams::Composing_Streams (line 251) ... FAILED
test ch17-04-streams.md - _::Streams::Merging_Streams (line 772) ... FAILED
test ch17-04-streams.md - _::Streams::Merging_Streams (line 659) ... FAILED
test ch17-04-streams.md - _::Streams (line 109) ... FAILED
test ch17-04-streams.md - _::Streams (line 136) ... FAILED
failures:
---- ch17-04-streams.md - _::Streams::Composing_Streams (line 187) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-04-streams.md:188:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-04-streams.md - _::Streams::Merging_Streams (line 416) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-04-streams.md:417:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-04-streams.md - _::Streams::Composing_Streams (line 296) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-04-streams.md:297:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-04-streams.md - _::Streams::Composing_Streams (line 251) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-04-streams.md:252:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-04-streams.md - _::Streams::Merging_Streams (line 772) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-04-streams.md:773:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-04-streams.md - _::Streams::Merging_Streams (line 659) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-04-streams.md:660:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-04-streams.md - _::Streams (line 109) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-04-streams.md:110:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-04-streams.md - _::Streams (line 136) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-04-streams.md:137:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
failures:
ch17-04-streams.md - _::Streams (line 109)
ch17-04-streams.md - _::Streams (line 136)
ch17-04-streams.md - _::Streams::Composing_Streams (line 187)
ch17-04-streams.md - _::Streams::Composing_Streams (line 251)
ch17-04-streams.md - _::Streams::Composing_Streams (line 296)
ch17-04-streams.md - _::Streams::Merging_Streams (line 416)
ch17-04-streams.md - _::Streams::Merging_Streams (line 659)
ch17-04-streams.md - _::Streams::Merging_Streams (line 772)
test result: FAILED. 0 passed; 8 failed; 3 ignored; 0 measured; 0 filtered out; finished in 0.05s
--- stderr
--- stderr
[2024-10-17T23:42:59Z ERROR mdbook::book] rustdoc returned an error:
--- stdout
running 2 tests
test ch17-06-futures-tasks-threads.md - _::Futures__Tasks__and_Threads (line 34) ... FAILED
test ch17-06-futures-tasks-threads.md - _::Futures__Tasks__and_Threads (line 170) ... FAILED
failures:
---- ch17-06-futures-tasks-threads.md - _::Futures__Tasks__and_Threads (line 34) stdout ----
error[E0463]: can't find crate for `trpl`
--> ch17-06-futures-tasks-threads.md:35:1
|
2 | extern crate trpl; // required for mdbook test
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
Couldn't compile the test.
---- ch17-06-futures-tasks-threads.md - _::Futures__Tasks__and_Threads (line 170) stdout ----
---
This PR updated 'src/doc/book', verifying if status is 'test-pass'...
We detected that this PR updated 'book', but its tests failed.
If you do intend to update 'book', please check the error messages above and
commit another update.
If you do NOT intend to update 'book', please ensure you did not accidentally
change the submodule at 'src/doc/book'. You may ask your reviewer for the
Build completed unsuccessfully in 0:00:00
local time: Thu Oct 17 23:43:40 UTC 2024
network time: Thu, 17 Oct 2024 23:43:40 GMT
##[error]Process completed with exit code 1.
All right, this is going to be fun to sort out. 😂 In the book crate, the CI run explicitly handles making sure trpl is built and available; it looks like I’ll have to do the same here. However, trpl pulls in tokio (!) and I’m ~~extremely confident~~ (I was wrong! See below) we don’t want rust to depend on tokio. 😬 Much to sort out.
However, trpl pulls in tokio (!) and I’m extremely confident we don’t want rust to depend on tokio
I'm not quite sure I understand, but I don't see a problem depending on tokio in this repo. It's in the lock file already: https://github.com/rust-lang/rust/blob/d9c4b8d475360b52e6debead2cd710e9fe3c7110/Cargo.lock#L5332
@Noratrieb Oh, well, that definitely simplifies things a bit then! I had missed that it was there. I just didn’t want to go adding it needlessly, given it is large! We do depend on a specific version in the book repo, but I think that will probably be Fine™ once I get the other bits around the build pipeline sorted out.
Long story short: For the new chapter on async, we built a small crate, trpl, which re-exports items from futures, tokio, and tokio-stream. Many of the examples in the book use those exports. So the rust build and tests need to support that!
I am currently digging into the spot we invoke rustbook to build the crate to figure out what I need to do to make this dance work. Unfortunately, mdbook does not really support external crates in a first-class way, but I think I’ll be able to get it working even so, along similar lines as what I did in the book repo.
(That said, if people have better suggestions on how to do this here, I am all ears!)
The job mingw-check-tidy failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
--stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#13 2.713 Building wheels for collected packages: reuse
#13 2.714 Building wheel for reuse (pyproject.toml): started
#13 2.964 Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 2.965 Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=026f3bb0f1aa8090b861fd0a0939cb1a782396d84c8aab7875096557d637a0f6
#13 2.965 Stored in directory: /tmp/pip-ephem-wheel-cache-8gf_f86v/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#13 2.968 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#13 3.371 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#13 3.371 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 3.895 Collecting virtualenv
#13 3.895 Collecting virtualenv
#13 4.073 Downloading virtualenv-20.27.0-py3-none-any.whl (3.1 MB)
#13 4.135 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.1/3.1 MB 52.4 MB/s eta 0:00:00
#13 4.188 Collecting platformdirs<5,>=3.9.1
#13 4.191 Downloading platformdirs-4.3.6-py3-none-any.whl (18 kB)
#13 4.208 Collecting distlib<1,>=0.3.7
#13 4.220 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 85.1 MB/s eta 0:00:00
#13 4.254 Collecting filelock<4,>=3.12.2
#13 4.257 Downloading filelock-3.16.1-py3-none-any.whl (16 kB)
#13 4.257 Downloading filelock-3.16.1-py3-none-any.whl (16 kB)
#13 4.338 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 4.512 Successfully installed distlib-0.3.9 filelock-3.16.1 platformdirs-4.3.6 virtualenv-20.27.0
#13 DONE 4.6s
#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
Compiling build_helper v0.1.0 (/checkout/src/tools/build_helper)
error[E0282]: type annotations needed
##[error] --> src/core/build_steps/test.rs:2354:1
|
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_^ cannot infer type
|
= note: this error originates in the macro `vec` which comes from the expansion of the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0599]: no method named `into_string` found for reference `&str` in the current scope
##[error] --> src/core/build_steps/test.rs:2327:51
|
2327 | dependencies.push(dep.into_string());
| ^^^^^^^^^^^
...
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_- in this macro invocation
|
= note: this error originates in the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
help: there is a method `to_string` with a similar name
---
Compiling bootstrap v0.0.0 (/checkout/src/bootstrap)
error[E0282]: type annotations needed
##[error] --> src/core/build_steps/test.rs:2354:1
|
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_^ cannot infer type
|
= note: this error originates in the macro `vec` which comes from the expansion of the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0599]: no method named `into_string` found for reference `&str` in the current scope
##[error] --> src/core/build_steps/test.rs:2327:51
|
2327 | dependencies.push(dep.into_string());
| ^^^^^^^^^^^
...
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_- in this macro invocation
|
= note: this error originates in the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
help: there is a method `to_string` with a similar name
---
Compiling bootstrap v0.0.0 (/checkout/src/bootstrap)
error[E0282]: type annotations needed
##[error] --> src/core/build_steps/test.rs:2354:1
|
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_^ cannot infer type
|
= note: this error originates in the macro `vec` which comes from the expansion of the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0599]: no method named `into_string` found for reference `&str` in the current scope
##[error] --> src/core/build_steps/test.rs:2327:51
|
2327 | dependencies.push(dep.into_string());
| ^^^^^^^^^^^
...
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_- in this macro invocation
|
= note: this error originates in the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
help: there is a method `to_string` with a similar name
---
Compiling bootstrap v0.0.0 (/checkout/src/bootstrap)
error[E0282]: type annotations needed
##[error] --> src/core/build_steps/test.rs:2354:1
|
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_^ cannot infer type
|
= note: this error originates in the macro `vec` which comes from the expansion of the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0599]: no method named `into_string` found for reference `&str` in the current scope
##[error] --> src/core/build_steps/test.rs:2327:51
|
2327 | dependencies.push(dep.into_string());
| ^^^^^^^^^^^
...
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_- in this macro invocation
|
= note: this error originates in the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
help: there is a method `to_string` with a similar name
---
Compiling bootstrap v0.0.0 (/checkout/src/bootstrap)
error[E0282]: type annotations needed
##[error] --> src/core/build_steps/test.rs:2354:1
|
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_^ cannot infer type
|
= note: this error originates in the macro `vec` which comes from the expansion of the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0599]: no method named `into_string` found for reference `&str` in the current scope
##[error] --> src/core/build_steps/test.rs:2327:51
|
2327 | dependencies.push(dep.into_string());
| ^^^^^^^^^^^
...
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_- in this macro invocation
|
= note: this error originates in the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
help: there is a method `to_string` with a similar name
The job mingw-check failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
#16 2.835 Building wheels for collected packages: reuse
#16 2.836 Building wheel for reuse (pyproject.toml): started
#16 3.087 Building wheel for reuse (pyproject.toml): finished with status 'done'
#16 3.088 Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=026f3bb0f1aa8090b861fd0a0939cb1a782396d84c8aab7875096557d637a0f6
#16 3.088 Stored in directory: /tmp/pip-ephem-wheel-cache-r09aykqb/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#16 3.091 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#16 3.486 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#16 3.486 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#16 DONE 3.6s
---
Compiling build_helper v0.1.0 (/checkout/src/tools/build_helper)
error[E0282]: type annotations needed
##[error] --> src/core/build_steps/test.rs:2354:1
|
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_^ cannot infer type
|
= note: this error originates in the macro `vec` which comes from the expansion of the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0599]: no method named `into_string` found for reference `&str` in the current scope
##[error] --> src/core/build_steps/test.rs:2327:51
|
2327 | dependencies.push(dep.into_string());
| ^^^^^^^^^^^
...
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_- in this macro invocation
|
= note: this error originates in the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
help: there is a method `to_string` with a similar name
---
Compiling bootstrap v0.0.0 (/checkout/src/bootstrap)
error[E0282]: type annotations needed
##[error] --> src/core/build_steps/test.rs:2354:1
|
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_^ cannot infer type
|
= note: this error originates in the macro `vec` which comes from the expansion of the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0599]: no method named `into_string` found for reference `&str` in the current scope
##[error] --> src/core/build_steps/test.rs:2327:51
|
2327 | dependencies.push(dep.into_string());
| ^^^^^^^^^^^
...
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_- in this macro invocation
|
= note: this error originates in the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
help: there is a method `to_string` with a similar name
---
Compiling bootstrap v0.0.0 (/checkout/src/bootstrap)
error[E0282]: type annotations needed
##[error] --> src/core/build_steps/test.rs:2354:1
|
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_^ cannot infer type
|
= note: this error originates in the macro `vec` which comes from the expansion of the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0599]: no method named `into_string` found for reference `&str` in the current scope
##[error] --> src/core/build_steps/test.rs:2327:51
|
2327 | dependencies.push(dep.into_string());
| ^^^^^^^^^^^
...
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_- in this macro invocation
|
= note: this error originates in the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
help: there is a method `to_string` with a similar name
---
Compiling bootstrap v0.0.0 (/checkout/src/bootstrap)
error[E0282]: type annotations needed
##[error] --> src/core/build_steps/test.rs:2354:1
|
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_^ cannot infer type
|
= note: this error originates in the macro `vec` which comes from the expansion of the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0599]: no method named `into_string` found for reference `&str` in the current scope
##[error] --> src/core/build_steps/test.rs:2327:51
|
2327 | dependencies.push(dep.into_string());
| ^^^^^^^^^^^
...
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_- in this macro invocation
|
= note: this error originates in the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
help: there is a method `to_string` with a similar name
---
Compiling bootstrap v0.0.0 (/checkout/src/bootstrap)
error[E0282]: type annotations needed
##[error] --> src/core/build_steps/test.rs:2354:1
|
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_^ cannot infer type
|
= note: this error originates in the macro `vec` which comes from the expansion of the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0599]: no method named `into_string` found for reference `&str` in the current scope
##[error] --> src/core/build_steps/test.rs:2327:51
|
2327 | dependencies.push(dep.into_string());
| ^^^^^^^^^^^
...
2354 | / test_book!(
2355 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2356 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2357 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2363 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_- in this macro invocation
|
= note: this error originates in the macro `test_book` (in Nightly builds, run with -Z macro-backtrace for more info)
help: there is a method `to_string` with a similar name
The job mingw-check-tidy failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
--stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#13 2.844 Building wheels for collected packages: reuse
#13 2.845 Building wheel for reuse (pyproject.toml): started
#13 3.088 Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 3.089 Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=026f3bb0f1aa8090b861fd0a0939cb1a782396d84c8aab7875096557d637a0f6
#13 3.089 Stored in directory: /tmp/pip-ephem-wheel-cache-m5d576m0/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#13 3.092 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#13 3.479 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#13 3.479 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 4.012 Collecting virtualenv
#13 4.012 Collecting virtualenv
#13 4.070 Downloading virtualenv-20.27.0-py3-none-any.whl (3.1 MB)
#13 4.240 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.1/3.1 MB 18.6 MB/s eta 0:00:00
#13 4.297 Collecting platformdirs<5,>=3.9.1
#13 4.305 Downloading platformdirs-4.3.6-py3-none-any.whl (18 kB)
#13 4.345 Collecting filelock<4,>=3.12.2
#13 4.375 Collecting distlib<1,>=0.3.7
#13 4.384 Downloading distlib-0.3.9-py2.py3-none-any.whl (468 kB)
#13 4.400 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 34.0 MB/s eta 0:00:00
#13 4.400 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 34.0 MB/s eta 0:00:00
#13 4.481 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 4.654 Successfully installed distlib-0.3.9 filelock-3.16.1 platformdirs-4.3.6 virtualenv-20.27.0
#13 DONE 4.7s
#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
error[E0277]: `PathBuf` doesn't implement `std::fmt::Display`
##[error] --> src/core/build_steps/test.rs:2244:40
|
2244 | todo!("run cargo build {dep}");
| ^^^^^ `PathBuf` cannot be formatted with the default formatter; call `.display()` on it
= help: the trait `std::fmt::Display` is not implemented for `PathBuf`
= note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
= note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
= note: call `.display()` or `.to_string_lossy()` to safely print paths, as they may contain non-Unicode data
= note: this error originates in the macro `$crate::const_format_args` which comes from the expansion of the macro `todo` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0308]: mismatched types
##[error] --> src/core/build_steps/test.rs:2365:25
|
2347 | dependencies.push(dep.to_string());
2347 | dependencies.push(dep.to_string());
| ------------ --------------- this argument has type `std::string::String`...
| |
| ... which causes `dependencies` to have type `Vec<std::string::String>`
...
2365 | dependencies,
| ^^^^^^^^^^^^ expected `Vec<PathBuf>`, found `Vec<String>`
...
2374 | / test_book!(
2375 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2376 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2377 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2383 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_- in this macro invocation
|
= note: expected struct `Vec<PathBuf>`
found struct `Vec<std::string::String>`
---
error[E0277]: `PathBuf` doesn't implement `std::fmt::Display`
##[error] --> src/core/build_steps/test.rs:2244:40
|
2244 | todo!("run cargo build {dep}");
| ^^^^^ `PathBuf` cannot be formatted with the default formatter; call `.display()` on it
= help: the trait `std::fmt::Display` is not implemented for `PathBuf`
= note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
= note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
= note: call `.display()` or `.to_string_lossy()` to safely print paths, as they may contain non-Unicode data
= note: this error originates in the macro `$crate::const_format_args` which comes from the expansion of the macro `todo` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0308]: mismatched types
##[error] --> src/core/build_steps/test.rs:2365:25
|
2347 | dependencies.push(dep.to_string());
2347 | dependencies.push(dep.to_string());
| ------------ --------------- this argument has type `std::string::String`...
| |
| ... which causes `dependencies` to have type `Vec<std::string::String>`
...
2365 | dependencies,
| ^^^^^^^^^^^^ expected `Vec<PathBuf>`, found `Vec<String>`
...
2374 | / test_book!(
2375 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2376 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2377 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2383 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_- in this macro invocation
|
= note: expected struct `Vec<PathBuf>`
found struct `Vec<std::string::String>`
---
error[E0277]: `PathBuf` doesn't implement `std::fmt::Display`
##[error] --> src/core/build_steps/test.rs:2244:40
|
2244 | todo!("run cargo build {dep}");
| ^^^^^ `PathBuf` cannot be formatted with the default formatter; call `.display()` on it
= help: the trait `std::fmt::Display` is not implemented for `PathBuf`
= note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
= note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
= note: call `.display()` or `.to_string_lossy()` to safely print paths, as they may contain non-Unicode data
= note: this error originates in the macro `$crate::const_format_args` which comes from the expansion of the macro `todo` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0308]: mismatched types
##[error] --> src/core/build_steps/test.rs:2365:25
|
2347 | dependencies.push(dep.to_string());
2347 | dependencies.push(dep.to_string());
| ------------ --------------- this argument has type `std::string::String`...
| |
| ... which causes `dependencies` to have type `Vec<std::string::String>`
...
2365 | dependencies,
| ^^^^^^^^^^^^ expected `Vec<PathBuf>`, found `Vec<String>`
...
2374 | / test_book!(
2375 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2376 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2377 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2383 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_- in this macro invocation
|
= note: expected struct `Vec<PathBuf>`
found struct `Vec<std::string::String>`
---
error[E0277]: `PathBuf` doesn't implement `std::fmt::Display`
##[error] --> src/core/build_steps/test.rs:2244:40
|
2244 | todo!("run cargo build {dep}");
| ^^^^^ `PathBuf` cannot be formatted with the default formatter; call `.display()` on it
= help: the trait `std::fmt::Display` is not implemented for `PathBuf`
= note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
= note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
= note: call `.display()` or `.to_string_lossy()` to safely print paths, as they may contain non-Unicode data
= note: this error originates in the macro `$crate::const_format_args` which comes from the expansion of the macro `todo` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0308]: mismatched types
##[error] --> src/core/build_steps/test.rs:2365:25
|
2347 | dependencies.push(dep.to_string());
2347 | dependencies.push(dep.to_string());
| ------------ --------------- this argument has type `std::string::String`...
| |
| ... which causes `dependencies` to have type `Vec<std::string::String>`
...
2365 | dependencies,
| ^^^^^^^^^^^^ expected `Vec<PathBuf>`, found `Vec<String>`
...
2374 | / test_book!(
2375 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2376 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2377 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2383 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_- in this macro invocation
|
= note: expected struct `Vec<PathBuf>`
found struct `Vec<std::string::String>`
---
error[E0277]: `PathBuf` doesn't implement `std::fmt::Display`
##[error] --> src/core/build_steps/test.rs:2244:40
|
2244 | todo!("run cargo build {dep}");
| ^^^^^ `PathBuf` cannot be formatted with the default formatter; call `.display()` on it
= help: the trait `std::fmt::Display` is not implemented for `PathBuf`
= note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
= note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
= note: call `.display()` or `.to_string_lossy()` to safely print paths, as they may contain non-Unicode data
= note: this error originates in the macro `$crate::const_format_args` which comes from the expansion of the macro `todo` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0308]: mismatched types
##[error] --> src/core/build_steps/test.rs:2365:25
|
2347 | dependencies.push(dep.to_string());
2347 | dependencies.push(dep.to_string());
| ------------ --------------- this argument has type `std::string::String`...
| |
| ... which causes `dependencies` to have type `Vec<std::string::String>`
...
2365 | dependencies,
| ^^^^^^^^^^^^ expected `Vec<PathBuf>`, found `Vec<String>`
...
2374 | / test_book!(
2375 | | Nomicon, "src/doc/nomicon", "nomicon", default=false, submodules=["src/doc/nomicon"];
2376 | | Reference, "src/doc/reference", "reference", default=false, submodules=["src/doc/reference"];
2377 | | RustdocBook, "src/doc/rustdoc", "rustdoc", default=true;
... |
2383 | | EditionGuide, "src/doc/edition-guide", "edition-guide", default=false, submodules=["src/doc/edition-guide"];
| |_- in this macro invocation
|
= note: expected struct `Vec<PathBuf>`
found struct `Vec<std::string::String>`
Another thing we should probably include here is to add trpl as an unused dependency in rustbook/Cargo.toml. This will help ensure that the trpl dependencies are vendored.
Let me know if you run into any major roadblocks. I dropped the book update from #132007.
The job mingw-check-tidy failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
--stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#13 2.936 Building wheels for collected packages: reuse
#13 2.937 Building wheel for reuse (pyproject.toml): started
#13 3.190 Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 3.191 Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=026f3bb0f1aa8090b861fd0a0939cb1a782396d84c8aab7875096557d637a0f6
#13 3.192 Stored in directory: /tmp/pip-ephem-wheel-cache-yopdrv_p/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#13 3.194 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#13 3.602 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#13 3.602 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 4.173 Collecting virtualenv
#13 4.173 Collecting virtualenv
#13 4.227 Downloading virtualenv-20.27.0-py3-none-any.whl (3.1 MB)
#13 4.361 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.1/3.1 MB 23.8 MB/s eta 0:00:00
#13 4.404 Collecting distlib<1,>=0.3.7
#13 4.412 Downloading distlib-0.3.9-py2.py3-none-any.whl (468 kB)
#13 4.425 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 41.4 MB/s eta 0:00:00
#13 4.464 Collecting platformdirs<5,>=3.9.1
#13 4.473 Downloading platformdirs-4.3.6-py3-none-any.whl (18 kB)
#13 4.513 Collecting filelock<4,>=3.12.2
#13 4.522 Downloading filelock-3.16.1-py3-none-any.whl (16 kB)
#13 4.605 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 4.782 Successfully installed distlib-0.3.9 filelock-3.16.1 platformdirs-4.3.6 virtualenv-20.27.0
#13 DONE 4.9s
#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
DirectMap4k: 188352 kB
DirectMap2M: 7151616 kB
DirectMap1G: 11534336 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
downloading https://static.rust-lang.org/dist/2024-10-16/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/2024-10-16/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt
---
Diff in /checkout/src/tools/rustbook/src/main.rs:1:
use std::env;
use std::path::{Path, PathBuf};
-use clap::{arg, crate_version, ArgMatches, Command};
-use mdbook::errors::Result as Result3;
+use clap::{ArgMatches, Command, arg, crate_version};
use mdbook::MDBook;
+use mdbook::errors::Result as Result3;
use mdbook_i18n_helpers::preprocessors::Gettext;
use mdbook_spec::Spec;
use mdbook_trpl_listing::TrplListing;
Diff in /checkout/src/tools/rustbook/src/main.rs:139:
fn get_book_dir(args: &ArgMatches) -> PathBuf {
if let Some(p) = args.get_one::<PathBuf>("dir") {
// Check if path is relative from current dir, or absolute...
- if p.is_relative() {
The job mingw-check-tidy failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
--stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#13 3.018 Building wheels for collected packages: reuse
#13 3.019 Building wheel for reuse (pyproject.toml): started
#13 3.261 Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 3.262 Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=026f3bb0f1aa8090b861fd0a0939cb1a782396d84c8aab7875096557d637a0f6
#13 3.262 Stored in directory: /tmp/pip-ephem-wheel-cache-tgdsaxta/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#13 3.265 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#13 3.666 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#13 3.667 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 4.181 Collecting virtualenv
#13 4.181 Collecting virtualenv
#13 4.259 Downloading virtualenv-20.27.0-py3-none-any.whl (3.1 MB)
#13 4.354 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.1/3.1 MB 33.4 MB/s eta 0:00:00
#13 4.412 Collecting filelock<4,>=3.12.2
#13 4.427 Downloading filelock-3.16.1-py3-none-any.whl (16 kB)
#13 4.461 Collecting platformdirs<5,>=3.9.1
#13 4.476 Downloading platformdirs-4.3.6-py3-none-any.whl (18 kB)
#13 4.494 Collecting distlib<1,>=0.3.7
#13 4.517 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 78.8 MB/s eta 0:00:00
#13 4.517 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 78.8 MB/s eta 0:00:00
#13 4.597 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 4.771 Successfully installed distlib-0.3.9 filelock-3.16.1 platformdirs-4.3.6 virtualenv-20.27.0
#13 DONE 4.8s
#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
DirectMap4k: 180160 kB
DirectMap2M: 6111232 kB
DirectMap1G: 12582912 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
downloading https://static.rust-lang.org/dist/2024-10-16/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/2024-10-16/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt
---
##[endgroup]
fmt check
fmt: checked 5631 files
tidy check
thread 'deps (.)' panicked at src/tools/tidy/src/deps.rs:599:24:
cmd.exec() failed with `cargo metadata` exited with an error: Updating crates.io index
error: the lock file /checkout/src/tools/rustbook/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, remove the --locked flag and use --offline instead.
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at src/tools/tidy/src/main.rs:60:49:
called `Result::unwrap()` on an `Err` value: Any { .. }
Build completed unsuccessfully in 0:01:21
Build completed unsuccessfully in 0:01:21
Command has failed. Rerun with -v to see more details.
network time: Fri, 25 Oct 2024 16:35:11 GMT
##[error]Process completed with exit code 1.
Post job cleanup.
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.
cc @davidtwco, @wesleywiser
The job mingw-check failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
#16 3.010 Building wheels for collected packages: reuse
#16 3.011 Building wheel for reuse (pyproject.toml): started
#16 3.256 Building wheel for reuse (pyproject.toml): finished with status 'done'
#16 3.257 Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=026f3bb0f1aa8090b861fd0a0939cb1a782396d84c8aab7875096557d637a0f6
#16 3.257 Stored in directory: /tmp/pip-ephem-wheel-cache-wq7lsd0f/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#16 3.260 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#16 3.657 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#16 3.657 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#16 DONE 3.7s
The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
##[group]Building bootstrap
Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
thread 'main' panicked at src/core/builder/cargo.rs:518:9:
assertion failed: !use_snapshot || stage == 0 || self.local_rebuild
Build completed unsuccessfully in 0:00:00
+ set -e
+ cat /tmp/toolstate/toolstates.json
{"lld-wrapper":"test-fail","wasm-component-ld":"test-fail"}
{"lld-wrapper":"test-fail","wasm-component-ld":"test-fail"}
+ python3 ../x.py test --stage 2 check-tools
##[group]Building bootstrap
Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
ERROR: Tool `book` was not recorded in tool state.
ERROR: Tool `nomicon` was not recorded in tool state.
ERROR: Tool `reference` was not recorded in tool state.
ERROR: Tool `rust-by-example` was not recorded in tool state.
ERROR: Tool `edition-guide` was not recorded in tool state.
ERROR: Tool `embedded-book` was not recorded in tool state.
local time: Fri Oct 25 21:11:51 UTC 2024
network time: Fri, 25 Oct 2024 21:11:51 GMT
##[error]Process completed with exit code 1.
Post job cleanup.
The job mingw-check-tidy failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
--stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#13 2.655 Building wheels for collected packages: reuse
#13 2.656 Building wheel for reuse (pyproject.toml): started
#13 2.901 Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 2.902 Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=026f3bb0f1aa8090b861fd0a0939cb1a782396d84c8aab7875096557d637a0f6
#13 2.902 Stored in directory: /tmp/pip-ephem-wheel-cache-5u6pa0lo/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#13 2.905 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#13 3.300 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#13 3.300 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 3.822 Collecting virtualenv
#13 3.822 Collecting virtualenv
#13 3.863 Downloading virtualenv-20.27.0-py3-none-any.whl (3.1 MB)
#13 3.919 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.1/3.1 MB 58.6 MB/s eta 0:00:00
#13 3.974 Collecting filelock<4,>=3.12.2
#13 3.979 Downloading filelock-3.16.1-py3-none-any.whl (16 kB)
#13 4.011 Collecting platformdirs<5,>=3.9.1
#13 4.016 Downloading platformdirs-4.3.6-py3-none-any.whl (18 kB)
#13 4.040 Collecting distlib<1,>=0.3.7
#13 4.086 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 47.2 MB/s eta 0:00:00
#13 4.086 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 47.2 MB/s eta 0:00:00
#13 4.166 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 4.340 Successfully installed distlib-0.3.9 filelock-3.16.1 platformdirs-4.3.6 virtualenv-20.27.0
#13 DONE 4.4s
#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
DirectMap4k: 208832 kB
DirectMap2M: 8179712 kB
DirectMap1G: 10485760 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
downloading https://static.rust-lang.org/dist/2024-10-16/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/2024-10-16/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt
---
Diff in /checkout/src/tools/rustbook/src/main.rs:1:
use std::env;
use std::path::{Path, PathBuf};
-use clap::{arg, crate_version, ArgMatches, Command};
-use mdbook::errors::Result as Result3;
+use clap::{ArgMatches, Command, arg, crate_version};
use mdbook::MDBook;
+use mdbook::errors::Result as Result3;
use mdbook_i18n_helpers::preprocessors::Gettext;
use mdbook_spec::Spec;
use mdbook_trpl_listing::TrplListing;
Diff in /checkout/src/tools/rustbook/src/main.rs:139:
fn get_book_dir(args: &ArgMatches) -> PathBuf {
if let Some(p) = args.get_one::<PathBuf>("dir") {
// Check if path is relative from current dir, or absolute...
- if p.is_relative() {
The job mingw-check-tidy failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
--stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#13 2.860 Building wheels for collected packages: reuse
#13 2.861 Building wheel for reuse (pyproject.toml): started
#13 3.108 Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 3.109 Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=026f3bb0f1aa8090b861fd0a0939cb1a782396d84c8aab7875096557d637a0f6
#13 3.110 Stored in directory: /tmp/pip-ephem-wheel-cache-eyjy4jz8/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#13 3.113 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#13 3.514 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#13 3.514 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 4.056 Collecting virtualenv
#13 4.056 Collecting virtualenv
#13 4.093 Downloading virtualenv-20.27.0-py3-none-any.whl (3.1 MB)
#13 4.149 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.1/3.1 MB 57.6 MB/s eta 0:00:00
#13 4.188 Collecting distlib<1,>=0.3.7
#13 4.192 Downloading distlib-0.3.9-py2.py3-none-any.whl (468 kB)
#13 4.200 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 83.2 MB/s eta 0:00:00
#13 4.236 Collecting filelock<4,>=3.12.2
#13 4.240 Downloading filelock-3.16.1-py3-none-any.whl (16 kB)
#13 4.272 Collecting platformdirs<5,>=3.9.1
#13 4.276 Downloading platformdirs-4.3.6-py3-none-any.whl (18 kB)
#13 4.360 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 4.543 Successfully installed distlib-0.3.9 filelock-3.16.1 platformdirs-4.3.6 virtualenv-20.27.0
#13 DONE 4.6s
#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
DirectMap4k: 180160 kB
DirectMap2M: 7159808 kB
DirectMap1G: 11534336 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
downloading https://static.rust-lang.org/dist/2024-10-16/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/2024-10-16/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt
---
Diff in /checkout/src/tools/rustbook/src/main.rs:1:
use std::env;
use std::path::{Path, PathBuf};
-use clap::{arg, crate_version, ArgMatches, Command};
-use mdbook::errors::Result as Result3;
+use clap::{ArgMatches, Command, arg, crate_version};
use mdbook::MDBook;
+use mdbook::errors::Result as Result3;
use mdbook_i18n_helpers::preprocessors::Gettext;
use mdbook_spec::Spec;
use mdbook_trpl_listing::TrplListing;
Diff in /checkout/src/tools/rustbook/src/main.rs:139:
fn get_book_dir(args: &ArgMatches) -> PathBuf {
if let Some(p) = args.get_one::<PathBuf>("dir") {
// Check if path is relative from current dir, or absolute...
- if p.is_relative() {
All right, let’s see what CI says, but I think I have this working! At minimum, things work locally. There are a few CHECKME comments which could use input from maintainers who know what they’re doing (I certainly do not!), and of course general review and improvement very welcome!
The job mingw-check-tidy failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
--stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#13 2.891 Building wheels for collected packages: reuse
#13 2.892 Building wheel for reuse (pyproject.toml): started
#13 3.139 Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 3.140 Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=026f3bb0f1aa8090b861fd0a0939cb1a782396d84c8aab7875096557d637a0f6
#13 3.140 Stored in directory: /tmp/pip-ephem-wheel-cache-j317_3hy/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#13 3.143 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#13 3.546 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#13 3.546 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 4.087 Collecting virtualenv
#13 4.087 Collecting virtualenv
#13 4.143 Downloading virtualenv-20.27.0-py3-none-any.whl (3.1 MB)
#13 4.311 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.1/3.1 MB 18.8 MB/s eta 0:00:00
#13 4.368 Collecting platformdirs<5,>=3.9.1
#13 4.376 Downloading platformdirs-4.3.6-py3-none-any.whl (18 kB)
#13 4.399 Collecting distlib<1,>=0.3.7
#13 4.424 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 32.9 MB/s eta 0:00:00
#13 4.464 Collecting filelock<4,>=3.12.2
#13 4.472 Downloading filelock-3.16.1-py3-none-any.whl (16 kB)
#13 4.472 Downloading filelock-3.16.1-py3-none-any.whl (16 kB)
#13 4.553 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 4.730 Successfully installed distlib-0.3.9 filelock-3.16.1 platformdirs-4.3.6 virtualenv-20.27.0
#13 DONE 4.8s
#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
DirectMap4k: 206784 kB
DirectMap2M: 7133184 kB
DirectMap1G: 11534336 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
downloading https://static.rust-lang.org/dist/2024-10-16/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/2024-10-16/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt
---
Diff in /checkout/src/tools/rustbook/src/main.rs:1:
use std::env;
use std::path::{Path, PathBuf};
-use clap::{arg, crate_version, ArgMatches, Command};
-use mdbook::errors::Result as Result3;
+use clap::{ArgMatches, Command, arg, crate_version};
use mdbook::MDBook;
+use mdbook::errors::Result as Result3;
use mdbook_i18n_helpers::preprocessors::Gettext;
use mdbook_spec::Spec;
use mdbook_trpl_listing::TrplListing;
Diff in /checkout/src/tools/rustbook/src/main.rs:139:
fn get_book_dir(args: &ArgMatches) -> PathBuf {
if let Some(p) = args.get_one::<PathBuf>("dir") {
// Check if path is relative from current dir, or absolute...
- if p.is_relative() {
The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
Compiling clap_lex v0.7.2
Compiling pulldown-cmark v0.10.3
The following warnings were emitted during compilation:
warning: [email protected]: Could not find directory of OpenSSL installation, and this `-sys` crate cannot proceed without this knowledge. If OpenSSL is installed and this crate had trouble finding it, you can set the `OPENSSL_DIR` environment variable for the compilation process. See stderr section below for further information.
error: failed to run custom build command for `openssl-sys v0.9.104`
Caused by:
process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/release/build/openssl-sys-925b2ca3c5130ec7/build-script-main` (exit status: 101)
process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/release/build/openssl-sys-925b2ca3c5130ec7/build-script-main` (exit status: 101)
--- stdout
cargo:rustc-check-cfg=cfg(osslconf, values("OPENSSL_NO_OCB", "OPENSSL_NO_SM4", "OPENSSL_NO_SEED", "OPENSSL_NO_CHACHA", "OPENSSL_NO_CAST", "OPENSSL_NO_IDEA", "OPENSSL_NO_CAMELLIA", "OPENSSL_NO_RC4", "OPENSSL_NO_BF", "OPENSSL_NO_PSK", "OPENSSL_NO_DEPRECATED_3_0", "OPENSSL_NO_SCRYPT", "OPENSSL_NO_SM3", "OPENSSL_NO_RMD160", "OPENSSL_NO_EC2M", "OPENSSL_NO_OCSP", "OPENSSL_NO_CMS", "OPENSSL_NO_COMP", "OPENSSL_NO_SOCK", "OPENSSL_NO_STDIO", "OPENSSL_NO_EC", "OPENSSL_NO_SSL3_METHOD", "OPENSSL_NO_KRB5", "OPENSSL_NO_TLSEXT", "OPENSSL_NO_SRP", "OPENSSL_NO_RFC3779", "OPENSSL_NO_SHA", "OPENSSL_NO_NEXTPROTONEG", "OPENSSL_NO_ENGINE", "OPENSSL_NO_BUF_FREELISTS"))
cargo:rustc-check-cfg=cfg(openssl)
cargo:rustc-check-cfg=cfg(libressl)
cargo:rustc-check-cfg=cfg(boringssl)
cargo:rustc-check-cfg=cfg(libressl250)
cargo:rustc-check-cfg=cfg(libressl251)
cargo:rustc-check-cfg=cfg(libressl252)
cargo:rustc-check-cfg=cfg(libressl261)
cargo:rustc-check-cfg=cfg(libressl270)
cargo:rustc-check-cfg=cfg(libressl271)
cargo:rustc-check-cfg=cfg(libressl273)
cargo:rustc-check-cfg=cfg(libressl280)
cargo:rustc-check-cfg=cfg(libressl281)
cargo:rustc-check-cfg=cfg(libressl291)
cargo:rustc-check-cfg=cfg(libressl310)
cargo:rustc-check-cfg=cfg(libressl321)
cargo:rustc-check-cfg=cfg(libressl332)
cargo:rustc-check-cfg=cfg(libressl340)
cargo:rustc-check-cfg=cfg(libressl350)
cargo:rustc-check-cfg=cfg(libressl360)
cargo:rustc-check-cfg=cfg(libressl361)
cargo:rustc-check-cfg=cfg(libressl370)
cargo:rustc-check-cfg=cfg(libressl380)
cargo:rustc-check-cfg=cfg(libressl381)
cargo:rustc-check-cfg=cfg(libressl382)
cargo:rustc-check-cfg=cfg(libressl390)
cargo:rustc-check-cfg=cfg(libressl400)
cargo:rustc-check-cfg=cfg(ossl101)
cargo:rustc-check-cfg=cfg(ossl102)
cargo:rustc-check-cfg=cfg(ossl102f)
cargo:rustc-check-cfg=cfg(ossl102h)
cargo:rustc-check-cfg=cfg(ossl110)
cargo:rustc-check-cfg=cfg(ossl110f)
cargo:rustc-check-cfg=cfg(ossl110g)
cargo:rustc-check-cfg=cfg(ossl110h)
cargo:rustc-check-cfg=cfg(ossl111)
cargo:rustc-check-cfg=cfg(ossl111b)
cargo:rustc-check-cfg=cfg(ossl111c)
cargo:rustc-check-cfg=cfg(ossl111d)
cargo:rustc-check-cfg=cfg(ossl300)
cargo:rustc-check-cfg=cfg(ossl310)
cargo:rustc-check-cfg=cfg(ossl320)
cargo:rustc-check-cfg=cfg(ossl330)
cargo:rustc-check-cfg=cfg(ossl340)
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIR unset
cargo:rerun-if-env-changed=OPENSSL_LIB_DIR
OPENSSL_LIB_DIR unset
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_INCLUDE_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_INCLUDE_DIR unset
cargo:rerun-if-env-changed=OPENSSL_INCLUDE_DIR
OPENSSL_INCLUDE_DIR unset
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_DIR unset
cargo:rerun-if-env-changed=OPENSSL_DIR
OPENSSL_DIR unset
cargo:rerun-if-env-changed=OPENSSL_NO_PKG_CONFIG
cargo:rerun-if-env-changed=PKG_CONFIG_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG
cargo:rerun-if-env-changed=PKG_CONFIG
cargo:rerun-if-env-changed=OPENSSL_STATIC
cargo:rerun-if-env-changed=OPENSSL_DYNAMIC
cargo:rerun-if-env-changed=PKG_CONFIG_ALL_STATIC
cargo:rerun-if-env-changed=PKG_CONFIG_ALL_DYNAMIC
cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
cargo:rerun-if-env-changed=PKG_CONFIG_PATH
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
cargo:rerun-if-env-changed=OPENSSL_STATIC
cargo:rerun-if-env-changed=OPENSSL_DYNAMIC
cargo:rerun-if-env-changed=PKG_CONFIG_ALL_STATIC
cargo:rerun-if-env-changed=PKG_CONFIG_ALL_DYNAMIC
cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
cargo:rerun-if-env-changed=PKG_CONFIG_PATH
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
Could not find openssl via pkg-config:
Could not find openssl via pkg-config:
Could not run `PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 pkg-config --libs --cflags openssl`
The pkg-config command could not be found.
Most likely, you need to install a pkg-config package for your OS.
Most likely, you need to install a pkg-config package for your OS.
Try `apt install pkg-config`, or `yum install pkg-config`,
or `pkg install pkg-config`, or `apk add pkgconfig` depending on your distribution.
If you've already installed it, ensure the pkg-config command is one of the
directories in the PATH environment variable.
If you did not expect this build to link to a pre-installed system library,
If you did not expect this build to link to a pre-installed system library,
then check documentation of the openssl-sys crate for an option to
build the library from source, or disable features or dependencies
that require pkg-config.
cargo:warning=Could not find directory of OpenSSL installation, and this `-sys` crate cannot proceed without this knowledge. If OpenSSL is installed and this crate had trouble finding it, you can set the `OPENSSL_DIR` environment variable for the compilation process. See stderr section below for further information.
--- stderr
Could not find directory of OpenSSL installation, and this `-sys` crate cannot
proceed without this knowledge. If OpenSSL is installed and this crate had
trouble finding it, you can set the `OPENSSL_DIR` environment variable for the
Make sure you also have the development packages of openssl installed.
For example, `libssl-dev` on Ubuntu or `openssl-devel` on Fedora.
If you're in a situation where you think the directory *should* be found
automatically, please open a bug at https://github.com/sfackler/rust-openssl
and include information about your system as well as this message.
$HOST = x86_64-unknown-linux-gnu
$TARGET = x86_64-unknown-linux-gnu
openssl-sys = 0.9.104
It looks like you're compiling on Linux and also targeting Linux. Currently this
requires the `pkg-config` utility to find OpenSSL but unfortunately `pkg-config`
could not be found. If you have OpenSSL installed you can likely fix this by
installing `pkg-config`.
warning: build failed, waiting for other jobs to finish...
Build completed unsuccessfully in 0:00:13
+ set -e
+ set -e
+ cat /tmp/toolstate/toolstates.json
{"rustbook":"build-fail","wasm-component-ld":"test-fail","lld-wrapper":"test-fail"}
+ python3 ../x.py test --stage 2 check-tools
##[group]Building bootstrap
Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
ERROR: Tool `book` was not recorded in tool state.
ERROR: Tool `nomicon` was not recorded in tool state.
ERROR: Tool `reference` was not recorded in tool state.
ERROR: Tool `rust-by-example` was not recorded in tool state.
ERROR: Tool `edition-guide` was not recorded in tool state.
ERROR: Tool `embedded-book` was not recorded in tool state.
local time: Sat Oct 26 03:48:29 UTC 2024
network time: Sat, 26 Oct 2024 03:48:30 GMT
##[error]Process completed with exit code 1.
Post job cleanup.
The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
Compiling futures-task v0.3.31
Compiling futures-io v0.3.31
The following warnings were emitted during compilation:
warning: [email protected]: Could not find directory of OpenSSL installation, and this `-sys` crate cannot proceed without this knowledge. If OpenSSL is installed and this crate had trouble finding it, you can set the `OPENSSL_DIR` environment variable for the compilation process. See stderr section below for further information.
error: failed to run custom build command for `openssl-sys v0.9.104`
Caused by:
process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/release/build/openssl-sys-925b2ca3c5130ec7/build-script-main` (exit status: 101)
process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/release/build/openssl-sys-925b2ca3c5130ec7/build-script-main` (exit status: 101)
--- stdout
cargo:rustc-check-cfg=cfg(osslconf, values("OPENSSL_NO_OCB", "OPENSSL_NO_SM4", "OPENSSL_NO_SEED", "OPENSSL_NO_CHACHA", "OPENSSL_NO_CAST", "OPENSSL_NO_IDEA", "OPENSSL_NO_CAMELLIA", "OPENSSL_NO_RC4", "OPENSSL_NO_BF", "OPENSSL_NO_PSK", "OPENSSL_NO_DEPRECATED_3_0", "OPENSSL_NO_SCRYPT", "OPENSSL_NO_SM3", "OPENSSL_NO_RMD160", "OPENSSL_NO_EC2M", "OPENSSL_NO_OCSP", "OPENSSL_NO_CMS", "OPENSSL_NO_COMP", "OPENSSL_NO_SOCK", "OPENSSL_NO_STDIO", "OPENSSL_NO_EC", "OPENSSL_NO_SSL3_METHOD", "OPENSSL_NO_KRB5", "OPENSSL_NO_TLSEXT", "OPENSSL_NO_SRP", "OPENSSL_NO_RFC3779", "OPENSSL_NO_SHA", "OPENSSL_NO_NEXTPROTONEG", "OPENSSL_NO_ENGINE", "OPENSSL_NO_BUF_FREELISTS"))
cargo:rustc-check-cfg=cfg(openssl)
cargo:rustc-check-cfg=cfg(libressl)
cargo:rustc-check-cfg=cfg(boringssl)
cargo:rustc-check-cfg=cfg(libressl250)
cargo:rustc-check-cfg=cfg(libressl251)
cargo:rustc-check-cfg=cfg(libressl252)
cargo:rustc-check-cfg=cfg(libressl261)
cargo:rustc-check-cfg=cfg(libressl270)
cargo:rustc-check-cfg=cfg(libressl271)
cargo:rustc-check-cfg=cfg(libressl273)
cargo:rustc-check-cfg=cfg(libressl280)
cargo:rustc-check-cfg=cfg(libressl281)
cargo:rustc-check-cfg=cfg(libressl291)
cargo:rustc-check-cfg=cfg(libressl310)
cargo:rustc-check-cfg=cfg(libressl321)
cargo:rustc-check-cfg=cfg(libressl332)
cargo:rustc-check-cfg=cfg(libressl340)
cargo:rustc-check-cfg=cfg(libressl350)
cargo:rustc-check-cfg=cfg(libressl360)
cargo:rustc-check-cfg=cfg(libressl361)
cargo:rustc-check-cfg=cfg(libressl370)
cargo:rustc-check-cfg=cfg(libressl380)
cargo:rustc-check-cfg=cfg(libressl381)
cargo:rustc-check-cfg=cfg(libressl382)
cargo:rustc-check-cfg=cfg(libressl390)
cargo:rustc-check-cfg=cfg(libressl400)
cargo:rustc-check-cfg=cfg(ossl101)
cargo:rustc-check-cfg=cfg(ossl102)
cargo:rustc-check-cfg=cfg(ossl102f)
cargo:rustc-check-cfg=cfg(ossl102h)
cargo:rustc-check-cfg=cfg(ossl110)
cargo:rustc-check-cfg=cfg(ossl110f)
cargo:rustc-check-cfg=cfg(ossl110g)
cargo:rustc-check-cfg=cfg(ossl110h)
cargo:rustc-check-cfg=cfg(ossl111)
cargo:rustc-check-cfg=cfg(ossl111b)
cargo:rustc-check-cfg=cfg(ossl111c)
cargo:rustc-check-cfg=cfg(ossl111d)
cargo:rustc-check-cfg=cfg(ossl300)
cargo:rustc-check-cfg=cfg(ossl310)
cargo:rustc-check-cfg=cfg(ossl320)
cargo:rustc-check-cfg=cfg(ossl330)
cargo:rustc-check-cfg=cfg(ossl340)
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIR unset
cargo:rerun-if-env-changed=OPENSSL_LIB_DIR
OPENSSL_LIB_DIR unset
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_INCLUDE_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_INCLUDE_DIR unset
cargo:rerun-if-env-changed=OPENSSL_INCLUDE_DIR
OPENSSL_INCLUDE_DIR unset
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_DIR unset
cargo:rerun-if-env-changed=OPENSSL_DIR
OPENSSL_DIR unset
cargo:rerun-if-env-changed=OPENSSL_NO_PKG_CONFIG
cargo:rerun-if-env-changed=PKG_CONFIG_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG
cargo:rerun-if-env-changed=PKG_CONFIG
cargo:rerun-if-env-changed=OPENSSL_STATIC
cargo:rerun-if-env-changed=OPENSSL_DYNAMIC
cargo:rerun-if-env-changed=PKG_CONFIG_ALL_STATIC
cargo:rerun-if-env-changed=PKG_CONFIG_ALL_DYNAMIC
cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
cargo:rerun-if-env-changed=PKG_CONFIG_PATH
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
cargo:rerun-if-env-changed=OPENSSL_STATIC
cargo:rerun-if-env-changed=OPENSSL_DYNAMIC
cargo:rerun-if-env-changed=PKG_CONFIG_ALL_STATIC
cargo:rerun-if-env-changed=PKG_CONFIG_ALL_DYNAMIC
cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
cargo:rerun-if-env-changed=PKG_CONFIG_PATH
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
Could not find openssl via pkg-config:
Could not find openssl via pkg-config:
Could not run `PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 pkg-config --libs --cflags openssl`
The pkg-config command could not be found.
Most likely, you need to install a pkg-config package for your OS.
Most likely, you need to install a pkg-config package for your OS.
Try `apt install pkg-config`, or `yum install pkg-config`,
or `pkg install pkg-config`, or `apk add pkgconfig` depending on your distribution.
If you've already installed it, ensure the pkg-config command is one of the
directories in the PATH environment variable.
If you did not expect this build to link to a pre-installed system library,
If you did not expect this build to link to a pre-installed system library,
then check documentation of the openssl-sys crate for an option to
build the library from source, or disable features or dependencies
that require pkg-config.
cargo:warning=Could not find directory of OpenSSL installation, and this `-sys` crate cannot proceed without this knowledge. If OpenSSL is installed and this crate had trouble finding it, you can set the `OPENSSL_DIR` environment variable for the compilation process. See stderr section below for further information.
--- stderr
Could not find directory of OpenSSL installation, and this `-sys` crate cannot
proceed without this knowledge. If OpenSSL is installed and this crate had
trouble finding it, you can set the `OPENSSL_DIR` environment variable for the
Make sure you also have the development packages of openssl installed.
For example, `libssl-dev` on Ubuntu or `openssl-devel` on Fedora.
If you're in a situation where you think the directory *should* be found
automatically, please open a bug at https://github.com/sfackler/rust-openssl
and include information about your system as well as this message.
$HOST = x86_64-unknown-linux-gnu
$TARGET = x86_64-unknown-linux-gnu
openssl-sys = 0.9.104
It looks like you're compiling on Linux and also targeting Linux. Currently this
requires the `pkg-config` utility to find OpenSSL but unfortunately `pkg-config`
could not be found. If you have OpenSSL installed you can likely fix this by
installing `pkg-config`.
warning: build failed, waiting for other jobs to finish...
Build completed unsuccessfully in 0:00:12
+ set -e
+ set -e
+ cat /tmp/toolstate/toolstates.json
{"lld-wrapper":"test-fail","wasm-component-ld":"test-fail","rustbook":"build-fail"}
+ python3 ../x.py test --stage 2 check-tools
##[group]Building bootstrap
Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
ERROR: Tool `book` was not recorded in tool state.
ERROR: Tool `nomicon` was not recorded in tool state.
ERROR: Tool `reference` was not recorded in tool state.
ERROR: Tool `rust-by-example` was not recorded in tool state.
ERROR: Tool `edition-guide` was not recorded in tool state.
ERROR: Tool `embedded-book` was not recorded in tool state.
local time: Mon Oct 28 22:50:20 UTC 2024
network time: Mon, 28 Oct 2024 22:50:20 GMT
##[error]Process completed with exit code 1.
Post job cleanup.
The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
##[group]Building bootstrap
Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
thread 'main' panicked at src/core/builder/cargo.rs:518:9:
assertion failed: !use_snapshot || stage == 0 || self.local_rebuild
Build completed unsuccessfully in 0:00:00
+ set -e
+ cat /tmp/toolstate/toolstates.json
{"lld-wrapper":"test-fail","wasm-component-ld":"test-fail"}
{"lld-wrapper":"test-fail","wasm-component-ld":"test-fail"}
+ python3 ../x.py test --stage 2 check-tools
##[group]Building bootstrap
Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
ERROR: Tool `book` was not recorded in tool state.
ERROR: Tool `nomicon` was not recorded in tool state.
ERROR: Tool `reference` was not recorded in tool state.
ERROR: Tool `rust-by-example` was not recorded in tool state.
ERROR: Tool `edition-guide` was not recorded in tool state.
ERROR: Tool `embedded-book` was not recorded in tool state.
local time: Tue Oct 29 17:51:36 UTC 2024
network time: Tue, 29 Oct 2024 17:51:36 GMT
##[error]Process completed with exit code 1.
Post job cleanup.
Hmm, I checked out 5f5c243ca020e45cb6ee48a1f635a929eb611fd2 which doesn’t include any changes from this PR but x test --stage 2 check-tools still gives the same error.
Something strange is happening here, but I'm not sure what it is.
The job mingw-check-tidy failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
--stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#13 2.691 Building wheels for collected packages: reuse
#13 2.692 Building wheel for reuse (pyproject.toml): started
#13 2.937 Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 2.938 Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=026f3bb0f1aa8090b861fd0a0939cb1a782396d84c8aab7875096557d637a0f6
#13 2.938 Stored in directory: /tmp/pip-ephem-wheel-cache-mr3p9q_i/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#13 2.941 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#13 3.341 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#13 3.341 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 3.872 Collecting virtualenv
#13 3.872 Collecting virtualenv
#13 3.921 Downloading virtualenv-20.27.1-py3-none-any.whl (3.1 MB)
#13 3.983 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.1/3.1 MB 52.2 MB/s eta 0:00:00
#13 4.020 Collecting distlib<1,>=0.3.7
#13 4.034 Downloading distlib-0.3.9-py2.py3-none-any.whl (468 kB)
#13 4.041 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 82.5 MB/s eta 0:00:00
#13 4.074 Collecting platformdirs<5,>=3.9.1
#13 4.101 Downloading platformdirs-4.3.6-py3-none-any.whl (18 kB)
#13 4.174 Collecting filelock<4,>=3.12.2
#13 4.201 Downloading filelock-3.16.1-py3-none-any.whl (16 kB)
#13 4.284 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 4.460 Successfully installed distlib-0.3.9 filelock-3.16.1 platformdirs-4.3.6 virtualenv-20.27.1
#13 DONE 4.5s
#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
DirectMap4k: 165824 kB
DirectMap2M: 6125568 kB
DirectMap1G: 12582912 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
downloading https://static.rust-lang.org/dist/2024-10-16/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/2024-10-16/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt
---
Diff in /checkout/src/bootstrap/src/core/build_steps/test.rs:17:
use crate::core::build_steps::toolstate::ToolState;
use crate::core::build_steps::{compile, dist, llvm};
use crate::core::builder::{
- self, crate_description, Alias, Builder, Compiler, Kind, RunConfig, ShouldRun, Step,
+ self, Alias, Builder, Compiler, Kind, RunConfig, ShouldRun, Step, crate_description,
-use crate::core::config::flags::{get_completion, Subcommand};
use crate::core::config::TargetSelection;
-use crate::utils::exec::{command, BootstrapCommand};
+use crate::core::config::flags::{Subcommand, get_completion};
+use crate::core::config::flags::{Subcommand, get_completion};
+use crate::utils::exec::{BootstrapCommand, command};
use crate::utils::helpers::{
- self, add_link_lib_path, add_rustdoc_cargo_linker_args, dylib_path, dylib_path_var,
- linker_args, linker_flags, t, target_supports_cranelift_backend, up_to_date, LldThreads,
+ self, LldThreads, add_link_lib_path, add_rustdoc_cargo_linker_args, dylib_path, dylib_path_var,
+ linker_args, linker_flags, t, target_supports_cranelift_backend, up_to_date,
use crate::utils::render_tests::{add_flags_and_try_run_tests, try_run_tests};
use crate::utils::render_tests::{add_flags_and_try_run_tests, try_run_tests};
-use crate::{envify, CLang, DocTests, GitRepo, Mode};
+use crate::{CLang, DocTests, GitRepo, Mode, envify};
const ADB_TEST_DIR: &str = "/data/local/tmp/work";
Diff in /checkout/src/bootstrap/src/core/build_steps/test.rs:1077:
crate::exit!(1);
}
let all = false;
let all = false;
- crate::core::build_steps::format::format(
- builder,
- !builder.config.cmd.bless(),
- &[],
- );
- );
+ crate::core::build_steps::format::format(builder, !builder.config.cmd.bless(), all, &[
}
builder.info("tidy check");
Diff in /checkout/src/bootstrap/src/core/build_steps/test.rs:1810:
Diff in /checkout/src/bootstrap/src/core/build_steps/test.rs:1810:
cmd.arg("--force-rerun");
- let compare_mode = builder.config.cmd.compare_mode().or_else(|| {
- self.compare_mode
- } else {
- None
- }
- }
- });
+ let compare_mode =
+ builder.config.cmd.compare_mode().or_else(|| {
+ if builder.config.test_compare_mode { self.compare_mode } else { None }
if let Some(ref pass) = builder.config.cmd.pass() {
cmd.arg("--pass");
Diff in /checkout/src/bootstrap/src/core/build_steps/test.rs:3531:
let compiler = self.compiler;
- builder.ensure(compile::Std::new_with_extra_rust_args(
- compiler,
- target,
- target,
- &["-Csymbol-mangling-version=v0", "-Cpanic=abort"],
- ));
+ builder.ensure(compile::Std::new_with_extra_rust_args(compiler, target, &[
+ "-Csymbol-mangling-version=v0",
+ "-Cpanic=abort",
+ ]));
// If we're not doing a full bootstrap but we're testing a stage2
// version of libstd, then what we're actually testing is the libstd
// version of libstd, then what we're actually testing is the libstd
fmt error: Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt/bin/rustfmt" "--config-path" "/checkout" "--edition" "2021" "--unstable-features" "--skip-children" "--check" "/checkout/src/bootstrap/src/core/build_steps/vendor.rs" "/checkout/tests/run-make/apple-sdk-version/foo.rs" "/checkout/src/bootstrap/src/core/build_steps/synthetic_targets.rs" "/checkout/src/bootstrap/src/core/build_steps/clippy.rs" "/checkout/src/bootstrap/src/core/build_steps/gcc.rs" "/checkout/src/bootstrap/src/core/build_steps/toolstate.rs" "/checkout/src/bootstrap/src/core/build_steps/doc.rs" "/checkout/src/bootstrap/src/core/build_steps/perf.rs" "/checkout/src/bootstrap/src/core/build_steps/tool.rs" "/checkout/src/bootstrap/src/core/build_steps/compile.rs" "/checkout/src/bootstrap/src/core/build_steps/format.rs" "/checkout/src/bootstrap/src/core/build_steps/install.rs" "/checkout/src/bootstrap/src/core/build_steps/clean.rs" "/checkout/src/bootstrap/src/core/build_steps/run.rs" "/checkout/src/bootstrap/src/core/build_steps/llvm.rs" "/checkout/src/bootstrap/src/core/build_steps/setup/tests.rs" "/checkout/src/bootstrap/src/core/build_steps/dist.rs" "/checkout/src/bootstrap/src/core/build_steps/setup.rs" "/checkout/src/bootstrap/src/core/build_steps/test.rs" "/checkout/src/bootstrap/src/core/build_steps/suggest.rs" "/checkout/src/bootstrap/src/core/build_steps/check.rs" "/checkout/src/bootstrap/src/core/build_steps/mod.rs" "/checkout/tests/run-make/emit/rmake.rs" "/checkout/tests/run-make/emit/test-26235.rs" "/checkout/tests/run-make/emit/test-24876.rs" "/checkout/tests/run-make/ice-static-mir/rmake.rs" "/checkout/tests/run-make/ice-static-mir/baz.rs" "/checkout/tests/run-make/ice-static-mir/foo.rs" "/checkout/tests/run-make/ice-static-mir/bar.rs" "/checkout/src/bootstrap/src/core/config/flags.rs" "/checkout/src/bootstrap/src/core/config/config.rs" "/checkout/src/bootstrap/src/core/config/tests.rs" "/checkout/src/bootstrap/src/core/config/mod.rs" "/checkout/src/bootstrap/src/core/mod.rs" "/checkout/tests/run-make/link-path-order/main.rs" "/checkout/tests/run-make/link-path-order/rmake.rs" "/checkout/tests/run-make/arguments-non-c-like-enum/rmake.rs" "/checkout/tests/run-make/arguments-non-c-like-enum/nonclike.rs" "/checkout/tests/run-make/compressed-debuginfo-zstd/main.rs" "/checkout/tests/run-make/compressed-debuginfo-zstd/rmake.rs" "/checkout/tests/run-make/no-builtins-attribute/main.rs" "/checkout/tests/run-make/no-builtins-attribute/rmake.rs" "/checkout/tests/run-make/no-builtins-attribute/no_builtins.rs" "/checkout/tests/run-make/split-debuginfo/main.rs" "/checkout/tests/run-make/split-debuginfo/baz.rs" "/checkout/tests/run-make/split-debuginfo/foo.rs" "/checkout/tests/run-make/split-debuginfo/bar.rs" "/checkout/tests/run-make/reproducible-build/reproducible-build.rs" "/checkout/tests/run-make/reproducible-build/reproducible-build-aux.rs" "/checkout/tests/run-make/reproducible-build/rmake.rs" "/checkout/tests/run-make/reproducible-build/linker.rs" "/checkout/tests/run-make/windows-spawn/rmake.rs" "/checkout/tests/run-make/windows-spawn/hello.rs" "/checkout/tests/run-make/windows-spawn/spawn.rs" "/checkout/tests/run-make/dep-graph/rmake.rs" "/checkout/tests/run-make/dep-graph/foo.rs" "/checkout/tests/run-make/crate-name-priority/rmake.rs" "/checkout/tests/run-make/crate-name-priority/foo1.rs" "/checkout/tests/run-make/crate-name-priority/foo.rs" "/checkout/tests/run-make/debugger-visualizer-dep-info/main.rs" "/checkout/tests/run-make/debugger-visualizer-dep-info/rmake.rs" "/checkout/tests/run-make/optimization-remarks-dir-pgo/rmake.rs" "/checkout/tests/run-make/optimization-remarks-dir-pgo/foo.rs" "/checkout/tests/run-make/apple-sdk-version/rmake.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
local time: Tue Oct 29 21:43:56 UTC 2024
network time: Tue, 29 Oct 2024 21:43:57 GMT
##[error]Process completed with exit code 1.
Post job cleanup.
The job mingw-check-tidy failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
--stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#13 3.407 Building wheels for collected packages: reuse
#13 3.408 Building wheel for reuse (pyproject.toml): started
#13 3.659 Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 3.660 Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=026f3bb0f1aa8090b861fd0a0939cb1a782396d84c8aab7875096557d637a0f6
#13 3.660 Stored in directory: /tmp/pip-ephem-wheel-cache-5wwxsrh5/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#13 3.663 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#13 4.056 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#13 4.056 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 4.579 Collecting virtualenv
#13 4.579 Collecting virtualenv
#13 4.668 Downloading virtualenv-20.27.1-py3-none-any.whl (3.1 MB)
#13 4.793 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.1/3.1 MB 25.2 MB/s eta 0:00:00
#13 4.846 Collecting platformdirs<5,>=3.9.1
#13 4.865 Downloading platformdirs-4.3.6-py3-none-any.whl (18 kB)
#13 4.884 Collecting distlib<1,>=0.3.7
#13 4.911 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 77.9 MB/s eta 0:00:00
#13 4.945 Collecting filelock<4,>=3.12.2
#13 4.965 Downloading filelock-3.16.1-py3-none-any.whl (16 kB)
#13 4.965 Downloading filelock-3.16.1-py3-none-any.whl (16 kB)
#13 5.046 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 5.220 Successfully installed distlib-0.3.9 filelock-3.16.1 platformdirs-4.3.6 virtualenv-20.27.1
#13 DONE 5.3s
#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
DirectMap4k: 184256 kB
DirectMap2M: 9252864 kB
DirectMap1G: 9437184 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
downloading https://static.rust-lang.org/dist/2024-10-16/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/2024-10-16/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt
---
##[endgroup]
fmt check
fmt: checked 5641 files
tidy check
tidy error: could not find exception package `cssparser`
Remove from EXCEPTIONS list if it is no longer used.
tidy error: could not find exception package `cssparser-macros`
Remove from EXCEPTIONS list if it is no longer used.
tidy error: could not find exception package `dtoa-short`
Remove from EXCEPTIONS list if it is no longer used.
tidy error: could not find exception package `encoding_rs`
Remove from EXCEPTIONS list if it is no longer used.
tidy error: could not find exception package `ring`
Remove from EXCEPTIONS list if it is no longer used.
tidy error: could not find exception package `selectors`
Remove from EXCEPTIONS list if it is no longer used.
tidy error: could not find exception package `subtle`
Remove from EXCEPTIONS list if it is no longer used.
removing old virtual environment
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10'
Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (24.3.1)
All checks passed!
checking C++ file formatting
some tidy checks failed
some tidy checks failed
Command has failed. Rerun with -v to see more details.
local time: Tue Oct 29 22:04:36 UTC 2024
network time: Tue, 29 Oct 2024 22:04:36 GMT
##[error]Process completed with exit code 1.
Post job cleanup.
The job x86_64-gnu-llvm-18 failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
------
> importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:c32c805632780b5c1de330e3f44561b336c2efe163bc0990acb392390157a8e1d9f855d75914a239aa40c49d77f4a837247d05d2f8d46f554b98e1f46712a3e3:
------
##[endgroup]
Setting extra environment values for docker: --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure:
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
---- [ui] tests/ui/parser/bad-name.rs stdout ----
Saved the actual stderr to "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/bad-name/bad-name.stderr"
diff of stderr:
10 LL | let x.y::<isize>.z foo;
12 |
12 |
- = note: arbitrary expressions are not allowed in patterns: <https://doc.rust-lang.org/book/19-00-patterns.html>
+ = note: arbitrary expressions are not allowed in patterns: <https://doc.rust-lang.org/book/ch19-00-patterns.html>
14
15 error: expected one of `(`, `.`, `::`, `:`, `;`, `=`, `?`, `|`, or an operator, found `foo`
The actual stderr differed from the expected stderr.
To update references, rerun the tests and pass the `--bless` flag
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args parser/bad-name.rs`
error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/parser/bad-name.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/bad-name" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
--- stderr -------------------------------
error: field expressions cannot have generic arguments
##[error] --> /checkout/tests/ui/parser/bad-name.rs:2:12
|
|
LL | let x.y::<isize>.z foo;
error: expected a pattern, found an expression
##[error] --> /checkout/tests/ui/parser/bad-name.rs:2:7
|
|
LL | let x.y::<isize>.z foo;
|
= note: arbitrary expressions are not allowed in patterns: <https://doc.rust-lang.org/book/ch19-00-patterns.html>
error: expected one of `(`, `.`, `::`, `:`, `;`, `=`, `?`, `|`, or an operator, found `foo`
|
|
LL | let x.y::<isize>.z foo;
error: aborting due to 3 previous errors
------------------------------------------
The job x86_64-gnu-llvm-18 failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
------
> importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:c32c805632780b5c1de330e3f44561b336c2efe163bc0990acb392390157a8e1d9f855d75914a239aa40c49d77f4a837247d05d2f8d46f554b98e1f46712a3e3:
------
##[endgroup]
Setting extra environment values for docker: --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure:
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
Downloaded boml v0.3.1
Compiling boml v0.3.1
Compiling y v0.1.0 (/checkout/compiler/rustc_codegen_gcc/build_system)
Finished `release` profile [optimized] target(s) in 3.95s
Running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-codegen/x86_64-unknown-linux-gnu/release/y test --use-system-gcc --use-backend gcc --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc --release --mini-tests --std-tests`
Using system GCC
[BUILD] example
[AOT] mini_core_hello_world
/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc/mini_core_hello_world
abc
---
##[group]Building stage0 tool linkchecker (x86_64-unknown-linux-gnu)
Finished `release` profile [optimized] target(s) in 0.14s
##[endgroup]
##[group]Testing stage0 Linkcheck (x86_64-unknown-linux-gnu)
book/2018-edition/print.html:719: broken link - `book/ch19-03-oo-design-patterns.html`
book/2018-edition/ch17-03-oo-design-patterns.html:179: broken link - `book/ch19-03-oo-design-patterns.html`
NOTE: if you are adding or renaming a markdown file in a mdBook, don't forget to register the page in SUMMARY.md
number of HTML files scanned: 43952
number of HTML redirects found: 13764
number of links checked: 3295060
number of links ignored due to external: 83604
number of links ignored due to external: 83604
number of links ignored due to exceptions: 17
number of intra doc links ignored: 8
errors found: 2
found some broken links
Command has failed. Rerun with -v to see more details.
local time: Wed Oct 30 22:24:26 UTC 2024
network time: Wed, 30 Oct 2024 22:24:26 GMT
##[error]Process completed with exit code 1.
Post job cleanup.
The job x86_64-gnu-llvm-18 failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
------
> importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:c32c805632780b5c1de330e3f44561b336c2efe163bc0990acb392390157a8e1d9f855d75914a239aa40c49d77f4a837247d05d2f8d46f554b98e1f46712a3e3:
------
##[endgroup]
Setting extra environment values for docker: --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure:
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
Downloaded boml v0.3.1
Compiling boml v0.3.1
Compiling y v0.1.0 (/checkout/compiler/rustc_codegen_gcc/build_system)
Finished `release` profile [optimized] target(s) in 3.72s
Running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-codegen/x86_64-unknown-linux-gnu/release/y test --use-system-gcc --use-backend gcc --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc --release --mini-tests --std-tests`
Using system GCC
[BUILD] example
[AOT] mini_core_hello_world
/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc/mini_core_hello_world
abc
---
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s
Command CFG_RELEASE_CHANNEL="nightly" RUSTC_BOOTSTRAP="1" RUSTC_STAGE="0" RUSTC_SYSROOT="/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-sysroot" RUSTDOC_LIBDIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" RUSTDOC_REAL="/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustdoc" RUST_TEST_THREADS="16" "/checkout/obj/build/bootstrap/debug/rustdoc" "-Wrustdoc::invalid_codeblock_attributes" "-Dwarnings" "-Znormalize-docs" "-Z" "unstable-options" "--test" "/checkout/src/doc/unstable-book/src/language-features/strict-provenance-lints.md" "--test-args" "" (failure_mode=DelayFail) has failed. Rerun with -v to see more details.
local time: Thu Oct 31 00:09:10 UTC 2024
network time: Thu, 31 Oct 2024 00:09:10 GMT
##[error]Process completed with exit code 1.
Post job cleanup.
Thanks, @onur-ozkan! @cjgillot, I think this is ready for your eyes when you get a bit!