rust icon indicating copy to clipboard operation
rust copied to clipboard

Add missing `needs-llvm-components` directives for run-make tests that need target-specific codegen

Open jieyouxu opened this issue 1 year ago • 3 comments

Without suitable needs-llvm-components directives, some run-make tests exercising target-specific codegen can fail if the LLVM used is built without the necessary components. Currently, the list is:

tests\run-make\print-target-list
tests\run-make\print-to-output
tests\run-make\print-cfg
tests\run-make\target-without-atomic-cas

This PR also skips tidy checks for revisions and needs-llvm-components for run-make tests since revisions are not supported.

Fixes #129390.

cc @petrochenkov who noticed this, thanks! Would be great if you could confirm that this fixes the test errors for you locally.

jieyouxu avatar Aug 26 '24 10:08 jieyouxu

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Aug 26 '24 10:08 rustbot

Would be great if you could confirm that this fixes the test errors for you locally.

I confirm, there are no errors in run-make tests on my setup with this change.

petrochenkov avatar Aug 26 '24 12:08 petrochenkov

Thanks!

jieyouxu avatar Aug 26 '24 12:08 jieyouxu

@bors r+

Mark-Simulacrum avatar Aug 31 '24 12:08 Mark-Simulacrum

:pushpin: Commit beaf9d1c14122a55d71717560162c8123f5f23ea has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors avatar Aug 31 '24 12:08 bors