rust
rust copied to clipboard
rust-lang
Weekly `cargo update`
Automation to keep dependencies in Cargo.lock current.
The following is the output from cargo update:
Locking 33 packages to latest compatible versions
Adding adler2 v2.0.0
Updating cc v1.1.13 -> v1.1.14
Updating clap_complete v4.5.18 -> v4.5.23
Updating fastrand v2.1.0 -> v2.1.1
Updating flate2 v1.0.31 -> v1.0.33
Updating libc v0.2.157 -> v0.2.158
Updating libz-sys v1.1.19 -> v1.1.20
Updating minifier v0.3.0 -> v0.3.1
Adding miniz_oxide v0.8.0
Updating quote v1.0.36 -> v1.0.37
Updating redox_users v0.4.5 -> v0.4.6
Updating rinja v0.3.0 -> v0.3.1
Updating rinja_derive v0.3.0 -> v0.3.1
Updating rinja_parser v0.3.0 -> v0.3.1
Adding rustc-hash v2.0.0
Updating ruzstd v0.7.0 -> v0.7.1
Updating serde v1.0.208 -> v1.0.209
Updating serde_derive v1.0.208 -> v1.0.209
Updating serde_json v1.0.125 -> v1.0.127
Updating stacker v0.1.15 -> v0.1.16
Updating syn v2.0.75 -> v2.0.76
Updating sysinfo v0.31.2 -> v0.31.3
Updating unicode-properties v0.1.1 -> v0.1.2
Updating unicode-xid v0.2.4 -> v0.2.5
Adding wasm-encoder v0.216.0
Updating wast v215.0.0 -> v216.0.0
Updating wat v1.215.0 -> v1.216.0
Adding windows-sys v0.36.1 (latest: v0.59.0)
Adding windows_aarch64_msvc v0.36.1 (latest: v0.52.6)
Adding windows_i686_gnu v0.36.1 (latest: v0.52.6)
Adding windows_i686_msvc v0.36.1 (latest: v0.52.6)
Adding windows_x86_64_gnu v0.36.1 (latest: v0.52.6)
Adding windows_x86_64_msvc v0.36.1 (latest: v0.52.6)
note: pass `--verbose` to see 93 unchanged dependencies behind latest
library dependencies:
Locking 16 packages to latest compatible versions
Updating cc v1.0.99 -> v1.1.14
Updating compiler_builtins v0.1.120 -> v0.1.121
Updating gimli v0.28.1 -> v0.30.0 (latest: v0.31.0)
Updating memchr v2.5.0 -> v2.7.4
Updating object v0.36.2 -> v0.36.3
Adding shlex v1.3.0
Updating unwinding v0.2.1 -> v0.2.2
Updating windows-targets v0.52.5 -> v0.52.6
Updating windows_aarch64_gnullvm v0.52.5 -> v0.52.6
Updating windows_aarch64_msvc v0.52.5 -> v0.52.6
Updating windows_i686_gnu v0.52.5 -> v0.52.6
Updating windows_i686_gnullvm v0.52.5 -> v0.52.6
Updating windows_i686_msvc v0.52.5 -> v0.52.6
Updating windows_x86_64_gnu v0.52.5 -> v0.52.6
Updating windows_x86_64_gnullvm v0.52.5 -> v0.52.6
Updating windows_x86_64_msvc v0.52.5 -> v0.52.6
note: pass `--verbose` to see 6 unchanged dependencies behind latest
rustbook dependencies:
Locking 59 packages to latest compatible versions
Removing adler v1.0.2
Adding adler2 v2.0.0
Updating anstream v0.6.14 -> v0.6.15
Updating anstyle v1.0.7 -> v1.0.8
Updating anstyle-parse v0.2.4 -> v0.2.5
Updating anstyle-query v1.1.0 -> v1.1.1
Updating anstyle-wincon v3.0.3 -> v3.0.4
Removing base64 v0.22.1
Updating bstr v1.9.1 -> v1.10.0
Adding byteorder v1.5.0
Updating cc v1.1.5 -> v1.1.14
Updating clap v4.5.9 -> v4.5.16
Updating clap_builder v4.5.9 -> v4.5.15
Updating clap_complete v4.5.8 -> v4.5.23
Updating clap_derive v4.5.8 -> v4.5.13
Updating clap_lex v0.7.1 -> v0.7.2
Updating colorchoice v1.0.1 -> v1.0.2
Updating core-foundation-sys v0.8.6 -> v0.8.7
Updating cpufeatures v0.2.12 -> v0.2.13
Adding dateparser v0.2.1
Removing deranged v0.3.11
Updating env_filter v0.1.0 -> v0.1.2
Updating env_logger v0.11.3 -> v0.11.5
Updating fastrand v2.1.0 -> v2.1.1
Updating flate2 v1.0.30 -> v1.0.33
Updating indexmap v2.2.6 -> v2.4.0
Updating is_terminal_polyfill v1.70.0 -> v1.70.1
Updating js-sys v0.3.69 -> v0.3.70
Adding lazy_static v1.5.0
Updating libc v0.2.155 -> v0.2.158
Removing linked-hash-map v0.5.6
Updating mdbook-i18n-helpers v0.3.4 -> v0.3.5
Updating miniz_oxide v0.7.4 -> v0.8.0
Updating normpath v1.2.0 -> v1.3.0
Removing num-conv v0.1.0
Updating opener v0.7.1 -> v0.7.2
Removing plist v1.7.0
Removing powerfmt v0.2.0
Updating ppv-lite86 v0.2.17 -> v0.2.20
Adding pulldown-cmark v0.11.2 (latest: v0.12.0)
Adding pulldown-cmark-escape v0.11.0
Adding pulldown-cmark-to-cmark v15.0.1 (latest: v16.0.1)
Removing quick-xml v0.32.0
Updating quote v1.0.36 -> v1.0.37
Updating regex v1.10.5 -> v1.10.6
Updating serde v1.0.204 -> v1.0.209
Updating serde_derive v1.0.204 -> v1.0.209
Updating serde_json v1.0.120 -> v1.0.127
Updating serde_spanned v0.6.6 -> v0.6.7
Updating syn v2.0.71 -> v2.0.76
Updating tempfile v3.10.1 -> v3.12.0
Updating thiserror v1.0.62 -> v1.0.63
Updating thiserror-impl v1.0.62 -> v1.0.63
Removing time v0.3.36
Removing time-core v0.1.2
Removing time-macros v0.2.18
Updating toml v0.8.14 -> v0.8.19
Updating toml_datetime v0.6.6 -> v0.6.8
Updating toml_edit v0.22.15 -> v0.22.20
Updating version_check v0.9.4 -> v0.9.5
Updating wasm-bindgen v0.2.92 -> v0.2.93
Updating wasm-bindgen-backend v0.2.92 -> v0.2.93
Updating wasm-bindgen-macro v0.2.92 -> v0.2.93
Updating wasm-bindgen-macro-support v0.2.92 -> v0.2.93
Updating wasm-bindgen-shared v0.2.92 -> v0.2.93
Updating winapi-util v0.1.8 -> v0.1.9
Adding windows-sys v0.59.0
Updating winnow v0.6.13 -> v0.6.18
Removing yaml-rust v0.4.5
Adding zerocopy v0.7.35
Adding zerocopy-derive v0.7.35
note: pass `--verbose` to see 26 unchanged dependencies behind latest
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) some time within the next two weeks.
Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:
@rustbot author: the review is finished, PR author should check the comments and take action accordingly@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
If this was unintentional then you should revert the changes before this PR is merged. Otherwise, you can ignore this comment.
These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.
If this was unintentional then you should revert the changes before this PR is merged. Otherwise, you can ignore this comment.
The job mingw-check-tidy failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
--stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#13 2.637 Building wheels for collected packages: reuse
#13 2.638 Building wheel for reuse (pyproject.toml): started
#13 2.884 Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 2.885 Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132715 sha256=dfa09868353292d98f811d3efdb0d54d07389e808efc71d68e3b93c514bf8bec
#13 2.885 Stored in directory: /tmp/pip-ephem-wheel-cache-27b7gq94/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#13 2.888 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#13 3.283 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#13 3.283 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 3.796 Collecting virtualenv
#13 3.796 Collecting virtualenv
#13 3.836 Downloading virtualenv-20.26.3-py3-none-any.whl (5.7 MB)
#13 3.911 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.7/5.7 MB 77.7 MB/s eta 0:00:00
#13 3.968 Collecting filelock<4,>=3.12.2
#13 3.971 Downloading filelock-3.15.4-py3-none-any.whl (16 kB)
#13 3.987 Collecting distlib<1,>=0.3.7
#13 3.990 Downloading distlib-0.3.8-py2.py3-none-any.whl (468 kB)
#13 3.997 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 468.9/468.9 KB 92.0 MB/s eta 0:00:00
#13 4.026 Collecting platformdirs<5,>=3.9.1
#13 4.029 Downloading platformdirs-4.2.2-py3-none-any.whl (18 kB)
#13 4.109 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 4.297 Successfully installed distlib-0.3.8 filelock-3.15.4 platformdirs-4.2.2 virtualenv-20.26.3
#13 DONE 4.4s
#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
DirectMap4k: 208832 kB
DirectMap2M: 8179712 kB
DirectMap1G: 10485760 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
downloading https://ci-artifacts.rust-lang.org/rustc-builds-alt/f167efad2f51088d86180ee89177b3d7c9e7c2f5/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/llvm-f167efad2f51088d86180ee89177b3d7c9e7c2f5-true/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm
---
##[endgroup]
fmt check
fmt: checked 5511 files
tidy check
tidy error: could not find allowed package `adler`
Remove from PERMITTED_DEPENDENCIES list if it is no longer used.
tidy error: Dependency for . not explicitly permitted: registry+https://github.com/rust-lang/crates.io-index#[email protected]
Go to `src/tools/tidy/src/deps.rs:237` for the list.
Go to `src/tools/tidy/src/deps.rs:237` for the list.
tidy error: Dependency for library not explicitly permitted: registry+https://github.com/rust-lang/crates.io-index#[email protected]
removing old virtual environment
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10'
Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (24.1)
Downloading pip-24.2-py3-none-any.whl.metadata (3.6 kB)
Downloading pip-24.2-py3-none-any.whl (1.8 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.8/1.8 MB 68.7 MB/s eta 0:00:00
Installing collected packages: pip
---
Successfully installed pip-24.2
linting python files
All checks passed!
checking C++ file formatting
some tidy checks failed
Command has failed. Rerun with -v to see more details.
local time: Sun Aug 25 01:56:32 UTC 2024
network time: Sun, 25 Aug 2024 01:56:32 GMT
##[error]Process completed with exit code 1.
Post job cleanup.
:umbrella: The latest upstream changes (presumably #129521) made this pull request unmergeable. Please resolve the merge conflicts.
I wonder if we should just enable these updates via dependabot since you can request it to redo them or rebase - I don't know what the recourse is here when a conflict happens.
Hmm, something tells me the memchr update ain't gonna go well :)
It looks normal enough... what's wrong with it?
The PR is automatically rebased ~weekly, so I don't think there's any need to switch to dependabot. IIRC, we wanted to avoid the branches that creates (and I think we had some other problem with it, though I'm not remembering the details now).
It looks normal enough... what's wrong with it?
https://github.com/rust-lang/rust/issues/127890 (not sure if it's a problem for all the workspaces though)
Ugh, the auto-assignment is always going to tag me, but I don't want to be responsible for managing these updates. I'll assign to Mark, but if someone else wants to take these on, feel free.
r? Mark-Simulacrum
Someone is likely going to need to add an = pin on memchr before this can move forward. The pin in https://github.com/rust-lang/rust/blob/22572d0994593197593e2a1b7b18d720a9a349a7/compiler/rustc_ast/Cargo.toml#L10 should also probably be removed.
Someone is likely going to need to add an
=pin on memchr before this can move forward. The pin inhttps://github.com/rust-lang/rust/blob/22572d0994593197593e2a1b7b18d720a9a349a7/compiler/rustc_ast/Cargo.toml#L10
should also probably be removed.
rustc_ast is the crate mentioned in https://github.com/rust-lang/rust/issues/127890. Why should ast have the pin removed but added back in another crate?
See the explanation in #127890 (specifically, this is an LTO problem for x86_64-pc-windows-gnu). The pin was placed in rustc_ast presumably as a convenience, but the real problem is with the standard library's use of memchr. Since the workspaces were split in #128534, that pin needs to move to the standard library. I would recommend sticking it in std's Cargo.toml, under the same target restrictions as object (since that is where memchr is used).
:umbrella: The latest upstream changes (presumably #129922) made this pull request unmergeable. Please resolve the merge conflicts.
We haven't been able to update all of these at once, so updates are spread across a couple PRs at this time. See https://github.com/rust-lang/rust/pull/129624#issuecomment-2377595027.
:umbrella: The latest upstream changes (presumably #129624) made this pull request unmergeable. Please resolve the merge conflicts.
All the comments here have been addressed and most of this merged, I'll close this so we get a fresh PR tomorrow.