rust icon indicating copy to clipboard operation
rust copied to clipboard

Add test to build crates used by r-a on stable

Open lqd opened this issue 1 year ago • 3 comments

r? @Kobzol

This integrates #129526 until it lands, and I cherry-picked your commit, and added the last remaining pieces we needed I think.

Draft to discuss if need be.

lqd avatar Aug 24 '24 21:08 lqd

Could not assign reviewer from: Kobzol. User(s) Kobzol are either the PR author, already assigned, or on vacation, and there are no other candidates. Use r? to specify someone else to assign.

rustbot avatar Aug 24 '24 21:08 rustbot

r? @jieyouxu

rustbot has assigned @jieyouxu. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Aug 24 '24 21:08 rustbot

I've also removed the cargo nightly feature / RUSTC_BOOTSTRAP

lqd avatar Aug 25 '24 11:08 lqd

All the prerequisite PRs have landed.

lqd avatar Aug 27 '24 17:08 lqd

This PR modifies tests/run-make/. If this PR is trying to port a Makefile run-make test to use rmake.rs, please update the run-make port tracking issue so we can track our progress. You can either modify the tracking issue directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

The run-make-support library was changed

cc @jieyouxu

rustbot avatar Aug 27 '24 17:08 rustbot

Thanks! You can r=me once CI is green.

Kobzol avatar Sep 02 '24 09:09 Kobzol

@bors r+

Kobzol avatar Sep 02 '24 12:09 Kobzol

:pushpin: Commit a178559a03a11b5f6e716045e1b486ca29b2d543 has been approved by Kobzol

It is now in the queue for this repository.

bors avatar Sep 02 '24 12:09 bors

A very late thanks for this test btw :)

Veykril avatar Oct 22 '24 06:10 Veykril