rust Do not call source_span when not tracking dependencies.

Split from https://github.com/rust-lang/rust/pull/127241

Aug 24 '24 16:08 cjgillot

r? @compiler-errors

rustbot has assigned @compiler-errors. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Aug 24 '24 16:08 rustbot

@bors try @rust-timer queue

Aug 24 '24 23:08 petrochenkov

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

Aug 24 '24 23:08 rust-timer

:hourglass: Trying commit bb17fda3845bda0da7bcdcf28cd17e4823e58c9d with merge c09d9f8ba914677996613f7a2d3c9284db39737b...

Aug 24 '24 23:08 bors

:sunny: Try build successful - checks-actions Build commit: c09d9f8ba914677996613f7a2d3c9284db39737b (c09d9f8ba914677996613f7a2d3c9284db39737b)

Aug 25 '24 01:08 bors

Queued c09d9f8ba914677996613f7a2d3c9284db39737b with parent f167efad2f51088d86180ee89177b3d7c9e7c2f5, future comparison URL. There is currently 1 preceding artifact in the queue. It will probably take at least ~1.7 hours until the benchmark run finishes.

Aug 25 '24 01:08 rust-timer

Finished benchmarking commit (c09d9f8ba914677996613f7a2d3c9284db39737b): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never @rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.2%]	24
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.2%]	4
All ❌✅ (primary)	-0.3%	[-0.4%, -0.2%]	24

Max RSS (memory usage)

Results (primary -1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.0%	[-1.0%, -1.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.0%	[-1.0%, -1.0%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 750.904s -> 750.776s (-0.02%) Artifact size: 338.92 MiB -> 338.88 MiB (-0.01%)

Aug 25 '24 02:08 rust-timer

r? @petrochenkov @bors r+

Aug 25 '24 10:08 petrochenkov

:pushpin: Commit bb17fda3845bda0da7bcdcf28cd17e4823e58c9d has been approved by petrochenkov

It is now in the queue for this repository.

Aug 25 '24 10:08 bors

:hourglass: Testing commit bb17fda3845bda0da7bcdcf28cd17e4823e58c9d with merge 42fadbde2643369b9d71a8a093cb87972d39ddd6...

Aug 26 '24 11:08 bors

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] miri test:false 4.547
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe`

Caused by:
  Access is denied. (os error 5)
Command has failed. Rerun with -v to see more details.
  local time: Mon, Aug 26, 2024 12:55:27 PM
  network time: Mon, 26 Aug 2024 12:55:27 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

Aug 26 '24 12:08 rust-log-analyzer

:broken_heart: Test failed - checks-actions

Aug 26 '24 12:08 bors

@bors retry

Aug 26 '24 15:08 petrochenkov

:hourglass: Testing commit bb17fda3845bda0da7bcdcf28cd17e4823e58c9d with merge 92602c4b66af7a56e946002c855395d6aea38a07...

Aug 26 '24 22:08 bors

:hourglass: Testing commit bb17fda3845bda0da7bcdcf28cd17e4823e58c9d with merge 48412cca291557522b18fa599a3a52e28a1d66f0...

Aug 26 '24 22:08 bors

:broken_heart: Test failed - checks-actions

Aug 26 '24 22:08 bors

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Aug 26 '24 22:08 rust-log-analyzer

@bors retry

Aug 27 '24 00:08 cjgillot

:hourglass: Testing commit bb17fda3845bda0da7bcdcf28cd17e4823e58c9d with merge a9221972a813c98741ca8824798cebbadc19a2da...

Aug 27 '24 03:08 bors

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] miri test:false 4.505
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe`

Caused by:
  Access is denied. (os error 5)
Command has failed. Rerun with -v to see more details.
  local time: Tue, Aug 27, 2024  4:52:55 AM
  network time: Tue, 27 Aug 2024 04:52:56 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

Aug 27 '24 04:08 rust-log-analyzer

:broken_heart: Test failed - checks-actions

Aug 27 '24 04:08 bors

@bors retry https://github.com/rust-lang/rust/issues/127883

Aug 27 '24 04:08 tgross35

:hourglass: Testing commit bb17fda3845bda0da7bcdcf28cd17e4823e58c9d with merge 64b0ee67656f7b71f664369cd9fb328f93936b6b...

Aug 27 '24 09:08 bors

The job i686-gnu-nopt failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Aug 27 '24 10:08 rust-log-analyzer

:broken_heart: Test failed - checks-actions

Aug 27 '24 10:08 bors

@bors retry

Aug 27 '24 13:08 cjgillot

:hourglass: Testing commit bb17fda3845bda0da7bcdcf28cd17e4823e58c9d with merge ab869e094a907cc5d19b4080f22eccaf347f1f95...

Aug 27 '24 18:08 bors

:sunny: Test successful - checks-actions Approved by: petrochenkov Pushing ab869e094a907cc5d19b4080f22eccaf347f1f95 to master...

Aug 27 '24 20:08 bors

Finished benchmarking commit (ab869e094a907cc5d19b4080f22eccaf347f1f95): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.2%]	20
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	3
All ❌✅ (primary)	-0.3%	[-0.4%, -0.2%]	20

Max RSS (memory usage)

Results (primary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Cycles

Results (secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 749.925s -> 750.285s (0.05%) Artifact size: 338.74 MiB -> 338.87 MiB (0.04%)

Aug 27 '24 22:08 rust-timer

rust rust copied to clipboard

Do not call source_span when not tracking dependencies.

Overall result: ✅ improvements - no action needed

Overall result: ✅ improvements - no action needed

rust
rust copied to clipboard