rust icon indicating copy to clipboard operation
rust copied to clipboard

only find segs chain for missing methods when no available candidates

Open bvanjoi opened this issue 1 month ago • 1 comments

Fixes #124946

This PR includes two changes:

  • Extracting the lookup for the missing method in chains into a single function.
  • Calling this function only when there are no candidates available.

bvanjoi avatar May 13 '24 14:05 bvanjoi

r? @nnethercote

rustbot has assigned @nnethercote. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar May 13 '24 14:05 rustbot

@rustbot ready

bvanjoi avatar May 14 '24 04:05 bvanjoi

r=me once the typo is fixed.

For future reference, a nice way to do this kind of PR is to add the new test in a first commit, and then make the change to the error message in the second commit. That way the reviewer can easily see exactly how the change improves the error output.

@bors delegate=bvanjoi

nnethercote avatar May 14 '24 11:05 nnethercote

:v: @bvanjoi, you can now approve this pull request!

If @nnethercote told you to "r=me" after making some further change, please make that change, then do @bors r=@nnethercote

bors avatar May 14 '24 11:05 bors

@bors r=@nnethercote

bvanjoi avatar May 14 '24 13:05 bvanjoi

:pushpin: Commit ade33b02f237d484bef950ebf550bc12d49313d1 has been approved by nnethercote

It is now in the queue for this repository.

bors avatar May 14 '24 13:05 bors