rust icon indicating copy to clipboard operation
rust copied to clipboard

Replace uses of #[allow(static_mut_refs)] with SyncUnsafeCell

Open saethlin opened this issue 1 year ago • 6 comments

https://github.com/rust-lang/rust/pull/124895 is adding a number of FIXME comments on #[allow(static_mut_refs)] in the compiler. This issue tracks fixing them.

See https://github.com/rust-lang/rust/pull/124895#issuecomment-2106084818

saethlin avatar May 12 '24 02:05 saethlin

Hm, I wonder if it works like...

cc @obeis

workingjubilee avatar May 12 '24 03:05 workingjubilee

As before, I'm not sure SyncUnsafeCell is the right solution. In many cases it should probably just be raw pointers.

RalfJung avatar May 12 '24 06:05 RalfJung

@rustbot assign @obeis

RalfJung avatar May 12 '24 07:05 RalfJung

@rustbot claim

obeis avatar May 12 '24 09:05 obeis

:thinking: I thought claim is just an alias for assign <me>... very strange. Oh well.

RalfJung avatar May 12 '24 09:05 RalfJung

GH API design sure includes some... choices.

workingjubilee avatar May 12 '24 17:05 workingjubilee