rust icon indicating copy to clipboard operation
rust copied to clipboard

Migrate `run-make/c-link-to-rust-va-list-fn` to `rmake`

Open Oneirical opened this issue 1 month ago • 9 comments

Part of #121876.

r? @jieyouxu

Oneirical avatar May 11 '24 20:05 Oneirical

Some changes occurred in run-make tests.

cc @jieyouxu

rustbot avatar May 11 '24 20:05 rustbot

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Getting action download info
Download action repository 'msys2/[email protected]' (SHA:cc11e9188b693c2b100158c3322424c4cc1dadea)
Download action repository 'actions/checkout@v4' (SHA:0ad4b8fadaa221de15dcec353f45205ec38ea70b)
Download action repository 'actions/upload-artifact@v4' (SHA:65462800fd760344b1a7b4382951275a0abb4808)
Complete job name: PR - mingw-check-tidy
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
COPY scripts/sccache.sh /scripts/
RUN sh /scripts/sccache.sh

COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt \
    && pip3 install virtualenv
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---

#12 [5/8] COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
#12 DONE 0.0s

#13 [6/8] RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt     && pip3 install virtualenv
#13 0.422   Downloading binaryornot-0.4.4-py2.py3-none-any.whl (9.0 kB)
#13 0.437 Collecting boolean-py==4.0
#13 0.442   Downloading boolean.py-4.0-py3-none-any.whl (25 kB)
#13 0.454 Collecting chardet==5.1.0
---
#13 3.550 Building wheels for collected packages: reuse
#13 3.551   Building wheel for reuse (pyproject.toml): started
#13 3.885   Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 3.885   Created wheel for reuse: filename=reuse-1.1.0-cp310-cp310-manylinux_2_35_x86_64.whl size=181117 sha256=f5f58750481f69515c2c0d1d503daf565e2565c370d07fc6aeb95fe3498b4269
#13 3.886   Stored in directory: /tmp/pip-ephem-wheel-cache-doegh5i8/wheels/c2/3c/b9/1120c2ab4bd82694f7e6f0537dc5b9a085c13e2c69a8d0c76d
#13 3.888 Installing collected packages: boolean-py, binaryornot, setuptools, reuse, python-debian, markupsafe, license-expression, jinja2, chardet
#13 3.910   Attempting uninstall: setuptools
#13 3.911     Found existing installation: setuptools 59.6.0
#13 3.912     Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
#13 3.912     Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
#13 3.913     Can't uninstall 'setuptools'. No files were found to uninstall.
#13 4.601 Successfully installed binaryornot-0.4.4 boolean-py-4.0 chardet-5.1.0 jinja2-3.1.2 license-expression-30.0.0 markupsafe-2.1.1 python-debian-0.1.49 reuse-1.1.0 setuptools-66.0.0
#13 4.601 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 5.119 Collecting virtualenv
#13 5.159   Downloading virtualenv-20.26.1-py3-none-any.whl (3.9 MB)
#13 5.216      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.9/3.9 MB 71.8 MB/s eta 0:00:00
#13 5.254 Collecting distlib<1,>=0.3.7
#13 5.258   Downloading distlib-0.3.8-py2.py3-none-any.whl (468 kB)
#13 5.297 Collecting filelock<4,>=3.12.2
#13 5.301   Downloading filelock-3.14.0-py3-none-any.whl (12 kB)
#13 5.301   Downloading filelock-3.14.0-py3-none-any.whl (12 kB)
#13 5.330 Collecting platformdirs<5,>=3.9.1
#13 5.334   Downloading platformdirs-4.2.1-py3-none-any.whl (17 kB)
#13 5.421 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 5.586 Successfully installed distlib-0.3.8 filelock-3.14.0 platformdirs-4.2.1 virtualenv-20.26.1
#13 DONE 5.7s

#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
DirectMap4k:      212928 kB
DirectMap2M:     7127040 kB
DirectMap1G:    11534336 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
    Finished `dev` profile [unoptimized] target(s) in 0.03s
##[endgroup]
downloading https://ci-artifacts.rust-lang.org/rustc-builds-alt/3349155ac082ed9034404428c8402e42a165d3d8/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/llvm-3349155ac082ed9034404428c8402e42a165d3d8-true/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm
---
##[endgroup]
fmt check
tidy check
tidy: Skipping binary file check, read-only filesystem
##[error]tidy error: /checkout/tests/run-make/c-link-to-rust-va-list-fn/rmake.rs:2: trailing whitespace
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10'
Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (24.0)
Collecting black==23.3.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 7))
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.7/1.7 MB 41.5 MB/s eta 0:00:00
Collecting click==8.1.3 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 34))
  Downloading click-8.1.3-py3-none-any.whl (96 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 96.6/96.6 kB 37.1 MB/s eta 0:00:00
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 96.6/96.6 kB 37.1 MB/s eta 0:00:00
Collecting importlib-metadata==6.7.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 38))
  Downloading importlib_metadata-6.7.0-py3-none-any.whl (22 kB)
Collecting mypy-extensions==1.0.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 42))
  Downloading mypy_extensions-1.0.0-py3-none-any.whl (4.7 kB)
Collecting packaging==23.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 46))
  Downloading packaging-23.1-py3-none-any.whl (48 kB)
Collecting pathspec==0.11.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 50))
  Downloading pathspec-0.11.1-py3-none-any.whl (29 kB)
Collecting platformdirs==3.6.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 54))
  Downloading platformdirs-3.6.0-py3-none-any.whl (16 kB)
  Downloading platformdirs-3.6.0-py3-none-any.whl (16 kB)
Collecting ruff==0.0.272 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 58))
  Downloading ruff-0.0.272-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (5.9 MB)
Collecting tomli==2.0.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 77))
  Downloading tomli-2.0.1-py3-none-any.whl (12 kB)
Collecting typed-ast==1.5.4 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 81))
  Downloading typed_ast-1.5.4-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (877 kB)
  Downloading typed_ast-1.5.4-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (877 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 877.7/877.7 kB 144.4 MB/s eta 0:00:00
Collecting typing-extensions==4.6.3 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 107))
  Downloading typing_extensions-4.6.3-py3-none-any.whl (31 kB)
Collecting zipp==3.15.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 114))
  Downloading zipp-3.15.0-py3-none-any.whl (6.8 kB)
Installing collected packages: zipp, typing-extensions, typed-ast, tomli, ruff, platformdirs, pathspec, packaging, mypy-extensions, click, importlib-metadata, black
Successfully installed black-23.3.0 click-8.1.3 importlib-metadata-6.7.0 mypy-extensions-1.0.0 packaging-23.1 pathspec-0.11.1 platformdirs-3.6.0 ruff-0.0.272 tomli-2.0.1 typed-ast-1.5.4 typing-extensions-4.6.3 zipp-3.15.0
some tidy checks failed
Build completed unsuccessfully in 0:00:58
  local time: Sat May 11 20:49:36 UTC 2024
  network time: Sat, 11 May 2024 20:49:36 GMT

rust-log-analyzer avatar May 11 '24 20:05 rust-log-analyzer

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Getting action download info
Download action repository 'msys2/[email protected]' (SHA:cc11e9188b693c2b100158c3322424c4cc1dadea)
Download action repository 'actions/checkout@v4' (SHA:0ad4b8fadaa221de15dcec353f45205ec38ea70b)
Download action repository 'actions/upload-artifact@v4' (SHA:65462800fd760344b1a7b4382951275a0abb4808)
Complete job name: PR - mingw-check-tidy
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
COPY scripts/sccache.sh /scripts/
RUN sh /scripts/sccache.sh

COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt \
    && pip3 install virtualenv
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---

#12 [5/8] COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
#12 DONE 0.0s

#13 [6/8] RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt     && pip3 install virtualenv
#13 0.436   Downloading binaryornot-0.4.4-py2.py3-none-any.whl (9.0 kB)
#13 0.453 Collecting boolean-py==4.0
#13 0.461   Downloading boolean.py-4.0-py3-none-any.whl (25 kB)
#13 0.479 Collecting chardet==5.1.0
---
#13 3.578 Building wheels for collected packages: reuse
#13 3.579   Building wheel for reuse (pyproject.toml): started
#13 3.898   Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 3.899   Created wheel for reuse: filename=reuse-1.1.0-cp310-cp310-manylinux_2_35_x86_64.whl size=181117 sha256=f5f58750481f69515c2c0d1d503daf565e2565c370d07fc6aeb95fe3498b4269
#13 3.899   Stored in directory: /tmp/pip-ephem-wheel-cache-_x1v7un5/wheels/c2/3c/b9/1120c2ab4bd82694f7e6f0537dc5b9a085c13e2c69a8d0c76d
#13 3.902 Installing collected packages: boolean-py, binaryornot, setuptools, reuse, python-debian, markupsafe, license-expression, jinja2, chardet
#13 3.923   Attempting uninstall: setuptools
#13 3.924     Found existing installation: setuptools 59.6.0
#13 3.925     Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
#13 3.925     Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
#13 3.925     Can't uninstall 'setuptools'. No files were found to uninstall.
#13 4.585 Successfully installed binaryornot-0.4.4 boolean-py-4.0 chardet-5.1.0 jinja2-3.1.2 license-expression-30.0.0 markupsafe-2.1.1 python-debian-0.1.49 reuse-1.1.0 setuptools-66.0.0
#13 4.585 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 5.093 Collecting virtualenv
#13 5.143   Downloading virtualenv-20.26.1-py3-none-any.whl (3.9 MB)
#13 5.314      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.9/3.9 MB 23.2 MB/s eta 0:00:00
#13 5.353 Collecting distlib<1,>=0.3.7
#13 5.363   Downloading distlib-0.3.8-py2.py3-none-any.whl (468 kB)
#13 5.409 Collecting filelock<4,>=3.12.2
#13 5.416   Downloading filelock-3.14.0-py3-none-any.whl (12 kB)
#13 5.416   Downloading filelock-3.14.0-py3-none-any.whl (12 kB)
#13 5.448 Collecting platformdirs<5,>=3.9.1
#13 5.455   Downloading platformdirs-4.2.1-py3-none-any.whl (17 kB)
#13 5.540 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 5.700 Successfully installed distlib-0.3.8 filelock-3.14.0 platformdirs-4.2.1 virtualenv-20.26.1
#13 DONE 5.8s

#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
DirectMap4k:      196544 kB
DirectMap2M:     7143424 kB
DirectMap1G:    11534336 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
    Finished `dev` profile [unoptimized] target(s) in 0.03s
##[endgroup]
downloading https://ci-artifacts.rust-lang.org/rustc-builds-alt/3349155ac082ed9034404428c8402e42a165d3d8/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/llvm-3349155ac082ed9034404428c8402e42a165d3d8-true/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm
---
   Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
    Finished `release` profile [optimized] target(s) in 25.49s
##[endgroup]
fmt check
##[error]Diff in /checkout/tests/run-make/c-link-to-rust-va-list-fn/rmake.rs at line 8:
 use run_make_support::{cc, extra_c_flags, run, rustc, static_lib};
 fn main() {
-    rustc()
-    rustc()
-        .input("checkrust.rs")
-        .run();
-    cc()
-        .input("test.c")
+    rustc().input("checkrust.rs").run();
+    cc().input("test.c")
         .input(static_lib("checkrust"))
         .out_exe("test")
         .args(&extra_c_flags())
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt/bin/rustfmt" "--config-path" "/checkout" "--edition" "2021" "--unstable-features" "--skip-children" "--check" "/checkout/tests/run-make/wasm-symbols-different-module/rmake.rs" "/checkout/tests/run-make/arguments-non-c-like-enum/rmake.rs" "/checkout/tests/run-make/wasm-import-module/rmake.rs" "/checkout/tests/run-make/non-unicode-env/rmake.rs" "/checkout/tests/run-make/wasm-symbols-not-imported/rmake.rs" "/checkout/tests/run-make/rust-lld-custom-target/rmake.rs" "/checkout/tests/run-make/rustdoc-output-path/rmake.rs" "/checkout/tests/run-make/rustdoc-determinism/rmake.rs" "/checkout/tests/run-make/c-link-to-rust-va-list-fn/rmake.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
  local time: Sat May 11 20:57:36 UTC 2024
  network time: Sat, 11 May 2024 20:57:36 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

rust-log-analyzer avatar May 11 '24 20:05 rust-log-analyzer

@bors r+ rollup=iffy (this might bounce due to cc differences)

jieyouxu avatar May 13 '24 09:05 jieyouxu

:pushpin: Commit 10c358f11189de4f639106253c8178dbbfa3f68e has been approved by jieyouxu

It is now in the queue for this repository.

bors avatar May 13 '24 09:05 bors

:hourglass: Testing commit 10c358f11189de4f639106253c8178dbbfa3f68e with merge b3069d51952a4c40494ee4255f0eed0e9b50cbcb...

bors avatar May 13 '24 11:05 bors

The job aarch64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[TIMING] core::build_steps::tool::ToolBuild { compiler: Compiler { stage: 0, host: aarch64-apple-darwin }, target: aarch64-apple-darwin, tool: "tidy", path: "src/tools/tidy", mode: ToolBootstrap, source_type: InTree, extra_features: [], allow_features: "" } -- 23.717
[TIMING] core::build_steps::tool::Tidy { compiler: Compiler { stage: 0, host: aarch64-apple-darwin }, target: aarch64-apple-darwin } -- 0.000
fmt check
skip untracked path AWSCLIV2.pkg during rustfmt invocations
##[error]Diff in /Users/runner/work/rust/rust/tests/run-make/c-link-to-rust-va-list-fn/rmake.rs at line 8:
 use run_make_support::{cc, extra_c_flags, run, rustc, static_lib};
 fn main() {
 fn main() {
-    rustc().input("checkrust.rs")
-        .run();
+    rustc().input("checkrust.rs").run();
     cc().input("test.c")
         .input(static_lib("checkrust"))
         .out_exe("test")
Running `"/Users/runner/work/rust/rust/build/aarch64-apple-darwin/rustfmt/bin/rustfmt" "--config-path" "/Users/runner/work/rust/rust" "--edition" "2021" "--unstable-features" "--skip-children" "--check" "/Users/runner/work/rust/rust/tests/run-make/rustdoc-determinism/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/artifact-incr-cache/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/rustdoc-scrape-examples-ordering/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/compiler-builtins/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/wasm-export-all-symbols/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/repr128-dwarf/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/CURRENT_RUSTC_VERSION/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/print-native-static-libs/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/c-link-to-rust-va-list-fn/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/print-cfg/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/rustdoc-test-args/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/wasm-panic-small/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/no-input-file/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/wasm-custom-section/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/rustdoc-map-file/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/non-unicode-env/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/a-b-a-linker-guard/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/doctests-runtool/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/print-to-output/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/artifact-incr-cache-no-obj/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/non-unicode-in-incremental-dir/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/arguments-non-c-like-enum/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/core-no-fp-fmt-parse/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/rustdoc-shared-flags/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/rustdoc-error-lines/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/rustdoc-output-path/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/wasm-symbols-not-exported/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/wasm-import-module/rmake.rs" "/Users/runner/work/rust/rust/tests/run-make/cross-lang-lto-riscv-abi/rmake.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
  local time: Mon May 13 11:18:08 UTC 2024
  network time: Mon, 13 May 2024 11:18:08 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

rust-log-analyzer avatar May 13 '24 11:05 rust-log-analyzer

:broken_heart: Test failed - checks-actions

bors avatar May 13 '24 11:05 bors

Needs x fmt

jieyouxu avatar May 13 '24 11:05 jieyouxu

Thanks, r=me after CI is green

@bors delegate+

jieyouxu avatar May 14 '24 02:05 jieyouxu

:v: @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

bors avatar May 14 '24 02:05 bors

@bors r=@jieyouxu

Oneirical avatar May 14 '24 03:05 Oneirical

:pushpin: Commit 812f89728a3a1fbf3979e552fcb888fe6a500c19 has been approved by jieyouxu

It is now in the queue for this repository.

bors avatar May 14 '24 03:05 bors

:hourglass: Testing commit 812f89728a3a1fbf3979e552fcb888fe6a500c19 with merge 58426f4a5b69d10db1b0ffa017bac25f1b2e801e...

bors avatar May 14 '24 05:05 bors

:sunny: Test successful - checks-actions Approved by: jieyouxu Pushing 58426f4a5b69d10db1b0ffa017bac25f1b2e801e to master...

bors avatar May 14 '24 07:05 bors

Finished benchmarking commit (58426f4a5b69d10db1b0ffa017bac25f1b2e801e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.4% [2.4%, 2.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 677.553s -> 677.153s (-0.06%) Artifact size: 316.02 MiB -> 315.90 MiB (-0.04%)

rust-timer avatar May 14 '24 08:05 rust-timer