rust
rust copied to clipboard
rust-lang
`obligations_for_self_ty`: use `ProofTreeVisitor` for nested goals
As always, dealing with proof trees continues to be a hacked together mess. This may still some improvements to actually compile core, but getting an MVP working was surprisingly easy :sweat_smile:
r? @compiler-errors
Some changes occurred to the core trait solver
cc @rust-lang/initiative-trait-system-refactor
The job x86_64-gnu-llvm-17 failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
#16 exporting to docker image format
#16 sending tarball 30.3s done
#16 DONE 35.2s
##[endgroup]
Setting extra environment values for docker: --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-17]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure:
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-17', '--enable-llvm-link-shared', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-17/bin/llvm-config
configure: llvm.link-shared := True
configure: rust.thin-lto-import-instr-limit := 10
configure: change-id := 99999999
:hourglass: Trying commit 03878c682a68dc2891eccbd04b5d2f04c91ba0c4 with merge 5cd2d13967a20b5c07df3096d03774c4aac61ac8...
the try build in question: https://github.com/rust-lang-ci/rust/actions/runs/8838574745
triagebot.toml has been modified, there may have been changes to the review queue.
cc @davidtwco, @wesleywiser
:hourglass: Trying commit 146f63782604058e31a81f62dd30d9671738398f with merge 9dcd6e521c16a2266f48f4b06d2d04f466f18ff6...
:sunny: Try build successful - checks-actions
Build commit: 9dcd6e521c16a2266f48f4b06d2d04f466f18ff6 (9dcd6e521c16a2266f48f4b06d2d04f466f18ff6)
Queued 9dcd6e521c16a2266f48f4b06d2d04f466f18ff6 with parent 3a36386dc1075018dc7ca2640a2656adb31a61fe, future comparison URL. There is currently 1 preceding artifact in the queue. It will probably take at least ~1.8 hours until the benchmark run finishes.
Finished benchmarking commit (9dcd6e521c16a2266f48f4b06d2d04f466f18ff6): comparison URL.
Overall result: ✅ improvements - no action needed
Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.
@bors rollup=never @rustbot label: -S-waiting-on-perf -perf-regression
Instruction count
This is a highly reliable metric that was used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-1.0% | [-1.8%, -0.3%] | 2 |
| All ❌✅ (primary) | - | - | 0 |
Max RSS (memory usage)
Results
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
1.8% | [1.8%, 1.8%] | 1 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-1.4% | [-1.4%, -1.4%] | 1 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | 0.2% | [-1.4%, 1.8%] | 2 |
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 671.645s -> 672.204s (0.08%) Artifact size: 315.99 MiB -> 315.88 MiB (-0.03%)
:pushpin: Commit 146f63782604058e31a81f62dd30d9671738398f has been approved by compiler-errors
It is now in the queue for this repository.
:hourglass: Testing commit 146f63782604058e31a81f62dd30d9671738398f with merge 1b3a32958bb54bde45e693217e8f7469459e5865...
:sunny: Test successful - checks-actions Approved by: compiler-errors Pushing 1b3a32958bb54bde45e693217e8f7469459e5865 to master...
Finished benchmarking commit (1b3a32958bb54bde45e693217e8f7469459e5865): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
This is a highly reliable metric that was used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-0.3% | [-0.3%, -0.3%] | 1 |
| All ❌✅ (primary) | - | - | 0 |
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-1.0% | [-1.2%, -0.8%] | 2 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -1.0% | [-1.2%, -0.8%] | 2 |
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 671.528s -> 671.828s (0.04%) Artifact size: 316.01 MiB -> 315.91 MiB (-0.03%)