rust
rust copied to clipboard
Add `intrinsic_name` to get plain intrinsic name
Add an intrinsic_name API to retrieve the plain intrinsic name. The plain name does not include type arguments (as trimmed_name does), which is more convenient to match with intrinsic symbols.
r? @oli-obk
rustbot has assigned @oli-obk. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
This PR changes Stable MIR
cc @oli-obk, @celinval, @spastorino, @ouz-a
The job mingw-check failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
GITHUB_ACTION=__run_7
GITHUB_ACTIONS=true
GITHUB_ACTION_REF=
GITHUB_ACTION_REPOSITORY=
GITHUB_ACTOR=adpaco-aws
GITHUB_API_URL=https://api.github.com
GITHUB_BASE_REF=master
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_0ef87e4c-76aa-484a-b56c-9be50343cf9c
GITHUB_EVENT_NAME=pull_request
---
GITHUB_SERVER_URL=https://github.com
GITHUB_SHA=ccc74c2ac7d4170b7f74a95f0307ceddf9af41d6
GITHUB_STATE=/home/runner/work/_temp/_runner_file_commands/save_state_0ef87e4c-76aa-484a-b56c-9be50343cf9c
GITHUB_STEP_SUMMARY=/home/runner/work/_temp/_runner_file_commands/step_summary_0ef87e4c-76aa-484a-b56c-9be50343cf9c
GITHUB_TRIGGERING_ACTOR=adpaco-aws
GITHUB_WORKFLOW_REF=rust-lang/rust/.github/workflows/ci.yml@refs/pull/122203/merge
GITHUB_WORKFLOW_SHA=ccc74c2ac7d4170b7f74a95f0307ceddf9af41d6
GITHUB_WORKSPACE=/home/runner/work/rust/rust
GOROOT_1_20_X64=/opt/hostedtoolcache/go/1.20.14/x64
---
#13 3.596 Building wheels for collected packages: reuse
#13 3.597 Building wheel for reuse (pyproject.toml): started
#13 3.922 Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 3.923 Created wheel for reuse: filename=reuse-1.1.0-cp310-cp310-manylinux_2_35_x86_64.whl size=181117 sha256=f5f58750481f69515c2c0d1d503daf565e2565c370d07fc6aeb95fe3498b4269
#13 3.925 Stored in directory: /tmp/pip-ephem-wheel-cache-8qaem3an/wheels/c2/3c/b9/1120c2ab4bd82694f7e6f0537dc5b9a085c13e2c69a8d0c76d
#13 3.926 Installing collected packages: boolean-py, binaryornot, setuptools, reuse, python-debian, markupsafe, license-expression, jinja2, chardet
#13 3.947 Attempting uninstall: setuptools
#13 3.948 Found existing installation: setuptools 59.6.0
#13 3.949 Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
---
Checking rustc_monomorphize v0.0.0 (/checkout/compiler/rustc_monomorphize)
Checking rustc_codegen_llvm v0.0.0 (/checkout/compiler/rustc_codegen_llvm)
Checking rustc_ast_lowering v0.0.0 (/checkout/compiler/rustc_ast_lowering)
Checking rustc_smir v0.0.0 (/checkout/compiler/rustc_smir)
error[E0599]: `IntrinsicDef` doesn't implement `std::fmt::Display`
|
594 | Some(name.to_string())
594 | Some(name.to_string())
| ^^^^^^^^^ `IntrinsicDef` cannot be formatted with the default formatter
::: /checkout/compiler/rustc_middle/src/ty/intrinsic.rs:6:1
|
6 | pub struct IntrinsicDef {
6 | pub struct IntrinsicDef {
| ----------------------- doesn't satisfy `IntrinsicDef: ToString` or `IntrinsicDef: std::fmt::Display`
= note: the following trait bounds were not satisfied:
`IntrinsicDef: std::fmt::Display`
`IntrinsicDef: std::fmt::Display`
which is required by `IntrinsicDef: ToString`
For more information about this error, try `rustc --explain E0599`.
error: could not compile `rustc_smir` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
Build completed unsuccessfully in 0:01:21
r? @celinval
@compiler-errors wanted to double check with you if this is good to go.
otherwise looks fine to me
@bors r+ rollup
:pushpin: Commit 68fc92242f1e6165f917cce8304c8cf35518f63a has been approved by celinval
It is now in the queue for this repository.