rust icon indicating copy to clipboard operation
rust copied to clipboard

snapshot: avoid leaking inference vars

Open lcnr opened this issue 11 months ago • 26 comments

A first step towards fixing #122188. There are still some FIXMEs left, most notably method probing.

fixes #122098

r? @oli-obk

lcnr avatar Mar 08 '24 11:03 lcnr

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

rustbot avatar Mar 08 '24 11:03 rustbot

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Getting action download info
Download action repository 'msys2/[email protected]' (SHA:cc11e9188b693c2b100158c3322424c4cc1dadea)
Download action repository 'actions/checkout@v4' (SHA:b4ffde65f46336ab88eb53be808477a3936bae11)
Download action repository 'actions/upload-artifact@v3' (SHA:a8a3f3ad30e3422c9c7b888a15615d19a852ae32)
Complete job name: PR - mingw-check-tidy
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
COPY scripts/sccache.sh /scripts/
RUN sh /scripts/sccache.sh

COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt \
    && pip3 install virtualenv
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---

#10 [5/8] COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
#10 DONE 0.0s

#11 [6/8] RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt     && pip3 install virtualenv
#11 0.710   Downloading binaryornot-0.4.4-py2.py3-none-any.whl (9.0 kB)
#11 0.727 Collecting boolean-py==4.0
#11 0.734   Downloading boolean.py-4.0-py3-none-any.whl (25 kB)
#11 0.753 Collecting chardet==5.1.0
---
#11 3.911 Building wheels for collected packages: reuse
#11 3.912   Building wheel for reuse (pyproject.toml): started
#11 4.246   Building wheel for reuse (pyproject.toml): finished with status 'done'
#11 4.247   Created wheel for reuse: filename=reuse-1.1.0-cp310-cp310-manylinux_2_35_x86_64.whl size=181117 sha256=f5f58750481f69515c2c0d1d503daf565e2565c370d07fc6aeb95fe3498b4269
#11 4.247   Stored in directory: /tmp/pip-ephem-wheel-cache-3n3777zl/wheels/c2/3c/b9/1120c2ab4bd82694f7e6f0537dc5b9a085c13e2c69a8d0c76d
#11 4.249 Installing collected packages: boolean-py, binaryornot, setuptools, reuse, python-debian, markupsafe, license-expression, jinja2, chardet
#11 4.271   Attempting uninstall: setuptools
#11 4.272     Found existing installation: setuptools 59.6.0
#11 4.273     Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
#11 4.273     Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
#11 4.273     Can't uninstall 'setuptools'. No files were found to uninstall.
#11 4.948 Successfully installed binaryornot-0.4.4 boolean-py-4.0 chardet-5.1.0 jinja2-3.1.2 license-expression-30.0.0 markupsafe-2.1.1 python-debian-0.1.49 reuse-1.1.0 setuptools-66.0.0
#11 4.949 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#11 5.473 Collecting virtualenv
#11 5.522   Downloading virtualenv-20.25.1-py3-none-any.whl (3.8 MB)
#11 5.659      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.8/3.8 MB 28.2 MB/s eta 0:00:00
#11 5.710 Collecting platformdirs<5,>=3.9.1
#11 5.717   Downloading platformdirs-4.2.0-py3-none-any.whl (17 kB)
#11 5.737 Collecting distlib<1,>=0.3.7
#11 5.744   Downloading distlib-0.3.8-py2.py3-none-any.whl (468 kB)
#11 5.787 Collecting filelock<4,>=3.12.2
#11 5.794   Downloading filelock-3.13.1-py3-none-any.whl (11 kB)
#11 5.794   Downloading filelock-3.13.1-py3-none-any.whl (11 kB)
#11 5.878 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#11 6.040 Successfully installed distlib-0.3.8 filelock-3.13.1 platformdirs-4.2.0 virtualenv-20.25.1
#11 DONE 6.1s

#12 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#12 DONE 0.0s
---
DirectMap4k:      169920 kB
DirectMap2M:     7170048 kB
DirectMap1G:    11534336 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
    Finished dev [unoptimized] target(s) in 0.03s
##[endgroup]
downloading https://ci-artifacts.rust-lang.org/rustc-builds-alt/14fbc3c00525b41a3a3ee2c90e9ab6fd3b05274f/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/llvm-14fbc3c00525b41a3a3ee2c90e9ab6fd3b05274f-true/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm
---
##[endgroup]
fmt check
tidy check
tidy: Skipping binary file check, read-only filesystem
##[error]tidy error: /checkout/compiler/rustc_hir_typeck/src/method/probe.rs:102: comment with odd number of backticks
##[error]tidy error: /checkout/compiler/rustc_hir_typeck/src/method/probe.rs:203: comment with odd number of backticks
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10'
Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (24.0)
Collecting black==23.3.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 7))
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.7/1.7 MB 21.6 MB/s eta 0:00:00
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.7/1.7 MB 21.6 MB/s eta 0:00:00
Collecting click==8.1.3 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 34))
  Downloading click-8.1.3-py3-none-any.whl (96 kB)
Collecting importlib-metadata==6.7.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 38))
  Downloading importlib_metadata-6.7.0-py3-none-any.whl (22 kB)
  Downloading importlib_metadata-6.7.0-py3-none-any.whl (22 kB)
Collecting mypy-extensions==1.0.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 42))
  Downloading mypy_extensions-1.0.0-py3-none-any.whl (4.7 kB)
Collecting packaging==23.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 46))
  Downloading packaging-23.1-py3-none-any.whl (48 kB)
Collecting pathspec==0.11.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 50))
  Downloading pathspec-0.11.1-py3-none-any.whl (29 kB)
  Downloading pathspec-0.11.1-py3-none-any.whl (29 kB)
Collecting platformdirs==3.6.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 54))
  Downloading platformdirs-3.6.0-py3-none-any.whl (16 kB)
Collecting ruff==0.0.272 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 58))
  Downloading ruff-0.0.272-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (5.9 MB)
Collecting tomli==2.0.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 77))
  Downloading tomli-2.0.1-py3-none-any.whl (12 kB)
Collecting typed-ast==1.5.4 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 81))
  Downloading typed_ast-1.5.4-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (877 kB)
  Downloading typed_ast-1.5.4-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (877 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 877.7/877.7 kB 78.1 MB/s eta 0:00:00
Collecting typing-extensions==4.6.3 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 107))
  Downloading typing_extensions-4.6.3-py3-none-any.whl (31 kB)
Collecting zipp==3.15.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 114))
  Downloading zipp-3.15.0-py3-none-any.whl (6.8 kB)
Installing collected packages: zipp, typing-extensions, typed-ast, tomli, ruff, platformdirs, pathspec, packaging, mypy-extensions, click, importlib-metadata, black
Successfully installed black-23.3.0 click-8.1.3 importlib-metadata-6.7.0 mypy-extensions-1.0.0 packaging-23.1 pathspec-0.11.1 platformdirs-3.6.0 ruff-0.0.272 tomli-2.0.1 typed-ast-1.5.4 typing-extensions-4.6.3 zipp-3.15.0
some tidy checks failed
Build completed unsuccessfully in 0:01:03
  local time: Fri Mar  8 11:31:34 UTC 2024
  network time: Fri, 08 Mar 2024 11:31:34 GMT

rust-log-analyzer avatar Mar 08 '24 11:03 rust-log-analyzer

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Getting action download info
Download action repository 'msys2/[email protected]' (SHA:cc11e9188b693c2b100158c3322424c4cc1dadea)
Download action repository 'actions/checkout@v4' (SHA:b4ffde65f46336ab88eb53be808477a3936bae11)
Download action repository 'actions/upload-artifact@v3' (SHA:a8a3f3ad30e3422c9c7b888a15615d19a852ae32)
Complete job name: PR - mingw-check-tidy
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
COPY scripts/sccache.sh /scripts/
RUN sh /scripts/sccache.sh

COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt \
    && pip3 install virtualenv
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---

#10 [5/8] COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
#10 DONE 0.0s

#11 [6/8] RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt     && pip3 install virtualenv
#11 0.595   Downloading binaryornot-0.4.4-py2.py3-none-any.whl (9.0 kB)
#11 0.612 Collecting boolean-py==4.0
#11 0.625   Downloading boolean.py-4.0-py3-none-any.whl (25 kB)
#11 0.641 Collecting chardet==5.1.0
---
#11 3.739 Building wheels for collected packages: reuse
#11 3.740   Building wheel for reuse (pyproject.toml): started
#11 4.067   Building wheel for reuse (pyproject.toml): finished with status 'done'
#11 4.068   Created wheel for reuse: filename=reuse-1.1.0-cp310-cp310-manylinux_2_35_x86_64.whl size=181117 sha256=f5f58750481f69515c2c0d1d503daf565e2565c370d07fc6aeb95fe3498b4269
#11 4.068   Stored in directory: /tmp/pip-ephem-wheel-cache-zc9bmzmi/wheels/c2/3c/b9/1120c2ab4bd82694f7e6f0537dc5b9a085c13e2c69a8d0c76d
#11 4.070 Installing collected packages: boolean-py, binaryornot, setuptools, reuse, python-debian, markupsafe, license-expression, jinja2, chardet
#11 4.092   Attempting uninstall: setuptools
#11 4.093     Found existing installation: setuptools 59.6.0
#11 4.094     Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
#11 4.094     Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
#11 4.094     Can't uninstall 'setuptools'. No files were found to uninstall.
#11 4.767 Successfully installed binaryornot-0.4.4 boolean-py-4.0 chardet-5.1.0 jinja2-3.1.2 license-expression-30.0.0 markupsafe-2.1.1 python-debian-0.1.49 reuse-1.1.0 setuptools-66.0.0
#11 4.767 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#11 5.284 Collecting virtualenv
#11 5.332   Downloading virtualenv-20.25.1-py3-none-any.whl (3.8 MB)
#11 5.467      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.8/3.8 MB 28.4 MB/s eta 0:00:00
#11 5.507 Collecting distlib<1,>=0.3.7
#11 5.514   Downloading distlib-0.3.8-py2.py3-none-any.whl (468 kB)
#11 5.559 Collecting filelock<4,>=3.12.2
#11 5.566   Downloading filelock-3.13.1-py3-none-any.whl (11 kB)
#11 5.566   Downloading filelock-3.13.1-py3-none-any.whl (11 kB)
#11 5.598 Collecting platformdirs<5,>=3.9.1
#11 5.605   Downloading platformdirs-4.2.0-py3-none-any.whl (17 kB)
#11 5.690 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#11 5.851 Successfully installed distlib-0.3.8 filelock-3.13.1 platformdirs-4.2.0 virtualenv-20.25.1
#11 DONE 5.9s

#12 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#12 DONE 0.0s
---
DirectMap4k:      169920 kB
DirectMap2M:     6121472 kB
DirectMap1G:    12582912 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
    Finished dev [unoptimized] target(s) in 0.03s
##[endgroup]
downloading https://ci-artifacts.rust-lang.org/rustc-builds-alt/14fbc3c00525b41a3a3ee2c90e9ab6fd3b05274f/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/llvm-14fbc3c00525b41a3a3ee2c90e9ab6fd3b05274f-true/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm
---
##[endgroup]
fmt check
tidy check
tidy: Skipping binary file check, read-only filesystem
##[error]tidy error: /checkout/compiler/rustc_hir_typeck/src/method/probe.rs:102: comment with odd number of backticks
##[error]tidy error: /checkout/compiler/rustc_hir_typeck/src/method/probe.rs:203: comment with odd number of backticks
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10'
Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (24.0)
Collecting black==23.3.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 7))
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.7/1.7 MB 15.9 MB/s eta 0:00:00
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.7/1.7 MB 15.9 MB/s eta 0:00:00
Collecting click==8.1.3 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 34))
  Downloading click-8.1.3-py3-none-any.whl (96 kB)
Collecting importlib-metadata==6.7.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 38))
  Downloading importlib_metadata-6.7.0-py3-none-any.whl (22 kB)
  Downloading importlib_metadata-6.7.0-py3-none-any.whl (22 kB)
Collecting mypy-extensions==1.0.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 42))
  Downloading mypy_extensions-1.0.0-py3-none-any.whl (4.7 kB)
Collecting packaging==23.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 46))
  Downloading packaging-23.1-py3-none-any.whl (48 kB)
Collecting pathspec==0.11.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 50))
  Downloading pathspec-0.11.1-py3-none-any.whl (29 kB)
  Downloading pathspec-0.11.1-py3-none-any.whl (29 kB)
Collecting platformdirs==3.6.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 54))
  Downloading platformdirs-3.6.0-py3-none-any.whl (16 kB)
Collecting ruff==0.0.272 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 58))
  Downloading ruff-0.0.272-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (5.9 MB)
Collecting tomli==2.0.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 77))
  Downloading tomli-2.0.1-py3-none-any.whl (12 kB)
Collecting typed-ast==1.5.4 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 81))
  Downloading typed_ast-1.5.4-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (877 kB)
  Downloading typed_ast-1.5.4-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (877 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 877.7/877.7 kB 64.2 MB/s eta 0:00:00
Collecting typing-extensions==4.6.3 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 107))
  Downloading typing_extensions-4.6.3-py3-none-any.whl (31 kB)
Collecting zipp==3.15.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 114))
  Downloading zipp-3.15.0-py3-none-any.whl (6.8 kB)
Installing collected packages: zipp, typing-extensions, typed-ast, tomli, ruff, platformdirs, pathspec, packaging, mypy-extensions, click, importlib-metadata, black
Successfully installed black-23.3.0 click-8.1.3 importlib-metadata-6.7.0 mypy-extensions-1.0.0 packaging-23.1 pathspec-0.11.1 platformdirs-3.6.0 ruff-0.0.272 tomli-2.0.1 typed-ast-1.5.4 typing-extensions-4.6.3 zipp-3.15.0
some tidy checks failed
Build completed unsuccessfully in 0:01:02
  local time: Fri Mar  8 11:47:34 UTC 2024
  network time: Fri, 08 Mar 2024 11:47:34 GMT

rust-log-analyzer avatar Mar 08 '24 11:03 rust-log-analyzer

@bors try @rust-timer queue

lcnr avatar Mar 08 '24 12:03 lcnr

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

rust-timer avatar Mar 08 '24 12:03 rust-timer

:hourglass: Trying commit a7c0ac3ec7fca5a3158ac27fc305062a674938fb with merge 970523ae018d571797bf189f91d970a093473cc3...

bors avatar Mar 08 '24 12:03 bors

:sunny: Try build successful - checks-actions Build commit: 970523ae018d571797bf189f91d970a093473cc3 (970523ae018d571797bf189f91d970a093473cc3)

bors avatar Mar 08 '24 13:03 bors

Queued 970523ae018d571797bf189f91d970a093473cc3 with parent 1b2c53a15dba7962cfc284c3b6d61a0341ffa27a, future comparison URL. There is currently 1 preceding artifact in the queue. It will probably take at least ~2.3 hours until the benchmark run finishes.

rust-timer avatar Mar 08 '24 13:03 rust-timer

Finished benchmarking commit (970523ae018d571797bf189f91d970a093473cc3): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never @rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.6% [0.2%, 0.8%] 3
Regressions ❌
(secondary)
0.9% [0.2%, 1.9%] 23
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.9% [-1.9%, -1.9%] 1
All ❌✅ (primary) 0.6% [0.2%, 0.8%] 3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-7.9% [-7.9%, -7.9%] 1
Improvements ✅
(secondary)
-4.6% [-5.3%, -3.9%] 2
All ❌✅ (primary) -7.9% [-7.9%, -7.9%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 652.903s -> 647.701s (-0.80%) Artifact size: 172.55 MiB -> 172.60 MiB (0.03%)

rust-timer avatar Mar 08 '24 18:03 rust-timer

@bors try @rust-timer queue

lcnr avatar Mar 08 '24 19:03 lcnr

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

rust-timer avatar Mar 08 '24 19:03 rust-timer

:hourglass: Trying commit 3e3df70b020fa9f13e8f8f0cf5b700f490602532 with merge c740aa46a93eb7b34946fe08c60f7907972fb505...

bors avatar Mar 08 '24 19:03 bors

:sunny: Try build successful - checks-actions Build commit: c740aa46a93eb7b34946fe08c60f7907972fb505 (c740aa46a93eb7b34946fe08c60f7907972fb505)

bors avatar Mar 08 '24 21:03 bors

Queued c740aa46a93eb7b34946fe08c60f7907972fb505 with parent 74acabe9b042ea8c42862ee29aca2a8b7d333644, future comparison URL. There is currently 1 preceding artifact in the queue. It will probably take at least ~2.3 hours until the benchmark run finishes.

rust-timer avatar Mar 08 '24 21:03 rust-timer

Finished benchmarking commit (c740aa46a93eb7b34946fe08c60f7907972fb505): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never @rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.2%, 0.5%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.6% [5.0%, 6.2%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 648.792s -> 648.87s (0.01%) Artifact size: 172.56 MiB -> 172.56 MiB (0.00%)

rust-timer avatar Mar 08 '24 23:03 rust-timer

This probably allows us to fix all these issues: https://github.com/rust-lang/rust/issues?q=is%3Aissue+is%3Aopen+%22index+out+of+bounds%22+%22snapshot_vec.rs%22+label%3AI-ICE

Thanks @matthiaskrgr for the list

oli-obk avatar Mar 09 '24 12:03 oli-obk

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Getting action download info
Download action repository 'msys2/[email protected]' (SHA:cc11e9188b693c2b100158c3322424c4cc1dadea)
Download action repository 'actions/checkout@v4' (SHA:b4ffde65f46336ab88eb53be808477a3936bae11)
Download action repository 'actions/upload-artifact@v3' (SHA:a8a3f3ad30e3422c9c7b888a15615d19a852ae32)
Complete job name: PR - mingw-check-tidy
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
COPY scripts/sccache.sh /scripts/
RUN sh /scripts/sccache.sh

COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt \
    && pip3 install virtualenv
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---

#10 [5/8] COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
#10 DONE 0.0s

#11 [6/8] RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt     && pip3 install virtualenv
#11 0.687   Downloading binaryornot-0.4.4-py2.py3-none-any.whl (9.0 kB)
#11 0.783 Collecting boolean-py==4.0
#11 0.794   Downloading boolean.py-4.0-py3-none-any.whl (25 kB)
#11 0.814 Collecting chardet==5.1.0
---
#11 4.134 Building wheels for collected packages: reuse
#11 4.134   Building wheel for reuse (pyproject.toml): started
#11 4.462   Building wheel for reuse (pyproject.toml): finished with status 'done'
#11 4.463   Created wheel for reuse: filename=reuse-1.1.0-cp310-cp310-manylinux_2_35_x86_64.whl size=181117 sha256=f5f58750481f69515c2c0d1d503daf565e2565c370d07fc6aeb95fe3498b4269
#11 4.463   Stored in directory: /tmp/pip-ephem-wheel-cache-2820kn0i/wheels/c2/3c/b9/1120c2ab4bd82694f7e6f0537dc5b9a085c13e2c69a8d0c76d
#11 4.466 Installing collected packages: boolean-py, binaryornot, setuptools, reuse, python-debian, markupsafe, license-expression, jinja2, chardet
#11 4.487   Attempting uninstall: setuptools
#11 4.488     Found existing installation: setuptools 59.6.0
#11 4.489     Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
---
#11 5.758   Downloading virtualenv-20.25.1-py3-none-any.whl (3.8 MB)
#11 5.833      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.8/3.8 MB 52.0 MB/s eta 0:00:00
#11 5.890 Collecting filelock<4,>=3.12.2
#11 5.900   Downloading filelock-3.13.1-py3-none-any.whl (11 kB)
#11 5.936 Collecting platformdirs<5,>=3.9.1
#11 5.947   Downloading platformdirs-4.2.0-py3-none-any.whl (17 kB)
#11 5.970 Collecting distlib<1,>=0.3.7
#11 5.980   Downloading distlib-0.3.8-py2.py3-none-any.whl (468 kB)
#11 5.986      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 468.9/468.9 KB 125.7 MB/s eta 0:00:00
#11 6.071 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#11 6.234 Successfully installed distlib-0.3.8 filelock-3.13.1 platformdirs-4.2.0 virtualenv-20.25.1
#11 DONE 6.3s

#12 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#12 DONE 0.0s
---
DirectMap4k:      165824 kB
DirectMap2M:     7174144 kB
DirectMap1G:    11534336 kB
##[endgroup]
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
    Finished dev [unoptimized] target(s) in 0.03s
##[endgroup]
downloading https://ci-artifacts.rust-lang.org/rustc-builds-alt/66396725541ac7920439876fc79cbc7b604b82e0/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/llvm-66396725541ac7920439876fc79cbc7b604b82e0-true/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm
---
   Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
    Finished release [optimized] target(s) in 27.66s
##[endgroup]
fmt check
##[error]Diff in /checkout/compiler/rustc_infer/src/infer/snapshot/check_leaks.rs at line 131:
 #[macro_export]
 #[cfg(not(debug_assertions))]
 macro_rules! type_foldable_verify_no_snapshot_leaks {
-    ($tcx:lifetime, $t:ty) => { trivial_no_snapshot_leaks!($tcx, $t) };
+    ($tcx:lifetime, $t:ty) => {
+        trivial_no_snapshot_leaks!($tcx, $t)
 }
 
 
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt/bin/rustfmt" "--config-path" "/checkout" "--edition" "2021" "--unstable-features" "--skip-children" "--check" "/checkout/compiler/rustc_infer/src/infer/snapshot/mod.rs" "/checkout/compiler/rustc_infer/src/infer/snapshot/undo_log.rs" "/checkout/src/tools/rust-installer/src/generator.rs" "/checkout/compiler/rustc_infer/src/infer/snapshot/check_leaks.rs" "/checkout/src/tools/rust-installer/src/compression.rs" "/checkout/src/tools/rust-installer/src/util.rs" "/checkout/src/tools/rust-installer/src/combiner.rs" "/checkout/src/tools/rust-installer/src/lib.rs" "/checkout/src/tools/rust-installer/src/main.rs" "/checkout/src/tools/rust-installer/src/scripter.rs" "/checkout/src/tools/rust-installer/src/tarballer.rs" "/checkout/compiler/rustc_infer/src/infer/region_constraints/leak_check.rs" "/checkout/compiler/rustc_infer/src/infer/region_constraints/mod.rs" "/checkout/compiler/rustc_infer/src/infer/type_variable.rs" "/checkout/compiler/rustc_infer/src/infer/error_reporting/note.rs" "/checkout/compiler/rustc_infer/src/infer/error_reporting/note_and_explain.rs" "/checkout/compiler/rustc_infer/src/infer/error_reporting/suggest.rs" "/checkout/compiler/rustc_infer/src/infer/error_reporting/nice_region_error/placeholder_error.rs" "/checkout/compiler/rustc_infer/src/infer/error_reporting/nice_region_error/util.rs" "/checkout/compiler/rustc_infer/src/infer/error_reporting/nice_region_error/mod.rs" "/checkout/compiler/rustc_infer/src/infer/error_reporting/nice_region_error/mismatched_static_lifetime.rs" "/checkout/compiler/rustc_infer/src/infer/error_reporting/nice_region_error/different_lifetimes.rs" "/checkout/compiler/rustc_infer/src/infer/error_reporting/nice_region_error/named_anon_conflict.rs" "/checkout/compiler/rustc_infer/src/infer/error_reporting/nice_region_error/find_anon_type.rs" "/checkout/compiler/rustc_infer/src/infer/error_reporting/nice_region_error/static_impl_trait.rs" "/checkout/compiler/rustc_infer/src/infer/error_reporting/nice_region_error/trait_impl_difference.rs" "/checkout/compiler/rustc_infer/src/infer/error_reporting/nice_region_error/placeholder_relation.rs" "/checkout/compiler/rustc_infer/src/infer/error_reporting/mod.rs" "/checkout/compiler/rustc_infer/src/infer/error_reporting/need_type_info.rs" "/checkout/compiler/rustc_infer/src/infer/error_reporting/sub_relations.rs" "/checkout/compiler/rustc_infer/src/infer/mod.rs" "/checkout/compiler/rustc_infer/src/infer/projection.rs" "/checkout/compiler/rustc_infer/src/infer/at.rs" "/checkout/compiler/rustc_infer/src/infer/lexical_region_resolve/mod.rs" "/checkout/compiler/rustc_infer/src/infer/canonical/instantiate.rs" "/checkout/compiler/rustc_infer/src/infer/canonical/mod.rs" "/checkout/compiler/rustc_infer/src/infer/canonical/query_response.rs" "/checkout/compiler/rustc_infer/src/infer/canonical/canonicalizer.rs" "/checkout/compiler/rustc_infer/src/infer/resolve.rs" "/checkout/src/tools/linkchecker/tests/checks.rs" "/checkout/compiler/rustc_infer/src/infer/outlives/env.rs" "/checkout/compiler/rustc_infer/src/infer/outlives/mod.rs" "/checkout/compiler/rustc_infer/src/infer/outlives/verify.rs" "/checkout/compiler/rustc_infer/src/infer/outlives/components.rs" "/checkout/compiler/rustc_infer/src/infer/outlives/test_type_match.rs" "/checkout/compiler/rustc_infer/src/infer/outlives/obligations.rs" "/checkout/compiler/rustc_infer/src/infer/outlives/for_liveness.rs" "/checkout/compiler/rustc_infer/src/infer/freshen.rs" "/checkout/compiler/rustc_infer/src/infer/opaque_types/table.rs" "/checkout/compiler/rustc_infer/src/infer/opaque_types/mod.rs" "/checkout/src/tools/linkchecker/main.rs" "/checkout/compiler/rustc_infer/src/infer/relate/generalize.rs" "/checkout/compiler/rustc_infer/src/infer/relate/higher_ranked.rs" "/checkout/compiler/rustc_infer/src/infer/relate/glb.rs" "/checkout/compiler/rustc_infer/src/infer/relate/mod.rs" "/checkout/compiler/rustc_infer/src/infer/relate/type_relating.rs" "/checkout/compiler/rustc_infer/src/infer/relate/lub.rs" "/checkout/compiler/rustc_infer/src/infer/relate/combine.rs" "/checkout/compiler/rustc_infer/src/infer/relate/lattice.rs" "/checkout/src/tools/build-manifest/src/manifest.rs" "/checkout/src/tools/build-manifest/src/versions.rs" "/checkout/src/tools/build-manifest/src/checksum.rs" "/checkout/src/tools/build-manifest/src/main.rs" "/checkout/compiler/rustc_infer/src/infer/snapshot/fudge.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
  local time: Mon Mar 11 10:49:58 UTC 2024
  network time: Mon, 11 Mar 2024 10:49:58 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

rust-log-analyzer avatar Mar 11 '24 10:03 rust-log-analyzer

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#13 4.045 Building wheels for collected packages: reuse
#13 4.046   Building wheel for reuse (pyproject.toml): started
#13 4.376   Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 4.377   Created wheel for reuse: filename=reuse-1.1.0-cp310-cp310-manylinux_2_35_x86_64.whl size=181117 sha256=f5f58750481f69515c2c0d1d503daf565e2565c370d07fc6aeb95fe3498b4269
#13 4.377   Stored in directory: /tmp/pip-ephem-wheel-cache-jqrxrvve/wheels/c2/3c/b9/1120c2ab4bd82694f7e6f0537dc5b9a085c13e2c69a8d0c76d
#13 4.380 Installing collected packages: boolean-py, binaryornot, setuptools, reuse, python-debian, markupsafe, license-expression, jinja2, chardet
#13 4.402   Attempting uninstall: setuptools
#13 4.403     Found existing installation: setuptools 59.6.0
#13 4.404     Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
---
    Checking dissimilar v1.0.7
    Checking expect-test v1.4.1
    Checking rustc_infer v0.0.0 (/checkout/compiler/rustc_infer)
    Checking rustc_metadata v0.0.0 (/checkout/compiler/rustc_metadata)
error: macros that expand to items must be delimited with braces or followed by a semicolon
   --> compiler/rustc_infer/src/infer/snapshot/check_leaks.rs:135:35
133 | / macro_rules! type_foldable_verify_no_snapshot_leaks {
133 | / macro_rules! type_foldable_verify_no_snapshot_leaks {
134 | |     ($tcx:lifetime, $t:ty) => {
135 | |         trivial_no_snapshot_leaks!($tcx, $t)
136 | |     };
137 | | }
    | |_- in this expansion of `type_foldable_verify_no_snapshot_leaks!`
    |
    |
   ::: compiler/rustc_infer/src/infer/snapshot/mod.rs:207:5
    |
207 |       type_foldable_verify_no_snapshot_leaks!('tcx, ty::PolyFnSig<'tcx>);

error: could not compile `rustc_infer` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
Build completed unsuccessfully in 0:01:54

rust-log-analyzer avatar Mar 11 '24 11:03 rust-log-analyzer

@rustbot ready

lcnr avatar Mar 11 '24 11:03 lcnr

no tests?

matthiaskrgr avatar Mar 11 '24 11:03 matthiaskrgr

forgot that this actually fixes stuff :sweat_smile: adding them

lcnr avatar Mar 11 '24 11:03 lcnr

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    Checking dissimilar v1.0.7
    Checking expect-test v1.4.1
    Checking rustc_infer v0.0.0 (/checkout/compiler/rustc_infer)
    Checking rustc_mir_dataflow v0.0.0 (/checkout/compiler/rustc_mir_dataflow)
error: macros that expand to items must be delimited with braces or followed by a semicolon
   --> compiler/rustc_infer/src/infer/snapshot/check_leaks.rs:138:35
136 | / macro_rules! type_foldable_verify_no_snapshot_leaks {
136 | / macro_rules! type_foldable_verify_no_snapshot_leaks {
137 | |     ($tcx:lifetime, $t:ty) => {
138 | |         trivial_no_snapshot_leaks!($tcx, $t)
139 | |     };
140 | | }
    | |_- in this expansion of `type_foldable_verify_no_snapshot_leaks!`
    |
    |
   ::: compiler/rustc_infer/src/infer/snapshot/mod.rs:233:5
    |
233 |       type_foldable_verify_no_snapshot_leaks!('tcx, ty::PolyFnSig<'tcx>);

    Checking rustc_metadata v0.0.0 (/checkout/compiler/rustc_metadata)
error: could not compile `rustc_infer` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

rust-log-analyzer avatar Mar 11 '24 11:03 rust-log-analyzer

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Getting action download info
Download action repository 'msys2/[email protected]' (SHA:cc11e9188b693c2b100158c3322424c4cc1dadea)
Download action repository 'actions/checkout@v4' (SHA:b4ffde65f46336ab88eb53be808477a3936bae11)
Download action repository 'actions/upload-artifact@v3' (SHA:a8a3f3ad30e3422c9c7b888a15615d19a852ae32)
Complete job name: PR - mingw-check-tidy
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
COPY scripts/sccache.sh /scripts/
RUN sh /scripts/sccache.sh

COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt \
    && pip3 install virtualenv
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---

#10 [5/8] COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
#10 DONE 0.0s

#11 [6/8] RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt     && pip3 install virtualenv
#11 0.560   Downloading binaryornot-0.4.4-py2.py3-none-any.whl (9.0 kB)
#11 0.575 Collecting boolean-py==4.0
#11 0.582   Downloading boolean.py-4.0-py3-none-any.whl (25 kB)
#11 0.599 Collecting chardet==5.1.0
---
#11 3.641 Building wheels for collected packages: reuse
#11 3.642   Building wheel for reuse (pyproject.toml): started
#11 3.970   Building wheel for reuse (pyproject.toml): finished with status 'done'
#11 3.971   Created wheel for reuse: filename=reuse-1.1.0-cp310-cp310-manylinux_2_35_x86_64.whl size=181117 sha256=f5f58750481f69515c2c0d1d503daf565e2565c370d07fc6aeb95fe3498b4269
#11 3.971   Stored in directory: /tmp/pip-ephem-wheel-cache-ydtie4cy/wheels/c2/3c/b9/1120c2ab4bd82694f7e6f0537dc5b9a085c13e2c69a8d0c76d
#11 3.974 Installing collected packages: boolean-py, binaryornot, setuptools, reuse, python-debian, markupsafe, license-expression, jinja2, chardet
#11 3.994   Attempting uninstall: setuptools
#11 3.995     Found existing installation: setuptools 59.6.0
#11 3.999     Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
#11 3.999     Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
#11 3.999     Can't uninstall 'setuptools'. No files were found to uninstall.
#11 4.653 Successfully installed binaryornot-0.4.4 boolean-py-4.0 chardet-5.1.0 jinja2-3.1.2 license-expression-30.0.0 markupsafe-2.1.1 python-debian-0.1.49 reuse-1.1.0 setuptools-66.0.0
#11 4.654 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#11 5.169 Collecting virtualenv
#11 5.215   Downloading virtualenv-20.25.1-py3-none-any.whl (3.8 MB)
#11 5.385      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.8/3.8 MB 22.4 MB/s eta 0:00:00
#11 5.424 Collecting distlib<1,>=0.3.7
#11 5.431   Downloading distlib-0.3.8-py2.py3-none-any.whl (468 kB)
#11 5.474 Collecting filelock<4,>=3.12.2
#11 5.481   Downloading filelock-3.13.1-py3-none-any.whl (11 kB)
#11 5.481   Downloading filelock-3.13.1-py3-none-any.whl (11 kB)
#11 5.515 Collecting platformdirs<5,>=3.9.1
#11 5.522   Downloading platformdirs-4.2.0-py3-none-any.whl (17 kB)
#11 5.607 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#11 5.769 Successfully installed distlib-0.3.8 filelock-3.13.1 platformdirs-4.2.0 virtualenv-20.25.1
#11 DONE 5.8s

#12 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#12 DONE 0.0s
---
DirectMap4k:      188352 kB
DirectMap2M:     7151616 kB
DirectMap1G:    11534336 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
    Finished dev [unoptimized] target(s) in 0.03s
##[endgroup]
downloading https://ci-artifacts.rust-lang.org/rustc-builds-alt/66396725541ac7920439876fc79cbc7b604b82e0/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/llvm-66396725541ac7920439876fc79cbc7b604b82e0-true/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm
---
    Finished release [optimized] target(s) in 27.03s
##[endgroup]
fmt check
tidy check
tidy error: `ROOT_ENTRY_LIMIT` is too high (is 866, should be 865)
tidy error: file `tests/ui/traits/cycle-trait/issue-12511.rs` must begin with a descriptive name, consider `{reason}-issue-12511.rs`
tidy error: file `/checkout/tests/ui/cycle-trait/issue-12511.rs` no longer exists and should be removed from the exclusions in `src/tools/tidy/src/issues.txt`
removing old virtual environment
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10'
Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (24.0)
Collecting black==23.3.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 7))
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.7/1.7 MB 16.1 MB/s eta 0:00:00
Collecting click==8.1.3 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 34))
  Downloading click-8.1.3-py3-none-any.whl (96 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 96.6/96.6 kB 31.6 MB/s eta 0:00:00
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 96.6/96.6 kB 31.6 MB/s eta 0:00:00
Collecting importlib-metadata==6.7.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 38))
  Downloading importlib_metadata-6.7.0-py3-none-any.whl (22 kB)
Collecting mypy-extensions==1.0.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 42))
  Downloading mypy_extensions-1.0.0-py3-none-any.whl (4.7 kB)
Collecting packaging==23.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 46))
  Downloading packaging-23.1-py3-none-any.whl (48 kB)
Collecting pathspec==0.11.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 50))
  Downloading pathspec-0.11.1-py3-none-any.whl (29 kB)
Collecting platformdirs==3.6.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 54))
  Downloading platformdirs-3.6.0-py3-none-any.whl (16 kB)
  Downloading platformdirs-3.6.0-py3-none-any.whl (16 kB)
Collecting ruff==0.0.272 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 58))
  Downloading ruff-0.0.272-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (5.9 MB)
Collecting tomli==2.0.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 77))
  Downloading tomli-2.0.1-py3-none-any.whl (12 kB)
Collecting typed-ast==1.5.4 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 81))
  Downloading typed_ast-1.5.4-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (877 kB)
  Downloading typed_ast-1.5.4-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (877 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 877.7/877.7 kB 75.3 MB/s eta 0:00:00
Collecting typing-extensions==4.6.3 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 107))
  Downloading typing_extensions-4.6.3-py3-none-any.whl (31 kB)
Collecting zipp==3.15.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 114))
  Downloading zipp-3.15.0-py3-none-any.whl (6.8 kB)
Installing collected packages: zipp, typing-extensions, typed-ast, tomli, ruff, platformdirs, pathspec, packaging, mypy-extensions, click, importlib-metadata, black
Successfully installed black-23.3.0 click-8.1.3 importlib-metadata-6.7.0 mypy-extensions-1.0.0 packaging-23.1 pathspec-0.11.1 platformdirs-3.6.0 ruff-0.0.272 tomli-2.0.1 typed-ast-1.5.4 typing-extensions-4.6.3 zipp-3.15.0
some tidy checks failed
Build completed unsuccessfully in 0:01:02
  local time: Mon Mar 11 12:02:58 UTC 2024
  network time: Mon, 11 Mar 2024 12:02:58 GMT

rust-log-analyzer avatar Mar 11 '24 12:03 rust-log-analyzer

most other tests have a different root cause. I have not yet fixed method probing as that's non-trivial. Leaving that for future PRs

lcnr avatar Mar 11 '24 12:03 lcnr

@bors r+

I wonder if we can come up with a scheme (that doesn't make all snapshot methods really annoying to use), which also prevents storing types into storage borrowed in the snapshot closure.

oli-obk avatar Mar 11 '24 17:03 oli-obk

:pushpin: Commit b0ad8d78fe7f264409355c1dc0283697d3904a5b has been approved by oli-obk

It is now in the queue for this repository.

bors avatar Mar 11 '24 17:03 bors

:hourglass: Testing commit b0ad8d78fe7f264409355c1dc0283697d3904a5b with merge 2a4b3fd1cabcae13a4e3da1b42ee80af382dcc57...

bors avatar Mar 12 '24 12:03 bors

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    | |_____- in this macro invocation
    |
    = note: this warning originates in the macro `__static_cond` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info)

thread 'rustc' panicked at compiler/rustc_infer/src/infer/snapshot/fudge.rs:262:21:
assertion failed: self.infcx.inner.borrow_mut().type_variables().probe(vid).is_unknown()
   0:     0x7fba40aa96e7 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h32e11376057b68c5
   1:     0x7fba40b02327 - core::fmt::write::hde52406d68b0ad39
   2:     0x7fba40a9e155 - std::io::Write::write_fmt::h17780cc0bff3e4aa
   3:     0x7fba40aa94b4 - std::sys_common::backtrace::print::h7d07cf253e680a1c
   3:     0x7fba40aa94b4 - std::sys_common::backtrace::print::h7d07cf253e680a1c
   4:     0x7fba40aac4f3 - std::panicking::default_hook::{{closure}}::h375c425cebe2c3b9
   5:     0x7fba40aac209 - std::panicking::default_hook::h228d56a82c790dc4
   6:     0x7fba4166a2d6 - <alloc[3104433ab66c8f19]::boxed::Box<rustc_driver_impl[ef2bbe5f1dee9789]::install_ice_hook::{closure#0}> as core[c5845d8d53ed6e15]::ops::function::Fn<(&dyn for<'a, 'b> core[c5845d8d53ed6e15]::ops::function::Fn<(&'a core[c5845d8d53ed6e15]::panic::panic_info::PanicInfo<'b>,), Output = ()> + core[c5845d8d53ed6e15]::marker::Sync + core[c5845d8d53ed6e15]::marker::Send, &core[c5845d8d53ed6e15]::panic::panic_info::PanicInfo)>>::call
   8:     0x7fba40aac8f9 - std::panicking::begin_panic_handler::{{closure}}::h7498b16000807539
   9:     0x7fba40aa9cc6 - std::sys_common::backtrace::__rust_end_short_backtrace::hbbbfd3254f73cd72
  10:     0x7fba40aac6b4 - rust_begin_unwind
  11:     0x7fba40a65815 - core::panicking::panic_fmt::h233ad23b8687456c
  11:     0x7fba40a65815 - core::panicking::panic_fmt::h233ad23b8687456c
  12:     0x7fba40a658d3 - core::panicking::panic::h6af28e0088691225
  13:     0x7fba43e4182e - <rustc_infer[6e527f8f418f7491]::infer::snapshot::fudge::InferenceFudger as rustc_type_ir[56caf5263b542535]::fold::TypeFolder<rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt>>::fold_ty
  14:     0x7fba43e0725b - rustc_middle[a28fe5db212b793e]::ty::util::fold_list::<rustc_infer[6e527f8f418f7491]::infer::snapshot::fudge::InferenceFudger, rustc_middle[a28fe5db212b793e]::ty::generic_args::GenericArg, <&rustc_middle[a28fe5db212b793e]::ty::list::List<rustc_middle[a28fe5db212b793e]::ty::generic_args::GenericArg> as rustc_type_ir[56caf5263b542535]::fold::TypeFoldable<rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt>>::try_fold_with<rustc_infer[6e527f8f418f7491]::infer::snapshot::fudge::InferenceFudger>::{closure#0}>
  15:     0x7fba43db39d5 - <rustc_middle[a28fe5db212b793e]::ty::Ty as rustc_type_ir[56caf5263b542535]::fold::TypeSuperFoldable<rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt>>::try_super_fold_with::<rustc_infer[6e527f8f418f7491]::infer::snapshot::fudge::InferenceFudger>
  16:     0x7fba43e4e675 - <rustc_middle[a28fe5db212b793e]::ty::error::TypeError as rustc_type_ir[56caf5263b542535]::fold::TypeFoldable<rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt>>::try_fold_with::<rustc_infer[6e527f8f418f7491]::infer::snapshot::fudge::InferenceFudger>
  17:     0x7fba43e4702c - <rustc_infer[6e527f8f418f7491]::traits::project::MismatchedProjectionTypes as rustc_infer[6e527f8f418f7491]::infer::snapshot::NoSnapshotLeaks>::avoid_leaks
  18:     0x7fba43b64ff0 - <rustc_infer[6e527f8f418f7491]::infer::InferCtxt>::commit_if_ok::<rustc_trait_selection[269248504fd2e6db]::traits::project::ProjectAndUnifyResult, rustc_infer[6e527f8f418f7491]::traits::project::MismatchedProjectionTypes, rustc_trait_selection[269248504fd2e6db]::traits::project::poly_project_and_unify_type::{closure#0}>
  19:     0x7fba4393f1d4 - rustc_trait_selection[269248504fd2e6db]::traits::project::poly_project_and_unify_type
  20:     0x7fba439f92e3 - <rustc_trait_selection[269248504fd2e6db]::traits::select::SelectionContext>::evaluate_predicate_recursively
  21:     0x7fba43b67fa7 - <rustc_infer[6e527f8f418f7491]::infer::InferCtxt>::probe::<core[c5845d8d53ed6e15]::result::Result<rustc_middle[a28fe5db212b793e]::traits::select::EvaluationResult, rustc_middle[a28fe5db212b793e]::traits::select::OverflowError>, <rustc_trait_selection[269248504fd2e6db]::traits::select::SelectionContext>::evaluation_probe<<rustc_trait_selection[269248504fd2e6db]::traits::select::SelectionContext>::evaluate_root_obligation::{closure#0}>::{closure#0}>
  22:     0x7fba43a2c3e5 - rustc_trait_selection[269248504fd2e6db]::traits::coherence::overlap
  23:     0x7fba43a2b38e - rustc_trait_selection[269248504fd2e6db]::traits::coherence::overlapping_impls
  24:     0x7fba43a61afd - <rustc_middle[a28fe5db212b793e]::traits::specialization_graph::Children as rustc_trait_selection[269248504fd2e6db]::traits::specialize::specialization_graph::ChildrenExt>::insert
  25:     0x7fba43a634e3 - <rustc_middle[a28fe5db212b793e]::traits::specialization_graph::Graph as rustc_trait_selection[269248504fd2e6db]::traits::specialize::specialization_graph::GraphExt>::insert
  26:     0x7fba43b3f081 - rustc_trait_selection[269248504fd2e6db]::traits::specialize::specialization_graph_provider
  27:     0x7fba4335602a - rustc_query_impl[315a33b46a6b89bb]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[315a33b46a6b89bb]::query_impl::specialization_graph_of::dynamic_query::{closure#2}::{closure#0}, rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 8usize]>>
  28:     0x7fba436653d9 - <rustc_query_impl[315a33b46a6b89bb]::query_impl::specialization_graph_of::dynamic_query::{closure#2} as core[c5845d8d53ed6e15]::ops::function::FnOnce<(rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt, rustc_span[c94123ca65beb6eb]::def_id::DefId)>>::call_once
  29:     0x7fba436d66bf - rustc_query_system[205d08e60b1a92a0]::query::plumbing::try_execute_query::<rustc_query_impl[315a33b46a6b89bb]::DynamicConfig<rustc_query_system[205d08e60b1a92a0]::query::caches::DefIdCache<rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 8usize]>>, false, false, false>, rustc_query_impl[315a33b46a6b89bb]::plumbing::QueryCtxt, true>
  30:     0x7fba4367b026 - rustc_query_impl[315a33b46a6b89bb]::query_impl::specialization_graph_of::get_query_incr::__rust_end_short_backtrace
  31:     0x7fba41eed0f3 - rustc_hir_analysis[1b3367767695ca72]::coherence::coherent_trait
  32:     0x7fba4334008a - rustc_query_impl[315a33b46a6b89bb]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[315a33b46a6b89bb]::query_impl::coherent_trait::dynamic_query::{closure#2}::{closure#0}, rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>
  33:     0x7fba43617b19 - <rustc_query_impl[315a33b46a6b89bb]::query_impl::coherent_trait::dynamic_query::{closure#2} as core[c5845d8d53ed6e15]::ops::function::FnOnce<(rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt, rustc_span[c94123ca65beb6eb]::def_id::DefId)>>::call_once
  34:     0x7fba436c8b70 - rustc_query_system[205d08e60b1a92a0]::query::plumbing::try_execute_query::<rustc_query_impl[315a33b46a6b89bb]::DynamicConfig<rustc_query_system[205d08e60b1a92a0]::query::caches::DefIdCache<rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[315a33b46a6b89bb]::plumbing::QueryCtxt, true>
  35:     0x7fba435bbf7e - rustc_query_impl[315a33b46a6b89bb]::query_impl::coherent_trait::get_query_incr::__rust_end_short_backtrace
  36:     0x7fba420db272 - rustc_middle[a28fe5db212b793e]::query::plumbing::query_ensure_error_guaranteed::<rustc_query_system[205d08e60b1a92a0]::query::caches::DefIdCache<rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>, ()>
  37:     0x7fba420e81bb - rustc_hir_analysis[1b3367767695ca72]::check::wfcheck::enter_wf_checking_ctxt::<rustc_hir_analysis[1b3367767695ca72]::check::wfcheck::check_impl::{closure#0}>
  38:     0x7fba420ed8e9 - rustc_hir_analysis[1b3367767695ca72]::check::wfcheck::check_well_formed
  39:     0x7fba43347ca5 - rustc_query_impl[315a33b46a6b89bb]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[315a33b46a6b89bb]::query_impl::check_well_formed::dynamic_query::{closure#2}::{closure#0}, rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>
  40:     0x7fba4361c1f5 - <rustc_query_impl[315a33b46a6b89bb]::query_impl::check_well_formed::dynamic_query::{closure#2} as core[c5845d8d53ed6e15]::ops::function::FnOnce<(rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt, rustc_hir[9476a13e5c9b3903]::hir_id::OwnerId)>>::call_once
  41:     0x7fba4377fb2a - rustc_query_system[205d08e60b1a92a0]::query::plumbing::try_execute_query::<rustc_query_impl[315a33b46a6b89bb]::DynamicConfig<rustc_query_system[205d08e60b1a92a0]::query::caches::VecCache<rustc_hir[9476a13e5c9b3903]::hir_id::OwnerId, rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[315a33b46a6b89bb]::plumbing::QueryCtxt, true>
  42:     0x7fba4363355a - rustc_query_impl[315a33b46a6b89bb]::query_impl::check_well_formed::get_query_incr::__rust_end_short_backtrace
  43:     0x7fba41fe2054 - rustc_middle[a28fe5db212b793e]::query::plumbing::query_ensure_error_guaranteed::<rustc_query_system[205d08e60b1a92a0]::query::caches::VecCache<rustc_hir[9476a13e5c9b3903]::hir_id::OwnerId, rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>, ()>
  44:     0x7fba41f41bef - <rustc_middle[a28fe5db212b793e]::hir::ModuleItems>::par_items::<rustc_hir_analysis[1b3367767695ca72]::check::wfcheck::check_mod_type_wf::{closure#0}>
  45:     0x7fba420fae10 - rustc_hir_analysis[1b3367767695ca72]::check::wfcheck::check_mod_type_wf
  46:     0x7fba43347ac5 - rustc_query_impl[315a33b46a6b89bb]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[315a33b46a6b89bb]::query_impl::check_mod_type_wf::dynamic_query::{closure#2}::{closure#0}, rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>
  47:     0x7fba4361bd45 - <rustc_query_impl[315a33b46a6b89bb]::query_impl::check_mod_type_wf::dynamic_query::{closure#2} as core[c5845d8d53ed6e15]::ops::function::FnOnce<(rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt, rustc_span[c94123ca65beb6eb]::def_id::LocalModDefId)>>::call_once
  48:     0x7fba43734e48 - rustc_query_system[205d08e60b1a92a0]::query::plumbing::try_execute_query::<rustc_query_impl[315a33b46a6b89bb]::DynamicConfig<rustc_query_system[205d08e60b1a92a0]::query::caches::DefaultCache<rustc_span[c94123ca65beb6eb]::def_id::LocalModDefId, rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[315a33b46a6b89bb]::plumbing::QueryCtxt, true>
  49:     0x7fba4367745a - rustc_query_impl[315a33b46a6b89bb]::query_impl::check_mod_type_wf::get_query_incr::__rust_end_short_backtrace
  50:     0x7fba41fe36c8 - <rustc_middle[a28fe5db212b793e]::hir::map::Map>::par_for_each_module::<rustc_hir_analysis[1b3367767695ca72]::check_crate::{closure#2}::{closure#0}>::{closure#0}
  51:     0x7fba41f6665c - rustc_hir_analysis[1b3367767695ca72]::check_crate
  52:     0x7fba418a8cbc - rustc_interface[13ad69ef859e6ed6]::passes::analysis
  53:     0x7fba4335eed3 - rustc_query_impl[315a33b46a6b89bb]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[315a33b46a6b89bb]::query_impl::analysis::dynamic_query::{closure#2}::{closure#0}, rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>
  54:     0x7fba43493991 - <rustc_query_impl[315a33b46a6b89bb]::query_impl::analysis::dynamic_query::{closure#2} as core[c5845d8d53ed6e15]::ops::function::FnOnce<(rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt, ())>>::call_once
  55:     0x7fba436e1abe - rustc_query_system[205d08e60b1a92a0]::query::plumbing::try_execute_query::<rustc_query_impl[315a33b46a6b89bb]::DynamicConfig<rustc_query_system[205d08e60b1a92a0]::query::caches::SingleCache<rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[315a33b46a6b89bb]::plumbing::QueryCtxt, true>
  56:     0x7fba4349948a - rustc_query_impl[315a33b46a6b89bb]::query_impl::analysis::get_query_incr::__rust_end_short_backtrace
  57:     0x7fba416d7817 - <rustc_middle[a28fe5db212b793e]::ty::context::GlobalCtxt>::enter::<rustc_driver_impl[ef2bbe5f1dee9789]::run_compiler::{closure#0}::{closure#1}::{closure#3}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>
  58:     0x7fba416363c6 - <rustc_interface[13ad69ef859e6ed6]::interface::Compiler>::enter::<rustc_driver_impl[ef2bbe5f1dee9789]::run_compiler::{closure#0}::{closure#1}, core[c5845d8d53ed6e15]::result::Result<core[c5845d8d53ed6e15]::option::Option<rustc_interface[13ad69ef859e6ed6]::queries::Linker>, rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>
  59:     0x7fba416f2eff - rustc_span[c94123ca65beb6eb]::set_source_map::<core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>, rustc_interface[13ad69ef859e6ed6]::interface::run_compiler<core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>, rustc_driver_impl[ef2bbe5f1dee9789]::run_compiler::{closure#0}>::{closure#0}::{closure#0}>
  60:     0x7fba416d5b0c - <scoped_tls[4a2e423e0a77ff]::ScopedKey<rustc_span[c94123ca65beb6eb]::SessionGlobals>>::set::<rustc_interface[13ad69ef859e6ed6]::util::run_in_thread_pool_with_globals<rustc_interface[13ad69ef859e6ed6]::interface::run_compiler<core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>, rustc_driver_impl[ef2bbe5f1dee9789]::run_compiler::{closure#0}>::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>
  61:     0x7fba416f3401 - rustc_span[c94123ca65beb6eb]::create_session_globals_then::<core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>, rustc_interface[13ad69ef859e6ed6]::util::run_in_thread_pool_with_globals<rustc_interface[13ad69ef859e6ed6]::interface::run_compiler<core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>, rustc_driver_impl[ef2bbe5f1dee9789]::run_compiler::{closure#0}>::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>::{closure#0}>
  62:     0x7fba4162b71e - std[4b907581ded592fa]::sys_common::backtrace::__rust_begin_short_backtrace::<rustc_interface[13ad69ef859e6ed6]::util::run_in_thread_with_globals<rustc_interface[13ad69ef859e6ed6]::util::run_in_thread_pool_with_globals<rustc_interface[13ad69ef859e6ed6]::interface::run_compiler<core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>, rustc_driver_impl[ef2bbe5f1dee9789]::run_compiler::{closure#0}>::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>
  63:     0x7fba416e1d21 - <<std[4b907581ded592fa]::thread::Builder>::spawn_unchecked_<rustc_interface[13ad69ef859e6ed6]::util::run_in_thread_with_globals<rustc_interface[13ad69ef859e6ed6]::util::run_in_thread_pool_with_globals<rustc_interface[13ad69ef859e6ed6]::interface::run_compiler<core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>, rustc_driver_impl[ef2bbe5f1dee9789]::run_compiler::{closure#0}>::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>::{closure#1} as core[c5845d8d53ed6e15]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  65:     0x7fba40883ac3 - <unknown>
  66:     0x7fba40915850 - <unknown>
  67:                0x0 - <unknown>


error: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: please attach the file at `/checkout/obj/build/ct/diesel/rustc-ice-2024-03-12T13_32_57-31824.txt` to your bug report

note: compiler flags: --crate-type lib -C embed-bitcode=no -C debuginfo=2 -C incremental=[REDACTED]
note: some of the compiler flags provided by cargo are hidden

query stack during panic:
query stack during panic:
#0 [specialization_graph_of] building specialization graph of trait `query_dsl::distinct_dsl::DistinctDsl`
#1 [coherent_trait] coherence checking all impls of trait `query_dsl::distinct_dsl::DistinctDsl`
#2 [check_well_formed] checking that `query_builder::select_statement::boxed::<impl at diesel/src/query_builder/select_statement/boxed.rs:170:1: 173:39>` is well-formed
#3 [check_mod_type_wf] checking that types are well-formed in module `query_builder::select_statement::boxed`
end of query stack
end of query stack
thread 'rustc' panicked at compiler/rustc_infer/src/infer/snapshot/fudge.rs:262:21:
assertion failed: self.infcx.inner.borrow_mut().type_variables().probe(vid).is_unknown()
   0:     0x7f91cb6a66e7 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h32e11376057b68c5
   1:     0x7f91cb6ff327 - core::fmt::write::hde52406d68b0ad39
   2:     0x7f91cb69b155 - std::io::Write::write_fmt::h17780cc0bff3e4aa
   3:     0x7f91cb6a64b4 - std::sys_common::backtrace::print::h7d07cf253e680a1c
   3:     0x7f91cb6a64b4 - std::sys_common::backtrace::print::h7d07cf253e680a1c
   4:     0x7f91cb6a94f3 - std::panicking::default_hook::{{closure}}::h375c425cebe2c3b9
   5:     0x7f91cb6a9209 - std::panicking::default_hook::h228d56a82c790dc4
   6:     0x7f91cc2672d6 - <alloc[3104433ab66c8f19]::boxed::Box<rustc_driver_impl[ef2bbe5f1dee9789]::install_ice_hook::{closure#0}> as core[c5845d8d53ed6e15]::ops::function::Fn<(&dyn for<'a, 'b> core[c5845d8d53ed6e15]::ops::function::Fn<(&'a core[c5845d8d53ed6e15]::panic::panic_info::PanicInfo<'b>,), Output = ()> + core[c5845d8d53ed6e15]::marker::Sync + core[c5845d8d53ed6e15]::marker::Send, &core[c5845d8d53ed6e15]::panic::panic_info::PanicInfo)>>::call
   8:     0x7f91cb6a98f9 - std::panicking::begin_panic_handler::{{closure}}::h7498b16000807539
   9:     0x7f91cb6a6cc6 - std::sys_common::backtrace::__rust_end_short_backtrace::hbbbfd3254f73cd72
  10:     0x7f91cb6a96b4 - rust_begin_unwind
  11:     0x7f91cb662815 - core::panicking::panic_fmt::h233ad23b8687456c
  11:     0x7f91cb662815 - core::panicking::panic_fmt::h233ad23b8687456c
  12:     0x7f91cb6628d3 - core::panicking::panic::h6af28e0088691225
  13:     0x7f91cea3e82e - <rustc_infer[6e527f8f418f7491]::infer::snapshot::fudge::InferenceFudger as rustc_type_ir[56caf5263b542535]::fold::TypeFolder<rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt>>::fold_ty
  14:     0x7f91cea0425b - rustc_middle[a28fe5db212b793e]::ty::util::fold_list::<rustc_infer[6e527f8f418f7491]::infer::snapshot::fudge::InferenceFudger, rustc_middle[a28fe5db212b793e]::ty::generic_args::GenericArg, <&rustc_middle[a28fe5db212b793e]::ty::list::List<rustc_middle[a28fe5db212b793e]::ty::generic_args::GenericArg> as rustc_type_ir[56caf5263b542535]::fold::TypeFoldable<rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt>>::try_fold_with<rustc_infer[6e527f8f418f7491]::infer::snapshot::fudge::InferenceFudger>::{closure#0}>
  15:     0x7f91ce9b09d5 - <rustc_middle[a28fe5db212b793e]::ty::Ty as rustc_type_ir[56caf5263b542535]::fold::TypeSuperFoldable<rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt>>::try_super_fold_with::<rustc_infer[6e527f8f418f7491]::infer::snapshot::fudge::InferenceFudger>
  16:     0x7f91cea4b675 - <rustc_middle[a28fe5db212b793e]::ty::error::TypeError as rustc_type_ir[56caf5263b542535]::fold::TypeFoldable<rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt>>::try_fold_with::<rustc_infer[6e527f8f418f7491]::infer::snapshot::fudge::InferenceFudger>
  17:     0x7f91cea4402c - <rustc_infer[6e527f8f418f7491]::traits::project::MismatchedProjectionTypes as rustc_infer[6e527f8f418f7491]::infer::snapshot::NoSnapshotLeaks>::avoid_leaks
  18:     0x7f91ce761ff0 - <rustc_infer[6e527f8f418f7491]::infer::InferCtxt>::commit_if_ok::<rustc_trait_selection[269248504fd2e6db]::traits::project::ProjectAndUnifyResult, rustc_infer[6e527f8f418f7491]::traits::project::MismatchedProjectionTypes, rustc_trait_selection[269248504fd2e6db]::traits::project::poly_project_and_unify_type::{closure#0}>
  19:     0x7f91ce53c1d4 - rustc_trait_selection[269248504fd2e6db]::traits::project::poly_project_and_unify_type
  20:     0x7f91ce5f62e3 - <rustc_trait_selection[269248504fd2e6db]::traits::select::SelectionContext>::evaluate_predicate_recursively
  21:     0x7f91ce764fa7 - <rustc_infer[6e527f8f418f7491]::infer::InferCtxt>::probe::<core[c5845d8d53ed6e15]::result::Result<rustc_middle[a28fe5db212b793e]::traits::select::EvaluationResult, rustc_middle[a28fe5db212b793e]::traits::select::OverflowError>, <rustc_trait_selection[269248504fd2e6db]::traits::select::SelectionContext>::evaluation_probe<<rustc_trait_selection[269248504fd2e6db]::traits::select::SelectionContext>::evaluate_root_obligation::{closure#0}>::{closure#0}>
  22:     0x7f91ce6293e5 - rustc_trait_selection[269248504fd2e6db]::traits::coherence::overlap
  23:     0x7f91ce62838e - rustc_trait_selection[269248504fd2e6db]::traits::coherence::overlapping_impls
  24:     0x7f91ce65eafd - <rustc_middle[a28fe5db212b793e]::traits::specialization_graph::Children as rustc_trait_selection[269248504fd2e6db]::traits::specialize::specialization_graph::ChildrenExt>::insert
  25:     0x7f91ce6604e3 - <rustc_middle[a28fe5db212b793e]::traits::specialization_graph::Graph as rustc_trait_selection[269248504fd2e6db]::traits::specialize::specialization_graph::GraphExt>::insert
  26:     0x7f91ce73c081 - rustc_trait_selection[269248504fd2e6db]::traits::specialize::specialization_graph_provider
  27:     0x7f91cdf5302a - rustc_query_impl[315a33b46a6b89bb]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[315a33b46a6b89bb]::query_impl::specialization_graph_of::dynamic_query::{closure#2}::{closure#0}, rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 8usize]>>
  28:     0x7f91ce2623d9 - <rustc_query_impl[315a33b46a6b89bb]::query_impl::specialization_graph_of::dynamic_query::{closure#2} as core[c5845d8d53ed6e15]::ops::function::FnOnce<(rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt, rustc_span[c94123ca65beb6eb]::def_id::DefId)>>::call_once
  29:     0x7f91ce2d36bf - rustc_query_system[205d08e60b1a92a0]::query::plumbing::try_execute_query::<rustc_query_impl[315a33b46a6b89bb]::DynamicConfig<rustc_query_system[205d08e60b1a92a0]::query::caches::DefIdCache<rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 8usize]>>, false, false, false>, rustc_query_impl[315a33b46a6b89bb]::plumbing::QueryCtxt, true>
  30:     0x7f91ce278026 - rustc_query_impl[315a33b46a6b89bb]::query_impl::specialization_graph_of::get_query_incr::__rust_end_short_backtrace
  31:     0x7f91ccaea0f3 - rustc_hir_analysis[1b3367767695ca72]::coherence::coherent_trait
  32:     0x7f91cdf3d08a - rustc_query_impl[315a33b46a6b89bb]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[315a33b46a6b89bb]::query_impl::coherent_trait::dynamic_query::{closure#2}::{closure#0}, rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>
  33:     0x7f91ce214b19 - <rustc_query_impl[315a33b46a6b89bb]::query_impl::coherent_trait::dynamic_query::{closure#2} as core[c5845d8d53ed6e15]::ops::function::FnOnce<(rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt, rustc_span[c94123ca65beb6eb]::def_id::DefId)>>::call_once
  34:     0x7f91ce2c5b70 - rustc_query_system[205d08e60b1a92a0]::query::plumbing::try_execute_query::<rustc_query_impl[315a33b46a6b89bb]::DynamicConfig<rustc_query_system[205d08e60b1a92a0]::query::caches::DefIdCache<rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[315a33b46a6b89bb]::plumbing::QueryCtxt, true>
  35:     0x7f91ce1b8f7e - rustc_query_impl[315a33b46a6b89bb]::query_impl::coherent_trait::get_query_incr::__rust_end_short_backtrace
  36:     0x7f91cccd8272 - rustc_middle[a28fe5db212b793e]::query::plumbing::query_ensure_error_guaranteed::<rustc_query_system[205d08e60b1a92a0]::query::caches::DefIdCache<rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>, ()>
  37:     0x7f91ccce51bb - rustc_hir_analysis[1b3367767695ca72]::check::wfcheck::enter_wf_checking_ctxt::<rustc_hir_analysis[1b3367767695ca72]::check::wfcheck::check_impl::{closure#0}>
  38:     0x7f91cccea8e9 - rustc_hir_analysis[1b3367767695ca72]::check::wfcheck::check_well_formed
  39:     0x7f91cdf44ca5 - rustc_query_impl[315a33b46a6b89bb]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[315a33b46a6b89bb]::query_impl::check_well_formed::dynamic_query::{closure#2}::{closure#0}, rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>
  40:     0x7f91ce2191f5 - <rustc_query_impl[315a33b46a6b89bb]::query_impl::check_well_formed::dynamic_query::{closure#2} as core[c5845d8d53ed6e15]::ops::function::FnOnce<(rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt, rustc_hir[9476a13e5c9b3903]::hir_id::OwnerId)>>::call_once
  41:     0x7f91ce37cb2a - rustc_query_system[205d08e60b1a92a0]::query::plumbing::try_execute_query::<rustc_query_impl[315a33b46a6b89bb]::DynamicConfig<rustc_query_system[205d08e60b1a92a0]::query::caches::VecCache<rustc_hir[9476a13e5c9b3903]::hir_id::OwnerId, rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[315a33b46a6b89bb]::plumbing::QueryCtxt, true>
  42:     0x7f91ce23055a - rustc_query_impl[315a33b46a6b89bb]::query_impl::check_well_formed::get_query_incr::__rust_end_short_backtrace
  43:     0x7f91ccbdf054 - rustc_middle[a28fe5db212b793e]::query::plumbing::query_ensure_error_guaranteed::<rustc_query_system[205d08e60b1a92a0]::query::caches::VecCache<rustc_hir[9476a13e5c9b3903]::hir_id::OwnerId, rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>, ()>
  44:     0x7f91ccb3ebef - <rustc_middle[a28fe5db212b793e]::hir::ModuleItems>::par_items::<rustc_hir_analysis[1b3367767695ca72]::check::wfcheck::check_mod_type_wf::{closure#0}>
  45:     0x7f91cccf7e10 - rustc_hir_analysis[1b3367767695ca72]::check::wfcheck::check_mod_type_wf
  46:     0x7f91cdf44ac5 - rustc_query_impl[315a33b46a6b89bb]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[315a33b46a6b89bb]::query_impl::check_mod_type_wf::dynamic_query::{closure#2}::{closure#0}, rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>
  47:     0x7f91ce218d45 - <rustc_query_impl[315a33b46a6b89bb]::query_impl::check_mod_type_wf::dynamic_query::{closure#2} as core[c5845d8d53ed6e15]::ops::function::FnOnce<(rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt, rustc_span[c94123ca65beb6eb]::def_id::LocalModDefId)>>::call_once
  48:     0x7f91ce331e48 - rustc_query_system[205d08e60b1a92a0]::query::plumbing::try_execute_query::<rustc_query_impl[315a33b46a6b89bb]::DynamicConfig<rustc_query_system[205d08e60b1a92a0]::query::caches::DefaultCache<rustc_span[c94123ca65beb6eb]::def_id::LocalModDefId, rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[315a33b46a6b89bb]::plumbing::QueryCtxt, true>
  49:     0x7f91ce27445a - rustc_query_impl[315a33b46a6b89bb]::query_impl::check_mod_type_wf::get_query_incr::__rust_end_short_backtrace
  50:     0x7f91ccbe06c8 - <rustc_middle[a28fe5db212b793e]::hir::map::Map>::par_for_each_module::<rustc_hir_analysis[1b3367767695ca72]::check_crate::{closure#2}::{closure#0}>::{closure#0}
  51:     0x7f91ccb6365c - rustc_hir_analysis[1b3367767695ca72]::check_crate
  52:     0x7f91cc4a5cbc - rustc_interface[13ad69ef859e6ed6]::passes::analysis
  53:     0x7f91cdf5bed3 - rustc_query_impl[315a33b46a6b89bb]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[315a33b46a6b89bb]::query_impl::analysis::dynamic_query::{closure#2}::{closure#0}, rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>
  54:     0x7f91ce090991 - <rustc_query_impl[315a33b46a6b89bb]::query_impl::analysis::dynamic_query::{closure#2} as core[c5845d8d53ed6e15]::ops::function::FnOnce<(rustc_middle[a28fe5db212b793e]::ty::context::TyCtxt, ())>>::call_once
  55:     0x7f91ce2deabe - rustc_query_system[205d08e60b1a92a0]::query::plumbing::try_execute_query::<rustc_query_impl[315a33b46a6b89bb]::DynamicConfig<rustc_query_system[205d08e60b1a92a0]::query::caches::SingleCache<rustc_middle[a28fe5db212b793e]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[315a33b46a6b89bb]::plumbing::QueryCtxt, true>
  56:     0x7f91ce09648a - rustc_query_impl[315a33b46a6b89bb]::query_impl::analysis::get_query_incr::__rust_end_short_backtrace
  57:     0x7f91cc2d4817 - <rustc_middle[a28fe5db212b793e]::ty::context::GlobalCtxt>::enter::<rustc_driver_impl[ef2bbe5f1dee9789]::run_compiler::{closure#0}::{closure#1}::{closure#3}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>
  58:     0x7f91cc2333c6 - <rustc_interface[13ad69ef859e6ed6]::interface::Compiler>::enter::<rustc_driver_impl[ef2bbe5f1dee9789]::run_compiler::{closure#0}::{closure#1}, core[c5845d8d53ed6e15]::result::Result<core[c5845d8d53ed6e15]::option::Option<rustc_interface[13ad69ef859e6ed6]::queries::Linker>, rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>
  59:     0x7f91cc2efeff - rustc_span[c94123ca65beb6eb]::set_source_map::<core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>, rustc_interface[13ad69ef859e6ed6]::interface::run_compiler<core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>, rustc_driver_impl[ef2bbe5f1dee9789]::run_compiler::{closure#0}>::{closure#0}::{closure#0}>
  60:     0x7f91cc2d2b0c - <scoped_tls[4a2e423e0a77ff]::ScopedKey<rustc_span[c94123ca65beb6eb]::SessionGlobals>>::set::<rustc_interface[13ad69ef859e6ed6]::util::run_in_thread_pool_with_globals<rustc_interface[13ad69ef859e6ed6]::interface::run_compiler<core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>, rustc_driver_impl[ef2bbe5f1dee9789]::run_compiler::{closure#0}>::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>
  61:     0x7f91cc2f0401 - rustc_span[c94123ca65beb6eb]::create_session_globals_then::<core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>, rustc_interface[13ad69ef859e6ed6]::util::run_in_thread_pool_with_globals<rustc_interface[13ad69ef859e6ed6]::interface::run_compiler<core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>, rustc_driver_impl[ef2bbe5f1dee9789]::run_compiler::{closure#0}>::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>::{closure#0}>
  62:     0x7f91cc22871e - std[4b907581ded592fa]::sys_common::backtrace::__rust_begin_short_backtrace::<rustc_interface[13ad69ef859e6ed6]::util::run_in_thread_with_globals<rustc_interface[13ad69ef859e6ed6]::util::run_in_thread_pool_with_globals<rustc_interface[13ad69ef859e6ed6]::interface::run_compiler<core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>, rustc_driver_impl[ef2bbe5f1dee9789]::run_compiler::{closure#0}>::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>
  63:     0x7f91cc2ded21 - <<std[4b907581ded592fa]::thread::Builder>::spawn_unchecked_<rustc_interface[13ad69ef859e6ed6]::util::run_in_thread_with_globals<rustc_interface[13ad69ef859e6ed6]::util::run_in_thread_pool_with_globals<rustc_interface[13ad69ef859e6ed6]::interface::run_compiler<core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>, rustc_driver_impl[ef2bbe5f1dee9789]::run_compiler::{closure#0}>::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[c5845d8d53ed6e15]::result::Result<(), rustc_span[c94123ca65beb6eb]::ErrorGuaranteed>>::{closure#1} as core[c5845d8d53ed6e15]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  65:     0x7f91cb480ac3 - <unknown>
  66:     0x7f91cb512850 - <unknown>
  67:                0x0 - <unknown>


error: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: please attach the file at `/checkout/obj/build/ct/diesel/rustc-ice-2024-03-12T13_32_57-31825.txt` to your bug report

note: compiler flags: -C embed-bitcode=no -C debuginfo=2 -C incremental=[REDACTED]
note: some of the compiler flags provided by cargo are hidden

query stack during panic:
query stack during panic:
#0 [specialization_graph_of] building specialization graph of trait `query_dsl::distinct_dsl::DistinctDsl`
#1 [coherent_trait] coherence checking all impls of trait `query_dsl::distinct_dsl::DistinctDsl`
#2 [check_well_formed] checking that `query_builder::select_statement::boxed::<impl at diesel/src/query_builder/select_statement/boxed.rs:170:1: 173:39>` is well-formed
#3 [check_mod_type_wf] checking that types are well-formed in module `query_builder::select_statement::boxed`
end of query stack
warning: trait aliases are experimental
##[warning]   --> diesel/src/expression/mod.rs:553:1
    |
---
thread 'main' panicked at src/tools/cargotest/main.rs:124:9:
tests failed for https://github.com/diesel-rs/diesel
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Build completed unsuccessfully in 0:34:54
make: *** [Makefile:51: check-aux] Error 1
  network time: Tue, 12 Mar 2024 13:33:00 GMT
##[error]Process completed with exit code 2.
Post job cleanup.

rust-log-analyzer avatar Mar 12 '24 13:03 rust-log-analyzer

:broken_heart: Test failed - checks-actions

bors avatar Mar 12 '24 13:03 bors

:umbrella: The latest upstream changes (presumably #122832) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Mar 28 '24 08:03 bors