rust icon indicating copy to clipboard operation
rust copied to clipboard

Normalize type outlives obligations in NLL for new solver

Open compiler-errors opened this issue 1 year ago • 10 comments

Normalize the type outlives assumptions and obligations in MIR borrowck. This should fix any of the lazy-norm-related MIR borrowck problems.

Also some cleanups from last PR:

  1. Normalize obligations in a loop in lexical region resolution
  2. Use deeply_normalize_with_skipped_universes in lexical resolution since we may have, e.g. for<'a> Alias<'a>: 'b.

r? lcnr

compiler-errors avatar Jan 30 '24 21:01 compiler-errors

@bors try @rust-timer queue

compiler-errors avatar Jan 30 '24 21:01 compiler-errors

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

rust-timer avatar Jan 30 '24 21:01 rust-timer

:hourglass: Trying commit 870f77c040230ca768f6ab53848d3cbed400cf6c with merge 78d5ab60709b3df7978f028f2d525cea3df23c21...

bors avatar Jan 30 '24 22:01 bors

:sunny: Try build successful - checks-actions Build commit: 78d5ab60709b3df7978f028f2d525cea3df23c21 (78d5ab60709b3df7978f028f2d525cea3df23c21)

bors avatar Jan 30 '24 23:01 bors

Queued 78d5ab60709b3df7978f028f2d525cea3df23c21 with parent cb4d9a1902b3ea17e93872dafb76d24aa6295c47, future comparison URL. There are currently 0 preceding artifacts in the queue. It will probably take at least ~1.2 hours until the benchmark run finishes.

rust-timer avatar Jan 30 '24 23:01 rust-timer

Finished benchmarking commit (78d5ab60709b3df7978f028f2d525cea3df23c21): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never @rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.2% [0.7%, 4.6%] 39
Regressions ❌
(secondary)
3.0% [0.8%, 5.2%] 77
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.2% [0.7%, 4.6%] 39

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 660.046s -> 659.99s (-0.01%) Artifact size: 308.08 MiB -> 308.11 MiB (0.01%)

rust-timer avatar Jan 31 '24 00:01 rust-timer

@bors r+ rollup

lcnr avatar Feb 02 '24 20:02 lcnr

:pushpin: Commit e951bcff96ac606aad3b7870c7fa64a4a48aa04b has been approved by lcnr

It is now in the queue for this repository.

bors avatar Feb 02 '24 20:02 bors

:evergreen_tree: The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

bors avatar Feb 02 '24 20:02 bors

@bors rollup=never

lcnr avatar Feb 02 '24 20:02 lcnr

@bors rollup=maybe

compiler-errors avatar Feb 05 '24 16:02 compiler-errors