rust icon indicating copy to clipboard operation
rust copied to clipboard

Add FileCheck annotations to MIR-opt SROA tests

Open JarlEvanson opened this issue 6 months ago • 2 comments

Part of #116971, adds FileCheck annotations to SROA MIR-opt tests in tests/mir-opt/sroa and a few uncategorized files.

r? cjgillot

JarlEvanson avatar Jan 28 '24 20:01 JarlEvanson

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cjgillot (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar Jan 28 '24 20:01 rustbot

Thanks for the review. I think I implemented all your suggestions, but let me know if I didn't.

JarlEvanson avatar Feb 02 '24 21:02 JarlEvanson

Thanks! @bors r+ rollup

cjgillot avatar Feb 06 '24 23:02 cjgillot

:pushpin: Commit bae4f177b8767f6acab5474c6fec2734df759a32 has been approved by cjgillot

It is now in the queue for this repository.

bors avatar Feb 06 '24 23:02 bors