rust icon indicating copy to clipboard operation
rust copied to clipboard

Correct the simd_masked_{load,store} intrinsic docs

Open farnoy opened this issue 2 years ago • 7 comments

Explains the uniform pointer being used for these two operations and how elements are offset from it.

farnoy avatar Dec 21 '23 23:12 farnoy

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

rustbot avatar Dec 21 '23 23:12 rustbot

@rustbot author

RalfJung avatar Dec 28 '23 23:12 RalfJung

@rustbot ready

I will squash the commits when it's approved

farnoy avatar Jan 09 '24 10:01 farnoy

LGTM, r=me after squashing.

@bors delegate+

RalfJung avatar Jan 09 '24 11:01 RalfJung

:v: @farnoy, you can now approve this pull request!

If @RalfJung told you to "r=me" after making some further change, please make that change, then do @bors r=@RalfJung

bors avatar Jan 09 '24 11:01 bors

I'm going to be away for a few months, so I'm rerolling my PRs so that folks don't have to wait for me. Sorry/thanks.

r? libs

thomcc avatar Feb 01 '24 22:02 thomcc

r? @RalfJung

@farnoy this is just waiting for you to squash the commits. :)

RalfJung avatar Feb 02 '24 08:02 RalfJung

Some changes occurred to the platform-builtins intrinsics. Make sure the LLVM backend as well as portable-simd gets adapted for the changes.

cc @antoyo, @GuillaumeGomez, @bjorn3, @calebzulawski, @programmerjake

rustbot avatar Feb 20 '24 16:02 rustbot

Missed the notifications.

@bors r=@RalfJung

farnoy avatar Feb 20 '24 16:02 farnoy

:pushpin: Commit 14a45516951edbbc9dd404529073dc9e9dd40351 has been approved by RalfJung

It is now in the queue for this repository.

bors avatar Feb 20 '24 16:02 bors

@bors rollup=always (docs-only change)

saethlin avatar Feb 20 '24 18:02 saethlin