rust icon indicating copy to clipboard operation
rust copied to clipboard

force current stage when `--stage` is expilicitly used

Open onur-ozkan opened this issue 2 years ago • 6 comments

Allows users to build std with stage2 compiler without using full-bootstrap.

Fixes #118233 Fixes #118918

onur-ozkan avatar Dec 15 '23 20:12 onur-ozkan

r? @clubby789

(rustbot has picked a reviewer for you, use r? to override)

rustbot avatar Dec 15 '23 20:12 rustbot

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs and change-id in config.example.toml.

rustbot avatar Dec 15 '23 20:12 rustbot

Do you have any concerns on this? @Mark-Simulacrum

onur-ozkan avatar Dec 16 '23 08:12 onur-ozkan

r? Mark-Simulacrum

onur-ozkan avatar Dec 31 '23 11:12 onur-ozkan

@onur-ozkan is this still relevant, or has subsequent work replaced it? I'll need to page it back into cache but I think the open comment thread is still something I haven't had my mind changed on yet...

Mark-Simulacrum avatar Aug 04 '24 13:08 Mark-Simulacrum

I need to check this again and see if we can improve the stage handling logic without adding explicit_stage field.

@rustbot author

onur-ozkan avatar Aug 04 '24 14:08 onur-ozkan

:umbrella: The latest upstream changes (presumably #131988) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Oct 21 '24 08:10 bors