rust icon indicating copy to clipboard operation
rust copied to clipboard

Tidy up maybe_uninit_as_bytes API

Open SUPERCILEX opened this issue 1 year ago • 3 comments

  • Follow mut naming conversion
  • Move methods to extensions

The diff is super weird because it misunderstood what was moved.

SUPERCILEX avatar Oct 16 '22 23:10 SUPERCILEX

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

rustbot avatar Oct 16 '22 23:10 rustbot

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

rust-highfive avatar Oct 16 '22 23:10 rust-highfive

Thanks for the PR!

While I'm sometimes willing to add new APIs without libs-api assent, I'm much more worried about churning signatures without contacting them to see if they like them, since it would be a shame to find out they didn't and have to revert it and have impacted nightly users unnecessarily.

Could you please file an ACP for this set of changes (I think #103128 #103130 #103131 could probably all be one) to get a "yup, that seems better" from the team?

@rustbot author

scottmcm avatar Oct 17 '22 17:10 scottmcm

Sounds good! Created https://github.com/rust-lang/libs-team/issues/123

SUPERCILEX avatar Oct 17 '22 19:10 SUPERCILEX

Gonna nuke these methods, see https://github.com/rust-lang/libs-team/issues/122#issuecomment-1281784629

SUPERCILEX avatar Oct 18 '22 04:10 SUPERCILEX