rust icon indicating copy to clipboard operation
rust copied to clipboard

rustdoc: remove unused HTML class `sidebar-title`

Open notriddle opened this issue 3 years ago • 5 comments

Since 6a5f8b1aef1417d7dc85b5d0a229d2db1930eb7c, this class is no longer styled.

notriddle avatar Oct 15 '22 17:10 notriddle

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @CraftSpider (or someone else) soon.

Please see the contribution instructions for more information.

rust-highfive avatar Oct 15 '22 17:10 rust-highfive

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
configure: rust.debug-assertions := True
configure: rust.overflow-checks := True
configure: llvm.assertions      := True
configure: dist.missing-tools   := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
Attempting with retry: make prepare
---
skip untracked path src/llvm-project/ during rustfmt invocations
Diff in /checkout/src/librustdoc/html/render/mod.rs at line 2259:
 }
 
 fn print_sidebar_title(buf: &mut Buffer, id: &str, title: &str) {
-        buf,
-        buf,
-        "<h3><a href=\"#{}\">{}</a></h3>",
-        id, title
-    );
+    write!(buf, "<h3><a href=\"#{}\">{}</a></h3>", id, title);
 
 fn print_sidebar_block(
 fn print_sidebar_block(
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustfmt" "--config-path" "/checkout" "--edition" "2021" "--unstable-features" "--skip-children" "--check" "/checkout/src/librustdoc/html/static_files.rs" "/checkout/src/librustdoc/clean/simplify.rs" "/checkout/src/librustdoc/html/render/span_map.rs" "/checkout/src/librustdoc/html/render/print_item.rs" "/checkout/src/librustdoc/html/render/mod.rs" "/checkout/src/librustdoc/html/render/write_shared.rs" "/checkout/src/librustdoc/html/length_limit/tests.rs" "/checkout/src/librustdoc/clean/types.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.

rust-log-analyzer avatar Oct 15 '22 18:10 rust-log-analyzer

The job x86_64-gnu-llvm-13 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Check compiletest suite=rustdoc mode=rustdoc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
warning: `tidy` is not installed; diffs will not be generated

running 565 tests
i...............F................................................i..F..FF............... 88/565
.......................F................................................................ 176/565
........................................................................................ 352/565
.................................i..................................F................... 440/565
......................i.....................FF.......................................... 528/565
.............F.......................
.............F.......................
failures:
Some tests failed in compiletest suite=rustdoc mode=rustdoc host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu

---- [rustdoc] src/test/rustdoc/associated-consts.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/associated-consts" "/checkout/src/test/rustdoc/associated-consts.rs"
stdout: none
--- stderr -------------------------------
36: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//h3[@class="sidebar-title"]' 'Associated Constants'
47: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//h3[@class="sidebar-title"]' 'Associated Constants'
Encountered 2 errors
------------------------------------------



---- [rustdoc] src/test/rustdoc/deref-recursive-pathbuf.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/deref-recursive-pathbuf" "/checkout/src/test/rustdoc/deref-recursive-pathbuf.rs"
stdout: none
--- stderr -------------------------------
10: @has check failed
 `XPATH PATTERN` did not match
 // @has '-' '//*[@class="sidebar-title"]/a[@href="#deref-methods-PathBuf"]' 'Methods from Deref<Target=PathBuf>'
12: @has check failed
 `XPATH PATTERN` did not match
 // @has '-' '//*[@class="sidebar-title"]/a[@href="#deref-methods-Path"]' 'Methods from Deref<Target=Path>'
Encountered 2 errors
------------------------------------------



---- [rustdoc] src/test/rustdoc/deref-typedef.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/deref-typedef" "/checkout/src/test/rustdoc/deref-typedef.rs"
stdout: none
--- stderr -------------------------------
9: @has check failed
 `XPATH PATTERN` did not match
 // @has '-' '//*[@class="sidebar-title"]/a[@href="#deref-methods-FooJ"]' 'Methods from Deref<Target=FooJ>'
Encountered 1 errors
------------------------------------------



---- [rustdoc] src/test/rustdoc/deref-recursive.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/deref-recursive" "/checkout/src/test/rustdoc/deref-recursive.rs"
stdout: none
--- stderr -------------------------------
10: @has check failed
 `XPATH PATTERN` did not match
 // @has '-' '//*[@class="sidebar-title"]/a[@href="#deref-methods-Bar"]' 'Methods from Deref<Target=Bar>'
12: @has check failed
 `XPATH PATTERN` did not match
 // @has '-' '//*[@class="sidebar-title"]/a[@href="#deref-methods-Baz"]' 'Methods from Deref<Target=Baz>'
Encountered 2 errors
------------------------------------------



---- [rustdoc] src/test/rustdoc/escape-deref-methods.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/escape-deref-methods" "/checkout/src/test/rustdoc/escape-deref-methods.rs"
stdout: none
--- stderr -------------------------------
30: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@class="sidebar-title"]' 'Methods from Deref<Target=Vec<Title>>'
Encountered 1 errors
------------------------------------------



---- [rustdoc] src/test/rustdoc/negative-impl-sidebar.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/negative-impl-sidebar" "/checkout/src/test/rustdoc/negative-impl-sidebar.rs"
stdout: none
--- stderr -------------------------------
7: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@class="sidebar-title"]/a[@href="#trait-implementations"]' 'Trait Implementations'
Encountered 1 errors
------------------------------------------



---- [rustdoc] src/test/rustdoc/sidebar-items.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/sidebar-items" "/checkout/src/test/rustdoc/sidebar-items.rs"
stdout: none
--- stderr -------------------------------
5: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@class="sidebar-title"]/a[@href="#required-methods"]' 'Required Methods'
7: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@class="sidebar-title"]/a[@href="#provided-methods"]' 'Provided Methods'
9: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@class="sidebar-title"]/a[@href="#required-associated-consts"]' 'Required Associated Constants'
11: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@class="sidebar-title"]/a[@href="#provided-associated-consts"]' 'Provided Associated Constants'
13: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@class="sidebar-title"]/a[@href="#required-associated-types"]' 'Required Associated Types'
15: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@class="sidebar-title"]/a[@href="#provided-associated-types"]' 'Provided Associated Types'
28: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@class="sidebar-title"]/a[@href="#fields"]' 'Fields'
39: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@class="sidebar-title"]/a[@href="#variants"]' 'Variants'
48: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@class="sidebar-title"]/a[@href="#fields"]' 'Fields'
Encountered 9 errors
------------------------------------------



---- [rustdoc] src/test/rustdoc/sidebar-links-to-foreign-impl.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/sidebar-links-to-foreign-impl" "/checkout/src/test/rustdoc/sidebar-links-to-foreign-impl.rs"
stdout: none
--- stderr -------------------------------
6: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@class="sidebar-title"]/a[@href="#foreign-impls"]' 'Implementations on Foreign Types'
Encountered 1 errors
------------------------------------------



---- [rustdoc] src/test/rustdoc/tuple-struct-fields-doc.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/tuple-struct-fields-doc" "/checkout/src/test/rustdoc/tuple-struct-fields-doc.rs"
stdout: none
--- stderr -------------------------------
5: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//h3[@class="sidebar-title"]/a[@href="#fields"]' 'Tuple Fields'
Encountered 1 errors
------------------------------------------


rust-log-analyzer avatar Oct 15 '22 18:10 rust-log-analyzer

Thanks!

@bors r+ rollup

GuillaumeGomez avatar Oct 17 '22 14:10 GuillaumeGomez

:pushpin: Commit f0371d123868b2a63db886d8549e2d116d58b21f has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors avatar Oct 17 '22 14:10 bors