rust icon indicating copy to clipboard operation
rust copied to clipboard

make projection bounds with const bounds satisfy const

Open fee1-dead opened this issue 3 years ago • 2 comments

Fixes #101982.

fee1-dead avatar Sep 18 '22 17:09 fee1-dead

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

rust-highfive avatar Sep 18 '22 17:09 rust-highfive

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
configure: rust.debug-assertions := True
configure: rust.overflow-checks := True
configure: llvm.assertions      := True
configure: dist.missing-tools   := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
Attempting with retry: make prepare
---
skip untracked path cpu-usage.csv during rustfmt invocations
skip untracked path src/doc/book/ during rustfmt invocations
skip untracked path src/doc/rust-by-example/ during rustfmt invocations
skip untracked path src/llvm-project/ during rustfmt invocations
Diff in /checkout/compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs at line 362:
             .infcx
             .probe(|_| self.match_projection_obligation_against_definition_bounds(obligation));
 
-        candidates.vec.extend(result.into_iter().map(|(idx, constness)| ProjectionCandidate(idx, constness)));
+        candidates
+            .vec
+            .extend(result.into_iter().map(|(idx, constness)| ProjectionCandidate(idx, constness)));
 
 
     /// Given an obligation like `<SomeTrait for T>`, searches the obligations that the caller
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustfmt" "--config-path" "/checkout" "--edition" "2021" "--unstable-features" "--skip-children" "--check" "/checkout/compiler/rustc_trait_selection/src/traits/query/method_autoderef.rs" "/checkout/compiler/rustc_trait_selection/src/traits/query/evaluate_obligation.rs" "/checkout/compiler/rustc_trait_selection/src/traits/fulfill.rs" "/checkout/compiler/rustc_trait_selection/src/traits/select/mod.rs" "/checkout/compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs" "/checkout/compiler/rustc_trait_selection/src/traits/select/confirmation.rs" "/checkout/compiler/rustc_trait_selection/src/traits/engine.rs" "/checkout/compiler/rustc_trait_selection/src/traits/query/type_op/eq.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.

rust-log-analyzer avatar Sep 18 '22 18:09 rust-log-analyzer

@bors try @rust-timer queue

oli-obk avatar Sep 20 '22 08:09 oli-obk

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

rust-timer avatar Sep 20 '22 08:09 rust-timer

:hourglass: Trying commit ee96ae0a32d35b81103f666ea5ebd898714fa433 with merge b2e9cc6434c548977f066bc6b2e83f101cde5d2c...

bors avatar Sep 20 '22 08:09 bors

:sunny: Try build successful - checks-actions Build commit: b2e9cc6434c548977f066bc6b2e83f101cde5d2c (b2e9cc6434c548977f066bc6b2e83f101cde5d2c)

bors avatar Sep 20 '22 09:09 bors

Queued b2e9cc6434c548977f066bc6b2e83f101cde5d2c with parent acb8934fd57b3c2740c4abac0a5728c2c9b1423b, future comparison URL.

rust-timer avatar Sep 20 '22 09:09 rust-timer

Finished benchmarking commit (b2e9cc6434c548977f066bc6b2e83f101cde5d2c): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never @rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean[^1] range count[^2]
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.7% [4.0%, 5.5%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.3% [-5.3%, -5.3%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean[^1] range count[^2]
Regressions ❌
(primary)
2.1% [2.0%, 2.2%] 2
Regressions ❌
(secondary)
2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.1% [2.0%, 2.2%] 2

[^1]: the arithmetic mean of the percent change [^2]: number of relevant changes

rust-timer avatar Sep 20 '22 10:09 rust-timer

@bors r+

oli-obk avatar Sep 20 '22 12:09 oli-obk

:pushpin: Commit ee96ae0a32d35b81103f666ea5ebd898714fa433 has been approved by oli-obk

It is now in the queue for this repository.

bors avatar Sep 20 '22 12:09 bors

:hourglass: Testing commit ee96ae0a32d35b81103f666ea5ebd898714fa433 with merge cd8cc91045281f7f1924ecc101f2c6002f6a1eee...

bors avatar Sep 20 '22 16:09 bors

:sunny: Test successful - checks-actions Approved by: oli-obk Pushing cd8cc91045281f7f1924ecc101f2c6002f6a1eee to master...

bors avatar Sep 20 '22 19:09 bors

Finished benchmarking commit (cd8cc91045281f7f1924ecc101f2c6002f6a1eee): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean[^1] range count[^2]
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.5% [-2.5%, -2.5%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean[^1] range count[^2]
Regressions ❌
(primary)
2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.9% [-2.9%, -2.9%] 1
All ❌✅ (primary) 2.4% [2.4%, 2.4%] 1

[^1]: the arithmetic mean of the percent change [^2]: number of relevant changes

rust-timer avatar Sep 20 '22 20:09 rust-timer