rust icon indicating copy to clipboard operation
rust copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

[crater experiment] Turn on debug assertions

Open saethlin opened this issue 3 years ago • 7 comments

The standard library has a lot more debug assertions since https://github.com/rust-lang/rust/pull/92686 which also found and fixed some UB in the compiler using them. It has been suggested that as a follow-up to trying out the LLVM assertions in https://github.com/rust-lang/rust/pull/101591, we try out the Rust assertions.

I think this would only need a check run.

saethlin avatar Sep 17 '22 03:09 saethlin

r? @pietroalbini

(rust-highfive has picked a reviewer for you, use r? to override)

rust-highfive avatar Sep 17 '22 03:09 rust-highfive

@bors try

pietroalbini avatar Sep 18 '22 12:09 pietroalbini

:hourglass: Trying commit ca14fbea6fb07506b0b2f5e3f993c541921f5d11 with merge 3bbb5242a8064de4ca3af4036745ddf603ddaa85...

bors avatar Sep 18 '22 12:09 bors

:sunny: Try build successful - checks-actions Build commit: 3bbb5242a8064de4ca3af4036745ddf603ddaa85 (3bbb5242a8064de4ca3af4036745ddf603ddaa85)

bors avatar Sep 18 '22 15:09 bors

@craterbot run mode=build-only

pietroalbini avatar Sep 18 '22 15:09 pietroalbini

:ok_hand: Experiment pr-101929 created and queued. :robot: Automatically detected try build 3bbb5242a8064de4ca3af4036745ddf603ddaa85 :mag: You can check out the queue and this experiment's details.

:information_source: Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot avatar Sep 18 '22 15:09 craterbot

:construction: Experiment pr-101929 is now running

:information_source: Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot avatar Sep 18 '22 15:09 craterbot

:tada: Experiment pr-101929 is completed! :bar_chart: 224 regressed and 3 fixed (243718 total) :newspaper: Open the full report.

:warning: If you notice any spurious failure please add them to the blacklist! :information_source: Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot avatar Sep 20 '22 07:09 craterbot

Looks like the majority of these are SIGILL crashes in either syntex_syntax which is an old and deprecated crate, rle-decode-fast version 1.0.1, and clang's 1.0 series. The first two are doing out-of-bounds unchecked indexing, and clang creates null slices. There's also one showing from font-kit's null slices, always nice to see an old friend.

It looks like the rest of the regressions are OOMs of some kind or another.

I reported what looks like the single net-new finding here: https://github.com/rust-lang/rust/issues/102074

There are also plenty of other ICEs in here, but nothing new as best I can tell. I think this matter is closed.

saethlin avatar Sep 20 '22 23:09 saethlin