rust
rust copied to clipboard
RFC 2145: Type privacy and private-in-public lints
(https://github.com/rust-lang/rust/issues/48054).
r? @petrochenkov
Blocked on https://github.com/rust-lang/rust/pull/100147.
rustc_error_messages was changed
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki
The job mingw-check failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
Checking rustc_middle v0.0.0 (/checkout/compiler/rustc_middle)
Checking rustc_ast_passes v0.0.0 (/checkout/compiler/rustc_ast_passes)
Checking rustc_expand v0.0.0 (/checkout/compiler/rustc_expand)
Checking rustc_builtin_macros v0.0.0 (/checkout/compiler/rustc_builtin_macros)
error[E0599]: no variant or associated item named `Invisible` found for enum `ty::Visibility` in the current scope
--> compiler/rustc_middle/src/middle/privacy.rs:40:48
|
40 | EffectiveVisibility { vis: Visibility::Invisible }
| ^^^^^^^^^ variant or associated item not found in `ty::Visibility`
::: compiler/rustc_middle/src/ty/mod.rs:266:1
|
266 | pub enum Visibility {
266 | pub enum Visibility {
| ------------------- variant or associated item `Invisible` not found for this enum
error[E0599]: no variant or associated item named `Invisible` found for enum `ty::Visibility` in the current scope
--> compiler/rustc_middle/src/middle/privacy.rs:48:33
|
48 | self.vis != Visibility::Invisible
| ^^^^^^^^^ variant or associated item not found in `ty::Visibility`
::: compiler/rustc_middle/src/ty/mod.rs:266:1
|
266 | pub enum Visibility {
266 | pub enum Visibility {
| ------------------- variant or associated item `Invisible` not found for this enum
error[E0599]: no variant or associated item named `Invisible` found for enum `ty::Visibility` in the current scope
--> compiler/rustc_middle/src/middle/privacy.rs:161:25
161 | Visibility::Invisible => None,
| ^^^^^^^^^ variant or associated item not found in `ty::Visibility`
|
::: compiler/rustc_middle/src/ty/mod.rs:266:1
::: compiler/rustc_middle/src/ty/mod.rs:266:1
|
266 | pub enum Visibility {
| ------------------- variant or associated item `Invisible` not found for this enum
For more information about this error, try `rustc --explain E0599`.
error: could not compile `rustc_middle` due to 3 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `rustc_middle` due to 3 previous errors
The job mingw-check failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
Checking rustc_middle v0.0.0 (/checkout/compiler/rustc_middle)
Checking rustc_ast_passes v0.0.0 (/checkout/compiler/rustc_ast_passes)
Checking rustc_expand v0.0.0 (/checkout/compiler/rustc_expand)
Checking rustc_builtin_macros v0.0.0 (/checkout/compiler/rustc_builtin_macros)
error[E0599]: no variant or associated item named `Invisible` found for enum `ty::Visibility` in the current scope
--> compiler/rustc_middle/src/middle/privacy.rs:40:48
|
40 | EffectiveVisibility { vis: Visibility::Invisible }
| ^^^^^^^^^ variant or associated item not found in `ty::Visibility`
::: compiler/rustc_middle/src/ty/mod.rs:266:1
|
266 | pub enum Visibility {
266 | pub enum Visibility {
| ------------------- variant or associated item `Invisible` not found for this enum
error[E0599]: no variant or associated item named `Invisible` found for enum `ty::Visibility` in the current scope
--> compiler/rustc_middle/src/middle/privacy.rs:48:33
|
48 | self.vis != Visibility::Invisible
| ^^^^^^^^^ variant or associated item not found in `ty::Visibility`
::: compiler/rustc_middle/src/ty/mod.rs:266:1
|
266 | pub enum Visibility {
266 | pub enum Visibility {
| ------------------- variant or associated item `Invisible` not found for this enum
error[E0599]: no variant or associated item named `Invisible` found for enum `ty::Visibility` in the current scope
--> compiler/rustc_middle/src/middle/privacy.rs:161:25
161 | Visibility::Invisible => None,
| ^^^^^^^^^ variant or associated item not found in `ty::Visibility`
|
::: compiler/rustc_middle/src/ty/mod.rs:266:1
::: compiler/rustc_middle/src/ty/mod.rs:266:1
|
266 | pub enum Visibility {
| ------------------- variant or associated item `Invisible` not found for this enum
For more information about this error, try `rustc --explain E0599`.
error: could not compile `rustc_middle` due to 3 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `rustc_middle` due to 3 previous errors
The job mingw-check failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
configure: rust.debug-assertions := True
configure: rust.overflow-checks := True
configure: llvm.assertions := True
configure: dist.missing-tools := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure:
configure: run `python /checkout/x.py --help`
Attempting with retry: make prepare
The job x86_64-gnu-llvm-13 failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
---- [ui] src/test/ui/privacy/access_levels.rs stdout ----
diff of stderr:
- error: access lvl: None, Public vis: pub(access_levels), Exported vis: pub(access_levels), Reachable vis: pub(access_levels), ReachableFromImplTrait vis: Invisible
+ error: access lvl: None, Public vis: pub(access_levels), Exported vis: pub(access_levels), Reachable vis: pub(access_levels), ReachableFromImplTrait vis: pub(access_levels)
3 |
3 |
4 LL | mod outer {
5 | ^^^^^^^^^
6
6
- error: access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: Invisible
+ error: access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(access_levels)
9 |
9 |
10 LL | pub mod inner1 {
11 | ^^^^^^^^^^^^^^
12
12
- error: access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: Invisible
+ error: access lvl: Some(Exported), Public vis: pub(inner1), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(inner1)
15 |
16 LL | ... extern "C" {}
17 | ^^^^^^^^^^^^^
17 | ^^^^^^^^^^^^^
Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu
18
- error: access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: Invisible
+ error: access lvl: Some(Exported), Public vis: pub(inner1), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(inner1)
21 |
22 LL | ... pub trait PubTrait {
23 | ^^^^^^^^^^^^^^^^^^
23 | ^^^^^^^^^^^^^^^^^^
24
- error: access lvl: None, Public vis: pub(inner1), Exported vis: pub(inner1), Reachable vis: pub(inner1), ReachableFromImplTrait vis: Invisible
+ error: access lvl: None, Public vis: pub(inner1), Exported vis: pub(inner1), Reachable vis: pub(inner1), ReachableFromImplTrait vis: pub(inner1)
27 |
27 |
28 LL | ... struct PrivStruct;
29 | ^^^^^^^^^^^^^^^^^
30
30
- error: access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: Invisible
+ error: access lvl: Some(Exported), Public vis: pub(inner1), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(inner1)
33 |
33 |
34 LL | ... pub union PubUnion {
35 | ^^^^^^^^^^^^^^^^^^
36
36
- error: access lvl: None, Public vis: pub(inner1), Exported vis: pub(inner1), Reachable vis: pub(inner1), ReachableFromImplTrait vis: Invisible
+ error: access lvl: None, Public vis: pub(PubUnion), Exported vis: pub(PubUnion), Reachable vis: pub(PubUnion), ReachableFromImplTrait vis: pub(PubUnion)
39 |
39 |
40 LL | ... a: u8,
41 | ^^^^^
42
42
- error: access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: Invisible
+ error: access lvl: Some(Exported), Public vis: pub(PubUnion), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(PubUnion)
45 |
45 |
46 LL | ... pub b: u8,
47 | ^^^^^^^^^
48
48
- error: access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: Invisible
+ error: access lvl: Some(Exported), Public vis: pub(inner1), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(inner1)
51 |
52 LL | ... pub enum Enum {
53 | ^^^^^^^^^^^^^
53 | ^^^^^^^^^^^^^
54
- error: access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: Invisible
+ error: access lvl: Some(Exported), Public vis: pub(Enum), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(Enum)
57 |
58 LL | ... A(
59 | ^
59 | ^
60
- error: access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: Invisible
+ error: access lvl: Some(Exported), Public vis: pub(A), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(A)
63 |
64 LL | ... PubUnion,
65 | ^^^^^^^^
65 | ^^^^^^^^
66
- error: access lvl: None, Public vis: pub(access_levels), Exported vis: pub(access_levels), Reachable vis: pub(access_levels), ReachableFromImplTrait vis: Invisible
+ error: access lvl: None, Public vis: pub(outer), Exported vis: pub(outer), Reachable vis: pub(outer), ReachableFromImplTrait vis: pub(outer)
69 |
70 LL | macro_rules! none_macro {
71 | ^^^^^^^^^^^^^^^^^^^^^^^
71 | ^^^^^^^^^^^^^^^^^^^^^^^
72
- error: access lvl: Some(Public), Public vis: Public, Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: Invisible
+ error: access lvl: Some(Public), Public vis: Public, Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(access_levels)
75 |
76 LL | macro_rules! public_macro {
77 | ^^^^^^^^^^^^^^^^^^^^^^^^^
77 | ^^^^^^^^^^^^^^^^^^^^^^^^^
78
- error: access lvl: Some(Reachable), Public vis: pub(access_levels), Exported vis: pub(access_levels), Reachable vis: pub(access_levels), ReachableFromImplTrait vis: Invisible
+ error: access lvl: Some(Reachable), Public vis: pub(outer), Exported vis: pub(outer), Reachable vis: pub(outer), ReachableFromImplTrait vis: pub(outer)
81 |
82 LL | pub struct ReachableStruct {
83 | ^^^^^^^^^^^^^^^^^^^^^^^^^^
83 | ^^^^^^^^^^^^^^^^^^^^^^^^^^
84
- error: access lvl: Some(Reachable), Public vis: pub(access_levels), Exported vis: pub(access_levels), Reachable vis: pub(access_levels), ReachableFromImplTrait vis: Invisible
+ error: access lvl: Some(Reachable), Public vis: pub(ReachableStruct), Exported vis: pub(ReachableStruct), Reachable vis: pub(ReachableStruct), ReachableFromImplTrait vis: pub(ReachableStruct)
87 |
88 LL | ... pub a: u8,
89 | ^^^^^^^^^
89 | ^^^^^^^^^
90
- error: access lvl: None, Public vis: pub(outer), Exported vis: pub(outer), Reachable vis: pub(outer), ReachableFromImplTrait vis: Invisible
+ error: access lvl: None, Public vis: pub(outer), Exported vis: pub(outer), Reachable vis: pub(outer), ReachableFromImplTrait vis: pub(outer)
93 |
93 |
94 LL | mod priv_mod {
95 | ^^^^^^^^^^^^
96
96
- error: access lvl: None, Public vis: pub(outer), Exported vis: pub(outer), Reachable vis: pub(outer), ReachableFromImplTrait vis: Invisible
+ error: access lvl: None, Public vis: pub(priv_mod), Exported vis: pub(priv_mod), Reachable vis: pub(priv_mod), ReachableFromImplTrait vis: pub(priv_mod)
99 |
99 |
100 LL | ... pub mod pub_mod {
101 | ^^^^^^^^^^^^^^^
102
102
- error: access lvl: None, Public vis: pub(outer), Exported vis: pub(priv_mod), Reachable vis: pub(priv_mod), ReachableFromImplTrait vis: Invisible
+ error: access lvl: None, Public vis: pub(priv_mod), Exported vis: pub(priv_mod), Reachable vis: pub(priv_mod), ReachableFromImplTrait vis: pub(priv_mod)
105 |
105 |
106 LL | ... pub struct PubStruct2;
107 | ^^^^^^^^^^^^^^^^^^^^^
108
108
- error: access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: Invisible
+ error: access lvl: Some(Exported), Public vis: pub(PubTrait), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(PubTrait)
111 |
111 |
112 LL | ... const A: i32;
113 | ^^^^^^^^^^^^
114
114
- error: access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: Invisible
+ error: access lvl: Some(Exported), Public vis: pub(PubTrait), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(PubTrait)
117 |
118 LL | ... type B;
The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/privacy/access_levels/access_levels.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args privacy/access_levels.rs`
error: 1 errors occurred comparing output.
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/privacy/access_levels.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/privacy/access_levels" "-A" "unused" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/privacy/access_levels/auxiliary"
stdout: none
--- stderr -------------------------------
error: access lvl: None, Public vis: pub(access_levels), Exported vis: pub(access_levels), Reachable vis: pub(access_levels), ReachableFromImplTrait vis: pub(access_levels)
|
|
LL | mod outer { //~ ERROR access lvl: None, Public vis: pub(access_levels), Exported vis: pub(access_levels), Reachable vis: pub(access_level...
error: access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(access_levels)
|
|
LL | pub mod inner1 { //~ ERROR access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, R...
error: access lvl: Some(Exported), Public vis: pub(inner1), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(inner1)
|
|
LL | ... extern "C" {} //~ ERROR Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, ReachableFromI...
error: access lvl: Some(Exported), Public vis: pub(inner1), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(inner1)
|
|
LL | ... pub trait PubTrait { //~ ERROR access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Pub...
error: access lvl: None, Public vis: pub(inner1), Exported vis: pub(inner1), Reachable vis: pub(inner1), ReachableFromImplTrait vis: pub(inner1)
|
|
LL | ... struct PrivStruct; //~ ERROR access lvl: None, Public vis: pub(inner1), Exported vis: pub(inner1), Reachable vis: pub(inner1), Reac...
error: access lvl: Some(Exported), Public vis: pub(inner1), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(inner1)
|
|
LL | ... pub union PubUnion { //~ ERROR access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Pub...
error: access lvl: None, Public vis: pub(PubUnion), Exported vis: pub(PubUnion), Reachable vis: pub(PubUnion), ReachableFromImplTrait vis: pub(PubUnion)
|
|
LL | ... a: u8, //~ ERROR access lvl: None, Public vis: pub(inner1), Exported vis: pub(inner1), Reachable vis: pub(inner1), ReachableFromImp...
error: access lvl: Some(Exported), Public vis: pub(PubUnion), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(PubUnion)
|
|
LL | ... pub b: u8, //~ ERROR access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, Reach...
error: access lvl: Some(Exported), Public vis: pub(inner1), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(inner1)
|
|
LL | ... pub enum Enum { //~ ERROR access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, ...
error: access lvl: Some(Exported), Public vis: pub(Enum), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(Enum)
|
|
LL | ... A( //~ ERROR access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, ReachableFrom...
error: access lvl: Some(Exported), Public vis: pub(A), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(A)
|
|
LL | ... PubUnion, //~ ERROR access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, Reach...
error: access lvl: None, Public vis: pub(outer), Exported vis: pub(outer), Reachable vis: pub(outer), ReachableFromImplTrait vis: pub(outer)
|
|
LL | macro_rules! none_macro { //~ access lvl: None, Public vis: pub(access_levels), Exported vis: pub(access_levels), Reachable vis: pub(...
error: access lvl: Some(Public), Public vis: Public, Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(access_levels)
|
|
LL | macro_rules! public_macro { //~ access lvl: Some(Public), Public vis: Public, Exported vis: Public, Reachable vis: Public, ReachableF...
error: access lvl: Some(Reachable), Public vis: pub(outer), Exported vis: pub(outer), Reachable vis: pub(outer), ReachableFromImplTrait vis: pub(outer)
|
|
LL | pub struct ReachableStruct { //~ ERROR access lvl: Some(Reachable), Public vis: pub(access_levels), Exported vis: pub(access_levels),...
error: access lvl: Some(Reachable), Public vis: pub(ReachableStruct), Exported vis: pub(ReachableStruct), Reachable vis: pub(ReachableStruct), ReachableFromImplTrait vis: pub(ReachableStruct)
|
|
LL | ... pub a: u8, //~ ERROR access lvl: Some(Reachable), Public vis: pub(access_levels), Exported vis: pub(access_levels), Reachable vis: ...
error: access lvl: None, Public vis: pub(outer), Exported vis: pub(outer), Reachable vis: pub(outer), ReachableFromImplTrait vis: pub(outer)
|
|
LL | mod priv_mod { //~ ERROR access lvl: None, Public vis: pub(outer), Exported vis: pub(outer), Reachable vis: pub(outer), ReachableFrom...
error: access lvl: None, Public vis: pub(priv_mod), Exported vis: pub(priv_mod), Reachable vis: pub(priv_mod), ReachableFromImplTrait vis: pub(priv_mod)
|
|
LL | ... pub mod pub_mod {//~ ERROR access lvl: None, Public vis: pub(outer), Exported vis: pub(outer), Reachable vis: pub(outer), Reachable...
error: access lvl: None, Public vis: pub(priv_mod), Exported vis: pub(priv_mod), Reachable vis: pub(priv_mod), ReachableFromImplTrait vis: pub(priv_mod)
|
|
LL | ... pub struct PubStruct2; //~ ERROR access lvl: None, Public vis: pub(outer), Exported vis: pub(priv_mod), Reachable vis: pub(priv_mod...
error: access lvl: Some(Exported), Public vis: pub(PubTrait), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(PubTrait)
|
|
LL | ... const A: i32; //~ ERROR access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, Re...
error: access lvl: Some(Exported), Public vis: pub(PubTrait), Exported vis: Public, Reachable vis: Public, ReachableFromImplTrait vis: pub(PubTrait)
|
|
LL | ... type B; //~ ERROR access lvl: Some(Exported), Public vis: pub(access_levels), Exported vis: Public, Reachable vis: Public, Reachabl...
error: aborting due to 20 previous errors
------------------------------------------
The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
error: useless lint attribute
--> $DIR/useless_attribute.rs:8:1
|
LL | #[allow(dead_code)]
| ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`
|
= note: `-D clippy::useless-attribute` implied by `-D warnings`
error: useless lint attribute
--> $DIR/useless_attribute.rs:9:1
|
|
LL | #[cfg_attr(feature = "cargo-clippy", allow(dead_code))]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![cfg_attr(feature = "cargo-clippy", allow(dead_code)`
error: useless lint attribute
--> $DIR/useless_attribute.rs:67:5
|
|
LL | #[allow(clippy::almost_swapped)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(clippy::almost_swapped)]`
-error: aborting due to 3 previous errors
-error: aborting due to 3 previous errors
+error: unreachable `pub` item
+ |
+LL | pub use std::io::prelude::*;
+ | --- ^^^^^^^^^^^^^^^^
+ | |
+ | |
+ | help: consider restricting its visibility: `pub(crate)`
+ |
+ = note: `-D unreachable-pub` implied by `-D warnings`
+ = help: or consider exporting it for use by other crates
+
+error: unreachable `pub` item
+ |
+ |
+LL | pub use std::cmp::Ordering::*;
+ | |
+ | |
+ | help: consider restricting its visibility: `pub(crate)`
+ = help: or consider exporting it for use by other crates
+
+error: aborting due to 5 previous errors
The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/useless_attribute.stage-id.stderr
diff of fixed:
// run-rustfix
// aux-build:proc_macro_derive.rs
#![warn(clippy::useless_attribute)]
#![warn(unreachable_pub)]
#![feature(rustc_private)]
#![allow(dead_code)]
#![allow(dead_code)]
#![cfg_attr(feature = "cargo-clippy", allow(dead_code))]
#[rustfmt::skip]
#[allow(unused_extern_crates)]
#[macro_use]
extern crate rustc_middle;
#[macro_use]
extern crate proc_macro_derive;
// don't lint on unused_import for `use` items
use std::collections;
// don't lint on unused for `use` items
use std::option;
// don't lint on deprecated for `use` items
#[deprecated]
pub struct Bar;
}
#[allow(deprecated)]
#[allow(deprecated)]
pub use foo::Bar;
// This should not trigger the lint. There's lint level definitions inside the external derive
// that would trigger the useless_attribute lint.
#[derive(DeriveSomething)]
// don't lint on unreachable_pub for `use` items
mod a {
mod b {
#[allow(dead_code)]
#[allow(unreachable_pub)]
pub struct C;
#[allow(unreachable_pub)]
#[allow(unreachable_pub)]
pub use self::b::C;
// don't lint on clippy::wildcard_imports for `use` items
#[allow(clippy::wildcard_imports)]
-pub use std::io::prelude::*;
+pub(crate) use std::io::prelude::*;
// don't lint on clippy::enum_glob_use for `use` items
#[allow(clippy::enum_glob_use)]
-pub use std::cmp::Ordering::*;
+pub(crate) use std::cmp::Ordering::*;
// don't lint on clippy::redundant_pub_crate
mod c {
#[allow(clippy::redundant_pub_crate)]
pub(crate) struct S;
fn test_indented_attr() {
fn test_indented_attr() {
#![allow(clippy::almost_swapped)]
use std::collections::HashSet;
let _ = HashSet::<u32>::default();
}
fn main() {
fn main() {
test_indented_attr();
}
The actual fixed differed from the expected fixed.
Actual fixed saved to /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/useless_attribute.stage-id.fixed
To only update this specific test, also pass `--test-args useless_attribute.rs`
error: 2 errors occurred comparing output.
status: exit status: 1
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "tests/ui/useless_attribute.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/useless_attribute.stage-id" "-A" "unused" "--emit=metadata" "-Dwarnings" "-Zui-testing" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "--extern" "parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libparking_lot-4554cde6a1339e03.rlib" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libregex-7dc368fb32eb8aae.rlib" "--extern" "if_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libif_chain-03f75cdc6d4d3afc.rlib" "--extern" "derive_new=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libderive_new-14dbc812a1f5dba0.so" "--extern" "quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libquote-021aec868151835c.rlib" "--extern" "clippy_utils=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_utils-56bce9bcc023120a.rlib" "--extern" "syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libsyn-c6aa3eacac0eeebb.rlib" "--extern" "rustc_semver=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/librustc_semver-963bbd3f89834643.rlib" "--extern" "futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libfutures-68b3adac889f3bfe.rlib" "--extern" "tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libtokio-11c942eb60796e9d.rlib" "--extern" "itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libitertools-cdd893c121eb00e4.rlib" "--extern" "serde_derive=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libserde_derive-eed8221ad604f845.so" "--extern" "clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-e993ea424d40e3e9.rlib" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libserde-4b46e2e2788394f2.rlib" "--edition=2021" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/useless_attribute.stage-id.aux"
------------------------------------------
------------------------------------------
stderr:
stderr:
------------------------------------------
{"message":"useless lint attribute","code":{"code":"clippy::useless_attribute","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":140,"byte_end":159,"line_start":8,"line_end":8,"column_start":1,"column_end":20,"is_primary":true,"text":[{"text":"#[allow(dead_code)]","highlight_start":1,"highlight_end":20}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::useless-attribute` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"if you just forgot a `!`, use","code":null,"level":"help","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":140,"byte_end":159,"line_start":8,"line_end":8,"column_start":1,"column_end":20,"is_primary":true,"text":[{"text":"#[allow(dead_code)]","highlight_start":1,"highlight_end":20}],"label":null,"suggested_replacement":"#![allow(dead_code)]","suggestion_applicability":"MaybeIncorrect","expansion":null}],"children":[],"rendered":null}],"rendered":"error: useless lint attribute\n --> tests/ui/useless_attribute.rs:8:1\n |\nLL | #[allow(dead_code)]\n | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`\n |\n = note: `-D clippy::useless-attribute` implied by `-D warnings`\n\n"}
{"message":"useless lint attribute","code":{"code":"clippy::useless_attribute","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":160,"byte_end":213,"line_start":9,"line_end":9,"column_start":1,"column_end":54,"is_primary":true,"text":[{"text":"#[cfg_attr(feature = \"cargo-clippy\", allow(dead_code))]","highlight_start":1,"highlight_end":54}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"if you just forgot a `!`, use","code":null,"level":"help","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":160,"byte_end":213,"line_start":9,"line_end":9,"column_start":1,"column_end":54,"is_primary":true,"text":[{"text":"#[cfg_attr(feature = \"cargo-clippy\", allow(dead_code))]","highlight_start":1,"highlight_end":54}],"label":null,"suggested_replacement":"#![cfg_attr(feature = \"cargo-clippy\", allow(dead_code)","suggestion_applicability":"MaybeIncorrect","expansion":null}],"children":[],"rendered":null}],"rendered":"error: useless lint attribute\n --> tests/ui/useless_attribute.rs:9:1\n |\nLL | #[cfg_attr(feature = \"cargo-clippy\", allow(dead_code))]\n | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![cfg_attr(feature = \"cargo-clippy\", allow(dead_code)`\n\n"}
{"message":"useless lint attribute","code":{"code":"clippy::useless_attribute","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":1477,"byte_end":1509,"line_start":67,"line_end":67,"column_start":5,"column_end":37,"is_primary":true,"text":[{"text":" #[allow(clippy::almost_swapped)]","highlight_start":5,"highlight_end":37}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"if you just forgot a `!`, use","code":null,"level":"help","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":1477,"byte_end":1509,"line_start":67,"line_end":67,"column_start":5,"column_end":37,"is_primary":true,"text":[{"text":" #[allow(clippy::almost_swapped)]","highlight_start":5,"highlight_end":37}],"label":null,"suggested_replacement":"#![allow(clippy::almost_swapped)]","suggestion_applicability":"MaybeIncorrect","expansion":null}],"children":[],"rendered":null}],"rendered":"error: useless lint attribute\n --> tests/ui/useless_attribute.rs:67:5\n |\nLL | #[allow(clippy::almost_swapped)]\n | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(clippy::almost_swapped)]`\n\n"}
{"message":"unreachable `pub` item","code":{"code":"unreachable_pub","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":1183,"byte_end":1199,"line_start":54,"line_end":54,"column_start":9,"column_end":25,"is_primary":true,"text":[{"text":"pub use std::io::prelude::*;","highlight_start":9,"highlight_end":25}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D unreachable-pub` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"or consider exporting it for use by other crates","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"consider restricting its visibility","code":null,"level":"help","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":1175,"byte_end":1178,"line_start":54,"line_end":54,"column_start":1,"column_end":4,"is_primary":true,"text":[{"text":"pub use std::io::prelude::*;","highlight_start":1,"highlight_end":4}],"label":null,"suggested_replacement":"pub(crate)","suggestion_applicability":"MachineApplicable","expansion":null}],"children":[],"rendered":null}],"rendered":"error: unreachable `pub` item\n --> tests/ui/useless_attribute.rs:54:9\n |\nLL | pub use std::io::prelude::*;\n | --- ^^^^^^^^^^^^^^^^\n | |\n | help: consider restricting its visibility: `pub(crate)`\n |\n = note: `-D unreachable-pub` implied by `-D warnings`\n = help: or consider exporting it for use by other crates\n\n"}
{"message":"unreachable `pub` item","code":{"code":"unreachable_pub","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":1300,"byte_end":1318,"line_start":58,"line_end":58,"column_start":9,"column_end":27,"is_primary":true,"text":[{"text":"pub use std::cmp::Ordering::*;","highlight_start":9,"highlight_end":27}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"or consider exporting it for use by other crates","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"consider restricting its visibility","code":null,"level":"help","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":1292,"byte_end":1295,"line_start":58,"line_end":58,"column_start":1,"column_end":4,"is_primary":true,"text":[{"text":"pub use std::cmp::Ordering::*;","highlight_start":1,"highlight_end":4}],"label":null,"suggested_replacement":"pub(crate)","suggestion_applicability":"MachineApplicable","expansion":null}],"children":[],"rendered":null}],"rendered":"error: unreachable `pub` item\n --> tests/ui/useless_attribute.rs:58:9\n |\nLL | pub use std::cmp::Ordering::*;\n | --- ^^^^^^^^^^^^^^^^^^\n | |\n | help: consider restricting its visibility: `pub(crate)`\n |\n = help: or consider exporting it for use by other crates\n\n"}
------------------------------------------
thread 'compile_test' panicked at 'Some tests failed', /cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.8.0/src/lib.rs:111:22
The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
IMAGE: x86_64-gnu-tools
##[endgroup]
From https://github.com/rust-lang/rust
* branch master -> FETCH_HEAD
Searching for toolstate changes between 4fd4de7ea358ad6fc28c5780533ea8ccc09e1006 and 13bef2db03382eb19bdb9bb9fd3b4bf6a184344c
Rustdoc was updated
##[group]Run src/ci/scripts/verify-channel.sh
src/ci/scripts/verify-channel.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
---
error: useless lint attribute
--> $DIR/useless_attribute.rs:8:1
|
LL | #[allow(dead_code)]
| ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`
|
= note: `-D clippy::useless-attribute` implied by `-D warnings`
error: useless lint attribute
--> $DIR/useless_attribute.rs:9:1
|
|
LL | #[cfg_attr(feature = "cargo-clippy", allow(dead_code))]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![cfg_attr(feature = "cargo-clippy", allow(dead_code)`
error: useless lint attribute
--> $DIR/useless_attribute.rs:67:5
|
|
LL | #[allow(clippy::almost_swapped)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(clippy::almost_swapped)]`
-error: aborting due to 3 previous errors
-error: aborting due to 3 previous errors
+error: unreachable `pub` item
+ |
+LL | pub use std::io::prelude::*;
+ | --- ^^^^^^^^^^^^^^^^
+ | |
+ | |
+ | help: consider restricting its visibility: `pub(crate)`
+ |
+ = note: `-D unreachable-pub` implied by `-D warnings`
+ = help: or consider exporting it for use by other crates
+
+error: unreachable `pub` item
+ |
+ |
+LL | pub use std::cmp::Ordering::*;
+ | |
+ | |
+ | help: consider restricting its visibility: `pub(crate)`
+ = help: or consider exporting it for use by other crates
+
+error: aborting due to 5 previous errors
The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/useless_attribute.stage-id.stderr
diff of fixed:
// run-rustfix
// aux-build:proc_macro_derive.rs
#![warn(clippy::useless_attribute)]
#![warn(unreachable_pub)]
#![feature(rustc_private)]
#![allow(dead_code)]
#![allow(dead_code)]
#![cfg_attr(feature = "cargo-clippy", allow(dead_code))]
#[rustfmt::skip]
#[allow(unused_extern_crates)]
#[macro_use]
extern crate rustc_middle;
#[macro_use]
extern crate proc_macro_derive;
// don't lint on unused_import for `use` items
use std::collections;
// don't lint on unused for `use` items
use std::option;
// don't lint on deprecated for `use` items
#[deprecated]
pub struct Bar;
}
#[allow(deprecated)]
#[allow(deprecated)]
pub use foo::Bar;
// This should not trigger the lint. There's lint level definitions inside the external derive
// that would trigger the useless_attribute lint.
#[derive(DeriveSomething)]
// don't lint on unreachable_pub for `use` items
mod a {
mod b {
#[allow(dead_code)]
#[allow(unreachable_pub)]
pub struct C;
#[allow(unreachable_pub)]
#[allow(unreachable_pub)]
pub use self::b::C;
// don't lint on clippy::wildcard_imports for `use` items
#[allow(clippy::wildcard_imports)]
-pub use std::io::prelude::*;
+pub(crate) use std::io::prelude::*;
// don't lint on clippy::enum_glob_use for `use` items
#[allow(clippy::enum_glob_use)]
-pub use std::cmp::Ordering::*;
+pub(crate) use std::cmp::Ordering::*;
// don't lint on clippy::redundant_pub_crate
mod c {
#[allow(clippy::redundant_pub_crate)]
pub(crate) struct S;
fn test_indented_attr() {
fn test_indented_attr() {
#![allow(clippy::almost_swapped)]
use std::collections::HashSet;
let _ = HashSet::<u32>::default();
}
fn main() {
fn main() {
test_indented_attr();
}
The actual fixed differed from the expected fixed.
Actual fixed saved to /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/useless_attribute.stage-id.fixed
To only update this specific test, also pass `--test-args useless_attribute.rs`
error: 2 errors occurred comparing output.
status: exit status: 1
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "tests/ui/useless_attribute.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/useless_attribute.stage-id" "-A" "unused" "--emit=metadata" "-Dwarnings" "-Zui-testing" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "--extern" "clippy_utils=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_utils-56bce9bcc023120a.rlib" "--extern" "futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libfutures-68b3adac889f3bfe.rlib" "--extern" "parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libparking_lot-4554cde6a1339e03.rlib" "--extern" "tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libtokio-11c942eb60796e9d.rlib" "--extern" "syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libsyn-c6aa3eacac0eeebb.rlib" "--extern" "rustc_semver=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/librustc_semver-963bbd3f89834643.rlib" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libregex-7dc368fb32eb8aae.rlib" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libserde-4b46e2e2788394f2.rlib" "--extern" "quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libquote-021aec868151835c.rlib" "--extern" "serde_derive=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libserde_derive-eed8221ad604f845.so" "--extern" "clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-e993ea424d40e3e9.rlib" "--extern" "itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libitertools-cdd893c121eb00e4.rlib" "--extern" "if_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libif_chain-03f75cdc6d4d3afc.rlib" "--extern" "derive_new=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libderive_new-14dbc812a1f5dba0.so" "--edition=2021" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/useless_attribute.stage-id.aux"
------------------------------------------
------------------------------------------
stderr:
stderr:
------------------------------------------
{"message":"useless lint attribute","code":{"code":"clippy::useless_attribute","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":140,"byte_end":159,"line_start":8,"line_end":8,"column_start":1,"column_end":20,"is_primary":true,"text":[{"text":"#[allow(dead_code)]","highlight_start":1,"highlight_end":20}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::useless-attribute` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"if you just forgot a `!`, use","code":null,"level":"help","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":140,"byte_end":159,"line_start":8,"line_end":8,"column_start":1,"column_end":20,"is_primary":true,"text":[{"text":"#[allow(dead_code)]","highlight_start":1,"highlight_end":20}],"label":null,"suggested_replacement":"#![allow(dead_code)]","suggestion_applicability":"MaybeIncorrect","expansion":null}],"children":[],"rendered":null}],"rendered":"error: useless lint attribute\n --> tests/ui/useless_attribute.rs:8:1\n |\nLL | #[allow(dead_code)]\n | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`\n |\n = note: `-D clippy::useless-attribute` implied by `-D warnings`\n\n"}
{"message":"useless lint attribute","code":{"code":"clippy::useless_attribute","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":160,"byte_end":213,"line_start":9,"line_end":9,"column_start":1,"column_end":54,"is_primary":true,"text":[{"text":"#[cfg_attr(feature = \"cargo-clippy\", allow(dead_code))]","highlight_start":1,"highlight_end":54}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"if you just forgot a `!`, use","code":null,"level":"help","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":160,"byte_end":213,"line_start":9,"line_end":9,"column_start":1,"column_end":54,"is_primary":true,"text":[{"text":"#[cfg_attr(feature = \"cargo-clippy\", allow(dead_code))]","highlight_start":1,"highlight_end":54}],"label":null,"suggested_replacement":"#![cfg_attr(feature = \"cargo-clippy\", allow(dead_code)","suggestion_applicability":"MaybeIncorrect","expansion":null}],"children":[],"rendered":null}],"rendered":"error: useless lint attribute\n --> tests/ui/useless_attribute.rs:9:1\n |\nLL | #[cfg_attr(feature = \"cargo-clippy\", allow(dead_code))]\n | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![cfg_attr(feature = \"cargo-clippy\", allow(dead_code)`\n\n"}
{"message":"useless lint attribute","code":{"code":"clippy::useless_attribute","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":1477,"byte_end":1509,"line_start":67,"line_end":67,"column_start":5,"column_end":37,"is_primary":true,"text":[{"text":" #[allow(clippy::almost_swapped)]","highlight_start":5,"highlight_end":37}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"if you just forgot a `!`, use","code":null,"level":"help","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":1477,"byte_end":1509,"line_start":67,"line_end":67,"column_start":5,"column_end":37,"is_primary":true,"text":[{"text":" #[allow(clippy::almost_swapped)]","highlight_start":5,"highlight_end":37}],"label":null,"suggested_replacement":"#![allow(clippy::almost_swapped)]","suggestion_applicability":"MaybeIncorrect","expansion":null}],"children":[],"rendered":null}],"rendered":"error: useless lint attribute\n --> tests/ui/useless_attribute.rs:67:5\n |\nLL | #[allow(clippy::almost_swapped)]\n | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(clippy::almost_swapped)]`\n\n"}
{"message":"unreachable `pub` item","code":{"code":"unreachable_pub","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":1183,"byte_end":1199,"line_start":54,"line_end":54,"column_start":9,"column_end":25,"is_primary":true,"text":[{"text":"pub use std::io::prelude::*;","highlight_start":9,"highlight_end":25}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D unreachable-pub` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"or consider exporting it for use by other crates","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"consider restricting its visibility","code":null,"level":"help","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":1175,"byte_end":1178,"line_start":54,"line_end":54,"column_start":1,"column_end":4,"is_primary":true,"text":[{"text":"pub use std::io::prelude::*;","highlight_start":1,"highlight_end":4}],"label":null,"suggested_replacement":"pub(crate)","suggestion_applicability":"MachineApplicable","expansion":null}],"children":[],"rendered":null}],"rendered":"error: unreachable `pub` item\n --> tests/ui/useless_attribute.rs:54:9\n |\nLL | pub use std::io::prelude::*;\n | --- ^^^^^^^^^^^^^^^^\n | |\n | help: consider restricting its visibility: `pub(crate)`\n |\n = note: `-D unreachable-pub` implied by `-D warnings`\n = help: or consider exporting it for use by other crates\n\n"}
{"message":"unreachable `pub` item","code":{"code":"unreachable_pub","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":1300,"byte_end":1318,"line_start":58,"line_end":58,"column_start":9,"column_end":27,"is_primary":true,"text":[{"text":"pub use std::cmp::Ordering::*;","highlight_start":9,"highlight_end":27}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"or consider exporting it for use by other crates","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"consider restricting its visibility","code":null,"level":"help","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":1292,"byte_end":1295,"line_start":58,"line_end":58,"column_start":1,"column_end":4,"is_primary":true,"text":[{"text":"pub use std::cmp::Ordering::*;","highlight_start":1,"highlight_end":4}],"label":null,"suggested_replacement":"pub(crate)","suggestion_applicability":"MachineApplicable","expansion":null}],"children":[],"rendered":null}],"rendered":"error: unreachable `pub` item\n --> tests/ui/useless_attribute.rs:58:9\n |\nLL | pub use std::cmp::Ordering::*;\n | --- ^^^^^^^^^^^^^^^^^^\n | |\n | help: consider restricting its visibility: `pub(crate)`\n |\n = help: or consider exporting it for use by other crates\n\n"}
------------------------------------------
thread 'compile_test' panicked at 'Some tests failed', /cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.8.0/src/lib.rs:111:22
The job x86_64-gnu-llvm-13 failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
running 354 tests
ii.............i....i..ii.................iii........ii.i.......i.................ii.... 88/354
......F......i............i..i.................i...iii........i..i......iii.ii........i. 176/354
.ii..F.i...................i..i.....i...ii...iii.................ii..................... 264/354
...i.i.ii.i......i....F..iii.......i...i.....................iiiiiiii.i..............F.. 352/354
Some tests failed in compiletest suite=codegen mode=codegen host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu
failures:
---- [codegen] src/test/codegen/external-no-mangle-fns.rs stdout ----
error: verification with 'FileCheck' failed
status: exit status: 1
command: "/usr/lib/llvm-13/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/external-no-mangle-fns/external-no-mangle-fns.ll" "/checkout/src/test/codegen/external-no-mangle-fns.rs" "--allow-unused-prefixes" "--check-prefixes" "CHECK,NONMSVC"
stdout: none
--- stderr -------------------------------
/checkout/src/test/codegen/external-no-mangle-fns.rs:38:16: error: CHECK-NEXT: expected string not found in input
// CHECK-NEXT: define internal
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/external-no-mangle-fns/external-no-mangle-fns.ll:255:18: note: scanning from here
; Function Attrs: noinline nonlazybind uwtable
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/external-no-mangle-fns/external-no-mangle-fns.ll:256:1: note: possible intended match here
define void @_ZN22external_no_mangle_fns1x17h3b52ebf22067e371E() unnamed_addr #2 {
Input file: /checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/external-no-mangle-fns/external-no-mangle-fns.ll
Check file: /checkout/src/test/codegen/external-no-mangle-fns.rs
-dump-input=help explains the following input dump.
Input was:
<<<<<<
.
.
.
.
250: start:
251: ret void
252: }
253:
254: ; external_no_mangle_fns::x
255: ; Function Attrs: noinline nonlazybind uwtable
next:38'0 X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
256: define void @_ZN22external_no_mangle_fns1x17h3b52ebf22067e371E() unnamed_addr #2 {
next:38'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next:38'1 ? possible intended match
257: start:
next:38'0 ~~~~~~~
258: %0 = alloca i32, align 4
next:38'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~
259: %_5 = alloca i32*, align 8
next:38'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
260: %1 = bitcast i32** %_5 to i8*
next:38'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
261: call void @llvm.lifetime.start.p0i8(i64 8, i8* %1)
next:38'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.
.
>>>>>>
------------------------------------------
------------------------------------------
---- [codegen] src/test/codegen/link-dead-code.rs stdout ----
error: verification with 'FileCheck' failed
status: exit status: 1
command: "/usr/lib/llvm-13/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/link-dead-code/link-dead-code.ll" "/checkout/src/test/codegen/link-dead-code.rs" "--allow-unused-prefixes" "--check-prefixes" "CHECK,NONMSVC"
stdout: none
--- stderr -------------------------------
/checkout/src/test/codegen/link-dead-code.rs:10:16: error: CHECK-NEXT: expected string not found in input
// CHECK-NEXT: define hidden
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/link-dead-code/link-dead-code.ll:7:18: note: scanning from here
; Function Attrs: mustprogress nofree norecurse nosync nounwind nonlazybind readnone uwtable willreturn
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/link-dead-code/link-dead-code.ll:8:1: note: possible intended match here
define i32 @_ZN14link_dead_code8const_fn17ha98dc9de82d7225cE() unnamed_addr #0 {
^
/checkout/src/test/codegen/link-dead-code.rs:21:16: error: CHECK-NEXT: expected string not found in input
// CHECK-NEXT: define hidden
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/link-dead-code/link-dead-code.ll:21:18: note: scanning from here
; Function Attrs: mustprogress nofree norecurse nosync nounwind nonlazybind readnone uwtable willreturn
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/link-dead-code/link-dead-code.ll:22:1: note: possible intended match here
define i32 @_ZN14link_dead_code10private_fn17hce5fdadfd9890a1bE() unnamed_addr #0 {
Input file: /checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/link-dead-code/link-dead-code.ll
Check file: /checkout/src/test/codegen/link-dead-code.rs
-dump-input=help explains the following input dump.
Input was:
<<<<<<
<<<<<<
1: ; ModuleID = 'link_dead_code.8b95b121-cgu.0'
2: source_filename = "link_dead_code.8b95b121-cgu.0"
3: target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
4: target triple = "x86_64-unknown-linux-gnu"
6: ; link_dead_code::const_fn
6: ; link_dead_code::const_fn
7: ; Function Attrs: mustprogress nofree norecurse nosync nounwind nonlazybind readnone uwtable willreturn
next:10'0 X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
8: define i32 @_ZN14link_dead_code8const_fn17ha98dc9de82d7225cE() unnamed_addr #0 {
next:10'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next:10'1 ? possible intended match
9: start:
next:10'0 ~~~~~~~
10: ret i32 1
next:10'0 ~~~~~~~~~~~
11: }
next:10'0 ~~
12:
next:10'0 ~
13: ; link_dead_code::inline_fn
next:10'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~
14: ; Function Attrs: inlinehint mustprogress nofree norecurse nosync nounwind nonlazybind readnone uwtable willreturn
15: define hidden i32 @_ZN14link_dead_code9inline_fn17h40c8ae5d8dd63d23E() unnamed_addr #1 {
17: ret i32 2
18: }
19:
20: ; link_dead_code::private_fn
20: ; link_dead_code::private_fn
21: ; Function Attrs: mustprogress nofree norecurse nosync nounwind nonlazybind readnone uwtable willreturn
next:21'0 X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
22: define i32 @_ZN14link_dead_code10private_fn17hce5fdadfd9890a1bE() unnamed_addr #0 {
next:21'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next:21'1 ? possible intended match
23: start:
next:21'0 ~~~~~~~
24: ret i32 3
next:21'0 ~~~~~~~~~~~
25: }
next:21'0 ~~
26:
next:21'0 ~
27: attributes #0 = { mustprogress nofree norecurse nosync nounwind nonlazybind readnone uwtable willreturn "probe-stack"="__rust_probestack" "target-cpu"="x86-64" }
next:21'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.
.
>>>>>>
------------------------------------------
------------------------------------------
---- [codegen] src/test/codegen/some-global-nonnull.rs stdout ----
error: verification with 'FileCheck' failed
status: exit status: 1
command: "/usr/lib/llvm-13/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/some-global-nonnull/some-global-nonnull.ll" "/checkout/src/test/codegen/some-global-nonnull.rs" "--allow-unused-prefixes" "--check-prefixes" "CHECK,NONMSVC"
stdout: none
--- stderr -------------------------------
/checkout/src/test/codegen/some-global-nonnull.rs:6:16: error: CHECK-NEXT: is not on the line after the previous match
// CHECK-NEXT: start:
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/some-global-nonnull/some-global-nonnull.ll:11:1: note: 'next' match was here
^
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/some-global-nonnull/some-global-nonnull.ll:6:6: note: previous match ended here
@test = unnamed_addr alias void (), void ()* @_ZN19some_global_nonnull6inner017h9c8dd77415a58585E
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/some-global-nonnull/some-global-nonnull.ll:7:1: note: non-matching line after previous match is here
^
Input file: /checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/some-global-nonnull/some-global-nonnull.ll
-dump-input=help explains the following input dump.
Input was:
<<<<<<
.
.
.
.
6: @test = unnamed_addr alias void (), void ()* @_ZN19some_global_nonnull6inner017h9c8dd77415a58585E
7:
8: ; some_global_nonnull::test_inner
9: ; Function Attrs: nonlazybind uwtable
10: define void @_ZN19some_global_nonnull10test_inner17hcdf1062aa00be493E(i64* %0) unnamed_addr #0 {
11: start:
next:6 !~~~~~ error: match on wrong line
12: %.not = icmp eq i64* %0, null
13: br i1 %.not, label %bb3, label %bb1
14:
15: bb1: ; preds = %start
16: %1 = bitcast i64* %0 to void ()*
.
.
>>>>>>
------------------------------------------
------------------------------------------
---- [codegen] src/test/codegen/thread-local.rs stdout ----
error: verification with 'FileCheck' failed
status: exit status: 1
command: "/usr/lib/llvm-13/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/thread-local/thread-local.ll" "/checkout/src/test/codegen/thread-local.rs" "--allow-unused-prefixes" "--check-prefixes" "CHECK,NONMSVC"
stdout: none
--- stderr -------------------------------
/checkout/src/test/codegen/thread-local.rs:17:11: error: CHECK: expected string not found in input
// CHECK: [[TLS:@.+]] = internal thread_local unnamed_addr global
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/thread-local/thread-local.ll:9:111: note: scanning from here
@_ZN16thread_local_aux1A7__getit3VAL17h150aaf5c477fbca5E = external thread_local local_unnamed_addr global i64
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/thread-local/thread-local.ll:10:45: note: possible intended match here
@_ZN12thread_local1A7__getit3VAL17h6bf9be1eebdbc01aE = thread_local local_unnamed_addr global <{ [4 x i8] }> <{ [4 x i8] c"\01\00\00\00" }>, align 4
/checkout/src/test/codegen/thread-local.rs:22:35: error: undefined variable: TLS
/checkout/src/test/codegen/thread-local.rs:22:35: error: undefined variable: TLS
// CHECK: %0 = load i32, {{.*}}[[TLS]]{{.*}}
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/thread-local/thread-local.ll:16:2: note: possible intended match here
%0 = load i32, i32* bitcast (<{ [4 x i8] }>* @_ZN12thread_local1A7__getit3VAL17h6bf9be1eebdbc01aE to i32*), align 4
/checkout/src/test/codegen/thread-local.rs:30:34: error: undefined variable: TLS
/checkout/src/test/codegen/thread-local.rs:30:34: error: undefined variable: TLS
// CHECK: store i32 %0, {{.*}}[[TLS]]{{.*}}
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/thread-local/thread-local.ll:23:2: note: possible intended match here
store i32 %0, i32* bitcast (<{ [4 x i8] }>* @_ZN12thread_local1A7__getit3VAL17h6bf9be1eebdbc01aE to i32*), align 4, !alias.scope !2, !noalias !5
Input file: /checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/thread-local/thread-local.ll
Check file: /checkout/src/test/codegen/thread-local.rs
-dump-input=help explains the following input dump.
Input was:
<<<<<<
<<<<<<
1: ; ModuleID = 'thread_local.f5a81537-cgu.0'
2: source_filename = "thread_local.f5a81537-cgu.0"
3: target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
4: target triple = "x86_64-unknown-linux-gnu"
5:
6: %"unwind::libunwind::_Unwind_Exception" = type { i64, void (i32, %"unwind::libunwind::_Unwind_Exception"*)*, [6 x i64] }
7: %"unwind::libunwind::_Unwind_Context" = type { [0 x i8] }
8:
9: @_ZN16thread_local_aux1A7__getit3VAL17h150aaf5c477fbca5E = external thread_local local_unnamed_addr global i64
check:17'0 X error: no match found
10: @_ZN12thread_local1A7__getit3VAL17h6bf9be1eebdbc01aE = thread_local local_unnamed_addr global <{ [4 x i8] }> <{ [4 x i8] c"\01\00\00\00" }>, align 4
check:17'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:17'1 ? possible intended match
11: @_ZN12thread_local1A7__getit5STATE17hec7af2efbc79bb8eE = thread_local local_unnamed_addr global <{ [1 x i8] }> zeroinitializer, align 1
check:17'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
12:
check:17'0 ~
13: ; Function Attrs: mustprogress nofree norecurse nosync nounwind nonlazybind readonly uwtable willreturn
check:17'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
14: define i32 @get() unnamed_addr #0 personality i32 (i32, i32, i64, %"unwind::libunwind::_Unwind_Exception"*, %"unwind::libunwind::_Unwind_Context"*)* @rust_eh_personality {
check:17'0 ~~~~~~~~~~~~~~~
check:22'0 X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: match failed for invalid pattern
check:22'1 undefined variable: TLS
15: start:
check:22'0 ~~~~~~~
16: %0 = load i32, i32* bitcast (<{ [4 x i8] }>* @_ZN12thread_local1A7__getit3VAL17h6bf9be1eebdbc01aE to i32*), align 4
check:22'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:22'2 ? possible intended match
17: ret i32 %0
check:22'0 ~~~~~~~~~~~~
18: }
check:22'0 ~~
19:
check:22'0 ~
20: ; Function Attrs: mustprogress nofree nosync nounwind nonlazybind uwtable willreturn
check:22'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
21: define void @set(i32 %0) unnamed_addr #1 personality i32 (i32, i32, i64, %"unwind::libunwind::_Unwind_Exception"*, %"unwind::libunwind::_Unwind_Context"*)* @rust_eh_personality {
check:22'0 ~~~~~~~~~~~~~~~~
check:30'0 X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: match failed for invalid pattern
check:30'1 undefined variable: TLS
22: start:
check:30'0 ~~~~~~~
23: store i32 %0, i32* bitcast (<{ [4 x i8] }>* @_ZN12thread_local1A7__getit3VAL17h6bf9be1eebdbc01aE to i32*), align 4, !alias.scope !2, !noalias !5
check:30'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:30'2 ? possible intended match
24: ret void
check:30'0 ~~~~~~~~~~
25: }
check:30'0 ~~
26:
check:30'0 ~
27: ; Function Attrs: mustprogress nofree norecurse nosync nounwind nonlazybind readonly uwtable willreturn
check:30'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
28: define i64 @get_aux() unnamed_addr #0 personality i32 (i32, i32, i64, %"unwind::libunwind::_Unwind_Exception"*, %"unwind::libunwind::_Unwind_Context"*)* @rust_eh_personality {
check:30'0 ~~~~~~~~~~~~~~~~~~~
.
.
>>>>>>
------------------------------------------
:umbrella: The latest upstream changes (presumably #101560) made this pull request unmergeable. Please resolve the merge conflicts.
The job mingw-check failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
Checking rustc_builtin_macros v0.0.0 (/checkout/compiler/rustc_builtin_macros)
error[E0308]: arguments to this function are incorrect
--> compiler/rustc_middle/src/middle/privacy.rs:126:21
|
126 | if tree.is_descendant_of(current_restricted_id, restricted_id) {
| ^^^^^^^^^^^^^^^^ --------------------- ------------- expected struct `rustc_span::def_id::DefId`, found struct `rustc_span::def_id::LocalDefId`
| expected struct `rustc_span::def_id::DefId`, found struct `rustc_span::def_id::LocalDefId`
|
note: associated function defined here
--> compiler/rustc_middle/src/ty/mod.rs:339:8
--> compiler/rustc_middle/src/ty/mod.rs:339:8
|
339 | fn is_descendant_of(self, mut descendant: DefId, ancestor: DefId) -> bool {
error[E0308]: arguments to this function are incorrect
--> compiler/rustc_middle/src/middle/privacy.rs:160:29
|
|
160 | if tree.is_descendant_of(current_restricted_id, inherited_restricted_id) {
| ^^^^^^^^^^^^^^^^ --------------------- ----------------------- expected struct `rustc_span::def_id::DefId`, found struct `rustc_span::def_id::LocalDefId`
| expected struct `rustc_span::def_id::DefId`, found struct `rustc_span::def_id::LocalDefId`
|
note: associated function defined here
--> compiler/rustc_middle/src/ty/mod.rs:339:8
--> compiler/rustc_middle/src/ty/mod.rs:339:8
|
339 | fn is_descendant_of(self, mut descendant: DefId, ancestor: DefId) -> bool {
For more information about this error, try `rustc --explain E0308`.
error: could not compile `rustc_middle` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
:umbrella: The latest upstream changes (presumably #101949) made this pull request unmergeable. Please resolve the merge conflicts.
:umbrella: The latest upstream changes (presumably #102234) made this pull request unmergeable. Please resolve the merge conflicts.
ping from triage: @Bryanskiy
Can you please address the merge conflicts - and post your status on this PR?
FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.
this PR was supposed to be a draft for intermediate results. Since I haven't used it, I'll close it.