rust icon indicating copy to clipboard operation
rust copied to clipboard

rustc_target: Update some old naming around self contained linking

Open petrochenkov opened this issue 2 years ago • 3 comments

The "fallback" naming pre-dates introduction of -Clink-self-contained. Noticed when reviewing https://github.com/rust-lang/rust/pull/99500.

This PR doesn't break any json target spec, but supporting per-linker-flavor startup objects needed by https://github.com/rust-lang/rust/pull/99500 will break them, so maybe next time I'll remove the compatibility names.

petrochenkov avatar Aug 03 '22 23:08 petrochenkov

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

rust-highfive avatar Aug 03 '22 23:08 rust-highfive

:warning: Warning :warning:

rust-highfive avatar Aug 03 '22 23:08 rust-highfive

+1 This naming makes the option a lot less confusing. LGTM

luqmana avatar Aug 05 '22 19:08 luqmana

r? compiler

lcnr avatar Aug 06 '22 18:08 lcnr

r? compiler

fee1-dead avatar Aug 07 '22 03:08 fee1-dead

@bors r+

davidtwco avatar Aug 09 '22 13:08 davidtwco

:pushpin: Commit e74299b6f10d525ec64d8b6e5c0587624d256b2b has been approved by davidtwco

It is now in the queue for this repository.

bors avatar Aug 09 '22 13:08 bors

:umbrella: The latest upstream changes (presumably #100426) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Aug 12 '22 00:08 bors

@bors r=davidtwco

petrochenkov avatar Aug 12 '22 18:08 petrochenkov

:pushpin: Commit 8fa707ab417b7c6b2cc9a57435cbc48b53c69f7e has been approved by davidtwco

It is now in the queue for this repository.

bors avatar Aug 12 '22 18:08 bors