rust-clippy

rust-clippy copied to clipboard

Don't lint assigning_clones on nested late init locals

1

Fixes #12741 changelog: none

Alexendoo

### Summary The `clippy::assigning_clones` diagnostic suggests calling `clone_from` on an uninitialized variable. ### Lint Name clippy::assigning_clones ### Reproducer I tried this code: ```rust pub fn test() -> (String, String) {...

wanda-phi

Lint casting integers to pointers

1

https://github.com/rust-lang/rust/pull/45527 gives us `std::ptr::dangling` which allows replacing `1 as _` with `std::ptr::dangling()`. Once that is stable, it should be a warn lint. Until then an allow lint is ok. Should...

oli-obk

Clippy can run the wrong rustc, leading to "incompatible version of rustc" errors

12

### Summary I had several versions of Rust installed (via rustup) and was surprised that Clippy would sometimes give errors like this: ``` error[E0514]: found crate `paste` compiled by an...

jorendorff

### Summary Originally submitted for Rocket, as i thought it was the macro. ### Lint Name clippy::significant-drop-tightening ### Reproducer I tried this code: ```rust /// Library "hipster": use rocket_sync_db_pools::{database, diesel};...

madser123

### Summary unnecessary_cast should catch unnecessary pointer casts like `&u32` to `*const u32` when this would already be done implicitly edge case to consider: it is not always converted implicitly,...

antonilol

`redundant_async_block` not catching uses with nontrivial futures

1

### Summary The `redundant_async_block` lint fails to trigger on uses of `async { EXPRESSION.await }` for seemingly any `EXPRESSION` other than a single variable. ### Lint Name redundant_async_block ### Reproducer...

jwodder

### Summary Using `{integer}::from_str_radix(string, 10)` (Using `const_int_from_str` feature) in const contexts causes Clippy to suggest using `string.parse::()`, which is not possible in const contexts. ### Lint Name from_str_radix_10 ### Reproducer...

doonv

`needless_return`: Support `#[expect]` on the return statement

4

A fix for https://github.com/rust-lang/rust-clippy/issues/9361 suppresses `clippy::needless_return` if there are any attributes on the `return` statement. This leads to some unexpected behavior, as described in https://github.com/rust-lang/rust-clippy/issues/12998, where adding `#[expect(clippy::needless_return)]` suppresses the...

xFrednet

cast_possible_truncation: Fix some false-positive cases

1

Fix partially https://github.com/rust-lang/rust-clippy/issues/7486#issuecomment-1843248881. Fix #9613. changelog: [`cast_possible_truncation`]: fix some false-positive on % operator, valid constants, and size_of

tesuji