rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard

Lint `collapsible_str_replace`

Open nahuakang opened this issue 2 years ago • 2 comments

fixes #6651

changelog: [`collapsible_str_replace`]: create new lint `collapsible_str_replace`

If you added a new lint, here's a checklist for things that will be checked during review or continuous integration.

  • [x] Followed [lint naming conventions][lint_naming]
  • [x] Added passing UI tests (including committed .stderr file)
  • [x] cargo test passes locally
  • [ ] Executed cargo dev update_lints
  • [x] Added lint documentation
  • [x] Run cargo dev fmt

nahuakang avatar Jul 31 '22 20:07 nahuakang

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

rust-highfive avatar Jul 31 '22 20:07 rust-highfive

:umbrella: The latest upstream changes (presumably #9264) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Aug 02 '22 11:08 bors

:umbrella: The latest upstream changes (presumably #8957) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Aug 19 '22 15:08 bors

@bors r+

Thanks! That implementation turned out nicely!

flip1995 avatar Aug 20 '22 13:08 flip1995

:pushpin: Commit b070b4045f348f9222008270a435bda17b048c15 has been approved by flip1995

It is now in the queue for this repository.

bors avatar Aug 20 '22 13:08 bors

:hourglass: Testing commit b070b4045f348f9222008270a435bda17b048c15 with merge 5820addb240ddcf13712be686c141a3d00ae792a...

bors avatar Aug 20 '22 13:08 bors

@flip1995 @xFrednet Thank you both for your patience and help 🙏 It's absolutely just wonderful to come back to the project and receive so much support and help ❤️

nahuakang avatar Aug 20 '22 13:08 nahuakang

:sunny: Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test Approved by: flip1995 Pushing 5820addb240ddcf13712be686c141a3d00ae792a to master...

bors avatar Aug 20 '22 13:08 bors