rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard

Add a lint for static items with large type alignment

Open Jaic1 opened this issue 3 years ago • 7 comments

The goal of this PR is to warn the usage of static items which have type alignment larger than page size (typically 4KB).

Due to some known unsound issues, the type alignment may not be fulfilled. For more information, see rust-lang/rust#70022 and rust-lang/rust#70143.

changelog: add lint [static_items_large_align]

Jaic1 avatar Mar 27 '22 09:03 Jaic1

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

Please see the contribution instructions for more information.

rust-highfive avatar Mar 27 '22 09:03 rust-highfive

:umbrella: The latest upstream changes (presumably #8576) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Mar 30 '22 17:03 bors

All my comments are for follow up improvements. IMO we can merge this as is

oli-obk avatar Apr 01 '22 11:04 oli-obk

:umbrella: The latest upstream changes (presumably #8594) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Apr 04 '22 07:04 bors

Ping @Jaic1. Are you willing to continue working on this? It doesn't seem like there are any major blockers for merging.

Jarcho avatar Aug 30 '22 00:08 Jarcho

@Jarcho Sure, I can resolve the conflicts at the moment. For the potential improvements mentioned above, maybe I can pick it up some day.

Jaic1 avatar Aug 30 '22 04:08 Jaic1

Please rebase instead of merge. When you rebase, the merge commit gets removed automatically without you needing to do anything

oli-obk avatar Sep 08 '22 06:09 oli-obk

:umbrella: The latest upstream changes (presumably #9511) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Sep 27 '22 18:09 bors

@Jaic1 I'm closing this for inactivity. It seems like you're not active in the OSS ecosystem anymore, so, have luck in whatever else you're doing! :heart:.

If you'd like to continue with this PR, don't hesitate to comment and I'll reopen it! Thanks for trying ~(=^‥^)/.

Edit: Similar to rust-lang/rust#116520

blyxyas avatar Oct 19 '23 15:10 blyxyas