rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard

feat(format_push_string): give a (possibly incomplete) suggestion

Open ada4a opened this issue 2 months ago • 6 comments

Resolves https://github.com/rust-lang/rust-clippy/issues/8824

Supersedes https://github.com/rust-lang/rust-clippy/pull/15828 -- I wasn't able to get TyCtxt::in_scope_traits to work, so here's a more basic implementation that just adds a note about the possible need to import std::fmt::Write.

changelog: [format_push_string]: add a suggestion

ada4a avatar Nov 14 '25 22:11 ada4a

r? @samueltardieu

rustbot has assigned @samueltardieu. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Nov 14 '25 22:11 rustbot

Lintcheck changes for 34551be259d4b14af3103d0b61d2ef9d310b9f36

Lint Added Removed Changed
clippy::format_push_string 0 0 29

This comment will be updated if you push new changes

github-actions[bot] avatar Nov 14 '25 23:11 github-actions[bot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot avatar Nov 18 '25 07:11 rustbot

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot avatar Nov 28 '25 17:11 rustbot

@rustbot ready

ada4a avatar Nov 28 '25 17:11 ada4a

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot avatar Dec 11 '25 09:12 rustbot