rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard
verified publisher icon rust-lang

Fix `map_unwrap_or` fail to cover `Result::unwrap_or`

Open profetia opened this issue 3 months ago • 15 comments

Closes rust-lang/rust-clippy#15713 Closes rust-lang/rust-clippy#15714 Closes rust-lang/rust-clippy#15752

changelog: [map_unwrap_or] add cover for Result::unwrap_or

profetia avatar Sep 19 '25 15:09 profetia

r? @blyxyas

rustbot has assigned @blyxyas. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Sep 19 '25 15:09 rustbot

Lintcheck changes for a0f09e97b39994283c2a58923e44d4529d6a9723

Lint Added Removed Changed
clippy::map_unwrap_or 15 0 5

This comment will be updated if you push new changes

github-actions[bot] avatar Sep 19 '25 16:09 github-actions[bot]

Unless you have a good reason not to, please use map_unwrap_or_fixable.rs for the tests.

samueltardieu avatar Sep 19 '25 16:09 samueltardieu

Moved. Thank you!

profetia avatar Sep 19 '25 16:09 profetia

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot avatar Sep 23 '25 16:09 rustbot

Also fixes #15713

profetia avatar Sep 23 '25 16:09 profetia

Also closes #15752

profetia avatar Sep 24 '25 01:09 profetia

Updated. Thank you

profetia avatar Sep 29 '25 18:09 profetia

:umbrella: The latest upstream changes (possibly ebbbbebf2dbb4df97193463d1de61a9737315ef0) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot avatar Oct 11 '25 07:10 rustbot

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot avatar Oct 14 '25 00:10 rustbot

r? clippy

profetia avatar Oct 21 '25 21:10 profetia

Done. Thank you!

profetia avatar Oct 23 '25 21:10 profetia

r? clippy

profetia avatar Nov 05 '25 19:11 profetia

r? clippy

profetia avatar Nov 25 '25 20:11 profetia

r? clippy

profetia avatar Dec 07 '25 01:12 profetia

:umbrella: The latest upstream changes (possibly 34fab5cd37188e6a7ab0f089c356c7e9665ac318) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot avatar Dec 18 '25 16:12 rustbot

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot avatar Dec 18 '25 18:12 rustbot

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot avatar Dec 18 '25 18:12 rustbot

Also closes #16258

profetia avatar Dec 18 '25 18:12 profetia