rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard

Document `pub` functions in `clippy_utils`

Open samueltardieu opened this issue 4 months ago • 10 comments

Description

Quite a lot of functions in clippy_utils lack documentation. Ideally, the missing_docs lint should be enabled on this crate, except for selected entities such as the static path definitions in the paths module (which might be moved into a submodule).

Note: we are not looking for LLM generated verbose documentation.

Version


Additional Labels

@rustbot label "+good first issue"

samueltardieu avatar Aug 26 '25 19:08 samueltardieu

Maybe we can add an internal lint to for adding pub functions in clippy_utils after all the undocumented ones are dealt with. What do you think?

profetia avatar Aug 27 '25 01:08 profetia

Why not use the missing_docs lint?

samueltardieu avatar Aug 27 '25 07:08 samueltardieu

@rustbot claim

code-with-aneesh avatar Sep 16 '25 12:09 code-with-aneesh

@rustbot release-assignment

code-with-aneesh avatar Sep 18 '25 11:09 code-with-aneesh

Ideally, the missing_docs lint should be enabled on this crate

We'll probably do this module-by-module, so I would put the #[deny(missing_lints)]s onto module definitions in clippy_utils/lib.rs, to track progress in a visual way

ada4a avatar Sep 25 '25 20:09 ada4a

@rustbot claim

fernandovtorres avatar Nov 11 '25 19:11 fernandovtorres

@rustbot release-assignment

fernandovtorres avatar Nov 12 '25 02:11 fernandovtorres

Hello!

I am interested in working on this issue. I am looking to start contributing to the Rust project and this seems like a great entry point for me to learn the codebase and contribution process.

Could I please be assigned this issue?

Thank you!

Chirag-Janbandhu avatar Dec 11 '25 15:12 Chirag-Janbandhu

@Chirag-Janbandhu thank you for your interest:)

You can assign an issue to yourself by writing [@]rustbot claim (without the square brackets). That said, I'm not sure that makes sense for this particular issue, as there are quite a lot of functions of clippy_utils to document 😅 So it would be perfectly fine to document only a batch of functions and open a PR for that:)

ada4a avatar Dec 11 '25 16:12 ada4a

@rustbot claim

Chirag-Janbandhu avatar Dec 12 '25 03:12 Chirag-Janbandhu