rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard

Add units/unit prefixes of frequency to doc-valid-idents

Open ROMemories opened this issue 1 year ago • 1 comments

These units/unit prefixes often come up in the embedded world.

Should this PR also modify the test_units test? It seems only concerned with data units currently; should it also test frequency units?

changelog: [doc_markdown]: Add MHz, GHz, and THz to doc-valid-idents.

ROMemories avatar Sep 26 '24 08:09 ROMemories

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Centri3 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar Sep 26 '24 08:09 rustbot

@bors r+

Centri3 avatar Oct 24 '24 08:10 Centri3

:pushpin: Commit 62026c32288f86b4337dcf17bf4fabd15a140a92 has been approved by Centri3

It is now in the queue for this repository.

bors avatar Oct 24 '24 08:10 bors

:hourglass: Testing commit 62026c32288f86b4337dcf17bf4fabd15a140a92 with merge c2534dcc49b407930fa4e2205beb67eda55fce48...

bors avatar Oct 24 '24 08:10 bors

And actually yeah, putting these in test_units would've made more sense, specifically stuff like 3MHz. I won't hold it up for that though

Centri3 avatar Oct 24 '24 08:10 Centri3

:sunny: Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test Approved by: Centri3 Pushing c2534dcc49b407930fa4e2205beb67eda55fce48 to master...

bors avatar Oct 24 '24 08:10 bors

Thanks a lot for merging this!

ROMemories avatar Oct 24 '24 09:10 ROMemories