rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard

Fix [`needless_return`] false negative

Open apoisternex opened this issue 1 year ago • 2 comments

Fixes #12907

changelog: Fix [needless_return] false negative when returned expression borrows a value.

apoisternex avatar Aug 04 '24 13:08 apoisternex

r? @Centri3

rustbot has assigned @Centri3. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Aug 04 '24 13:08 rustbot

Looks good to me, thanks! Let's just wait for the assigned reviewer to take a look before approving.

GuillaumeGomez avatar Aug 09 '24 09:08 GuillaumeGomez

Thank you! @bors r+

Centri3 avatar Sep 07 '24 21:09 Centri3

:pushpin: Commit 66283bff5fde5f310f3dd373d22cd4f892b3d312 has been approved by Centri3

It is now in the queue for this repository.

bors avatar Sep 07 '24 21:09 bors

:hourglass: Testing commit 66283bff5fde5f310f3dd373d22cd4f892b3d312 with merge 41dc86d4d39df1efba899a612296bb3ce5af7472...

bors avatar Sep 07 '24 21:09 bors

:sunny: Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test Approved by: Centri3 Pushing 41dc86d4d39df1efba899a612296bb3ce5af7472 to master...

bors avatar Sep 07 '24 21:09 bors